All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jindal, Sonika" <sonika.jindal@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/i915: Also disable PSR on Sink when disabling it on Source.
Date: Thu, 19 Nov 2015 04:26:25 +0000	[thread overview]
Message-ID: <000C66961D35964B9714611E548C10AD0C319A17@BGSMSX104.gar.corp.intel.com> (raw)
In-Reply-To: <1447893575-25369-4-git-send-email-rodrigo.vivi@intel.com>

Why not move it inside the mutex_lock/unlock on psr.lock ?

Regards,
Sonika

-----Original Message-----
From: Vivi, Rodrigo 
Sent: Thursday, November 19, 2015 6:10 AM
To: intel-gfx@lists.freedesktop.org
Cc: Vivi, Rodrigo; Jindal, Sonika
Subject: [PATCH 3/3] drm/i915: Also disable PSR on Sink when disabling it on Source.

It is not a bad idea to disable the PSR feature on Sink when we are disabling on the Source.

Cc: Sonika Jindal <sonika.jindal@intel.com>
Suggested-by: Sonika Jindal <sonika.jindal@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 38ea4d0..de31162 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -527,6 +527,9 @@ void intel_psr_disable(struct intel_dp *intel_dp)
 	mutex_unlock(&dev_priv->psr.lock);
 
 	cancel_delayed_work_sync(&dev_priv->psr.work);
+
+	/* Disable PSR on Sink */
+	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
 }
 
 static void intel_psr_work(struct work_struct *work)
--
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-11-19  4:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19  0:39 [PATCH 0/3] More PSR improvements Rodrigo Vivi
2015-11-19  0:39 ` [PATCH 1/3] drm/i915: Also delay first activation for SKL+ Rodrigo Vivi
2015-11-19  6:07   ` R, Durgadoss
2015-11-19  8:44   ` Daniel Stone
2015-11-19 18:45     ` Vivi, Rodrigo
2015-11-19  0:39 ` [PATCH 2/3] drm/i915: Remove PSR Perf Counter " Rodrigo Vivi
2015-11-19  6:09   ` R, Durgadoss
2015-11-19  7:45     ` Jindal, Sonika
2015-11-19 18:31       ` Rodrigo Vivi
2015-11-20  6:01         ` Jindal, Sonika
2015-11-20 19:14           ` Vivi, Rodrigo
2015-11-23 22:16             ` [PATCH] " Rodrigo Vivi
2015-11-24 12:33               ` Daniel Vetter
2015-11-19  0:39 ` [PATCH 3/3] drm/i915: Also disable PSR on Sink when disabling it on Source Rodrigo Vivi
2015-11-19  4:26   ` Jindal, Sonika [this message]
2015-11-23 22:19     ` [PATCH] " Rodrigo Vivi
2015-11-24  4:40       ` Jindal, Sonika
2015-11-24 12:34         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000C66961D35964B9714611E548C10AD0C319A17@BGSMSX104.gar.corp.intel.com \
    --to=sonika.jindal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.