From: "Doug Smythies" <dsmythies@telus.net>
To: "'Srinivas Pandruvada'" <srinivas.pandruvada@linux.intel.com>,
<rafael.j.wysocki@intel.com>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<Mario.Limonciello@amd.com>,
"'Swapnil Sapkal'" <swapnil.sapkal@amd.com>, <Ray.Huang@amd.com>,
"Doug Smythies" <dsmythies@telus.net>
Subject: [PATCH v3] tools/power/x86/intel_pstate_tracer: python minimum version
Date: Sun, 17 Sep 2023 21:03:54 -0700 [thread overview]
Message-ID: <002401d9e9e5$248f3d50$6dadb7f0$@telus.net> (raw)
In-Reply-To: <002301d9e9e2$13424090$39c6c1b0$@telus.net>
From: Doug Smythies <dsmythies@telus.net>
Change the minimum python version from 2.7 to 3.6.
Remove a 2.X backwards compatibility line.
Signed-off-by: Doug Smythies <dsmythies@telus.net>
---
v2 -> v3: Try to fix mess that was v2.
v1 -> v2: Fix careless typos.
---
.../x86/intel_pstate_tracer/intel_pstate_tracer.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
index ec3323100e1a..38cfbdcdedb7 100755
--- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
+++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-2.0-only
# -*- coding: utf-8 -*-
#
@@ -11,11 +11,11 @@ then this utility enables and collects trace data for a user specified interval
and generates performance plots.
Prerequisites:
- Python version 2.7.x or higher
+ Python version 3.6.x or higher
gnuplot 5.0 or higher
- gnuplot-py 1.8 or higher
+ python3-gnuplot 1.8 or higher
(Most of the distributions have these required packages. They may be called
- gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... )
+ gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... )
HWP (Hardware P-States are disabled)
Kernel config for Linux trace is enabled
@@ -23,7 +23,7 @@ Prerequisites:
see print_help(): for Usage and Output details
"""
-from __future__ import print_function
+
from datetime import datetime
import subprocess
import os
@@ -562,7 +562,7 @@ if __name__ == "__main__":
# Temporary (or perhaps not)
cur_version = sys.version_info
- print('python version (should be >= 2.7):')
+ print('python version (should be >= 3.6):')
print(cur_version)
# Left as "cleanup" for potential future re-run ability.
--
2.25.1
next prev parent reply other threads:[~2023-09-18 4:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 21:29 [PATCH] tools/power/x86/intel_pstate_tracer: python minimum version Doug Smythies
2023-09-18 0:57 ` Mario Limonciello
2023-09-18 3:41 ` Doug Smythies
2023-09-18 3:41 ` [PATCH v2] " Doug Smythies
2023-09-18 4:03 ` Doug Smythies [this message]
2023-09-18 17:25 ` [PATCH v3] " srinivas pandruvada
2023-09-18 17:35 ` Mario Limonciello
2023-09-19 7:40 ` Swapnil Sapkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002401d9e9e5$248f3d50$6dadb7f0$@telus.net' \
--to=dsmythies@telus.net \
--cc=Mario.Limonciello@amd.com \
--cc=Ray.Huang@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=swapnil.sapkal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.