All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: [PATCH 03/23] Process vmstop requests in IO thread
Date: Fri,  4 Feb 2011 13:47:06 -0200	[thread overview]
Message-ID: <00d6e393b0a59b558e86e73625c47610a7382f19.1296834446.git.mtosatti@redhat.com> (raw)
In-Reply-To: <cover.1296834446.git.mtosatti@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

A pending vmstop request is also a reason to leave the inner main loop.
So far we ignored it, and pending stop requests issued over VCPU threads
were simply ignored.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
 vl.c |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/vl.c b/vl.c
index b1dc3ff..57b4c9f 100644
--- a/vl.c
+++ b/vl.c
@@ -1391,15 +1391,11 @@ void main_loop_wait(int nonblocking)
 
 static int vm_can_run(void)
 {
-    if (powerdown_requested)
-        return 0;
-    if (reset_requested)
-        return 0;
-    if (shutdown_requested)
-        return 0;
-    if (debug_requested)
-        return 0;
-    return 1;
+    return !(powerdown_requested ||
+             reset_requested ||
+             shutdown_requested ||
+             debug_requested ||
+             vmstop_requested);
 }
 
 qemu_irq qemu_system_powerdown;
-- 
1.7.2.3


WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 03/23] Process vmstop requests in IO thread
Date: Fri,  4 Feb 2011 13:47:06 -0200	[thread overview]
Message-ID: <00d6e393b0a59b558e86e73625c47610a7382f19.1296834446.git.mtosatti@redhat.com> (raw)
In-Reply-To: <cover.1296834446.git.mtosatti@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

A pending vmstop request is also a reason to leave the inner main loop.
So far we ignored it, and pending stop requests issued over VCPU threads
were simply ignored.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
 vl.c |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/vl.c b/vl.c
index b1dc3ff..57b4c9f 100644
--- a/vl.c
+++ b/vl.c
@@ -1391,15 +1391,11 @@ void main_loop_wait(int nonblocking)
 
 static int vm_can_run(void)
 {
-    if (powerdown_requested)
-        return 0;
-    if (reset_requested)
-        return 0;
-    if (shutdown_requested)
-        return 0;
-    if (debug_requested)
-        return 0;
-    return 1;
+    return !(powerdown_requested ||
+             reset_requested ||
+             shutdown_requested ||
+             debug_requested ||
+             vmstop_requested);
 }
 
 qemu_irq qemu_system_powerdown;
-- 
1.7.2.3

  parent reply	other threads:[~2011-02-04 15:49 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04 15:47 [PATCH 00/23] [PULL] qemu-kvm.git uq/master queue Marcelo Tosatti
2011-02-04 15:47 ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 01/23] Prevent abortion on multiple VCPU kicks Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 02/23] Stop current VCPU on synchronous reset requests Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` Marcelo Tosatti [this message]
2011-02-04 15:47   ` [Qemu-devel] [PATCH 03/23] Process vmstop requests in IO thread Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 04/23] Trigger exit from cpu_exec_all on pending IO events Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 05/23] Leave inner main_loop faster on pending requests Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 06/23] Flatten the main loop Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 07/23] kvm: Report proper error on GET_VCPU_MMAP_SIZE failures Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 08/23] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 09/23] kvm: Handle kvm_init_vcpu errors Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 10/23] kvm: Provide sigbus services arch-independently Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 11/23] Refactor signal setup functions in cpus.c Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 12/23] kvm: Set up signal mask also for !CONFIG_IOTHREAD Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 13/23] kvm: Refactor qemu_kvm_eat_signals Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 14/23] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 15/23] Set up signalfd " Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 16/23] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 17/23] kvm: Add MCE signal support for !CONFIG_IOTHREAD Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 18/23] Introduce VCPU self-signaling service Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 19/23] kvm: Unconditionally reenter kernel after IO exits Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 20/23] kvm: Remove static return code of kvm_handle_io Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 21/23] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 15:47 ` [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-08 11:39   ` Aurelien Jarno
2011-02-08 11:39     ` Aurelien Jarno
2011-02-08 11:42     ` Jan Kiszka
2011-02-08 11:42       ` Jan Kiszka
2011-02-04 15:47 ` [PATCH 23/23] kvm: make tsc stable over migration and machine start Marcelo Tosatti
2011-02-04 15:47   ` [Qemu-devel] " Marcelo Tosatti
2011-02-04 17:34 ` [Qemu-devel] [PATCH 00/23] [PULL] qemu-kvm.git uq/master queue Anthony Liguori
2011-02-04 17:34   ` Anthony Liguori
2011-02-04 17:52   ` Jan Kiszka
2011-02-04 18:21     ` [PATCH v3 02/23] Stop current VCPU on synchronous reset requests Jan Kiszka
2011-02-04 18:21       ` [Qemu-devel] " Jan Kiszka
2011-02-04 21:22       ` Marcelo Tosatti
2011-02-04 21:22         ` [Qemu-devel] " Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00d6e393b0a59b558e86e73625c47610a7382f19.1296834446.git.mtosatti@redhat.com \
    --to=mtosatti@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.