From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Juergen Gross" <jgross@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU
Date: Wed, 25 Sep 2019 17:27:55 +0200 [thread overview]
Message-ID: <052b6003-53a7-0563-72ac-48fe558ac549@suse.com> (raw)
There's nothing to restore here if there's no FPU in the first place.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
To be considered for 4.13 since RSTR_FP_ERR_PTRS support was introduced
just recently.
--- a/xen/tools/gen-cpuid.py
+++ b/xen/tools/gen-cpuid.py
@@ -168,8 +168,9 @@ def crunch_numbers(state):
deps = {
# FPU is taken to mean support for the x87 regisers as well as the
# instructions. MMX is documented to alias the %MM registers over the
- # x87 %ST registers in hardware.
- FPU: [MMX],
+ # x87 %ST registers in hardware. Correct restoring of error pointers
+ # of course makes no sense without there being anything to restore.
+ FPU: [MMX, RSTR_FP_ERR_PTRS],
# The PSE36 feature indicates that reserved bits in a PSE superpage
# may be used as extra physical address bits.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2019-09-25 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 15:27 Jan Beulich [this message]
2019-09-26 15:23 ` [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU Jürgen Groß
2019-12-09 13:06 ` Jan Beulich
2019-12-09 14:00 ` Jürgen Groß
2019-10-08 9:32 ` [Xen-devel] Ping: " Jan Beulich
2019-12-06 18:48 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=052b6003-53a7-0563-72ac-48fe558ac549@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.