All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>, Chen-Yu Tsai <wens@csie.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: [PATCH 4/15] clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT
Date: Tue,  7 Mar 2017 09:56:23 +0100	[thread overview]
Message-ID: <06becb54f965288aba6df203a369b524d4786a11.1488876832.git-series.maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <cover.bc06ffa88f847ddd9ddd7c259415d5f61b55307b.1488876832.git-series.maxime.ripard@free-electrons.com>
In-Reply-To: <cover.bc06ffa88f847ddd9ddd7c259415d5f61b55307b.1488876832.git-series.maxime.ripard@free-electrons.com>

The current code only rely on the parent to change its rate in the case
where CLK_SET_RATE_PARENT is set.

However, some clock rates might be obtained only through a modification of
the parent and the clock divider. Just rely on the round rate of the clocks
to give us the best computation that might be achieved for a given rate.

round_rate functions now need to honor CLK_SET_RATE_PARENT, but either the
functions already do that if they modify the parent, or don't modify the
praents at all.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/clk/sunxi-ng/ccu_mux.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/clk/sunxi-ng/ccu_mux.c b/drivers/clk/sunxi-ng/ccu_mux.c
index bae735e252b6..58b6e349a0ed 100644
--- a/drivers/clk/sunxi-ng/ccu_mux.c
+++ b/drivers/clk/sunxi-ng/ccu_mux.c
@@ -95,19 +95,7 @@ int ccu_mux_helper_determine_rate(struct ccu_common *common,
 		if (!parent)
 			continue;
 
-		if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) {
-			struct clk_rate_request parent_req = *req;
-			int ret = __clk_determine_rate(parent, &parent_req);
-
-			if (ret)
-				continue;
-
-			parent_rate = parent_req.rate;
-		} else {
-			parent_rate = clk_hw_get_rate(parent);
-		}
-
-		adj_parent_rate = parent_rate;
+		adj_parent_rate = parent_rate = clk_hw_get_rate(parent);
 		ccu_mux_helper_adjust_parent_for_prediv(common, cm, i,
 							&adj_parent_rate);
 
-- 
git-series 0.8.11

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Mike Turquette
	<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Daniel Vetter
	<daniel.vetter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: [PATCH 4/15] clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT
Date: Tue,  7 Mar 2017 09:56:23 +0100	[thread overview]
Message-ID: <06becb54f965288aba6df203a369b524d4786a11.1488876832.git-series.maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <cover.bc06ffa88f847ddd9ddd7c259415d5f61b55307b.1488876832.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
In-Reply-To: <cover.bc06ffa88f847ddd9ddd7c259415d5f61b55307b.1488876832.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

The current code only rely on the parent to change its rate in the case
where CLK_SET_RATE_PARENT is set.

However, some clock rates might be obtained only through a modification of
the parent and the clock divider. Just rely on the round rate of the clocks
to give us the best computation that might be achieved for a given rate.

round_rate functions now need to honor CLK_SET_RATE_PARENT, but either the
functions already do that if they modify the parent, or don't modify the
praents at all.

Signed-off-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
---
 drivers/clk/sunxi-ng/ccu_mux.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/clk/sunxi-ng/ccu_mux.c b/drivers/clk/sunxi-ng/ccu_mux.c
index bae735e252b6..58b6e349a0ed 100644
--- a/drivers/clk/sunxi-ng/ccu_mux.c
+++ b/drivers/clk/sunxi-ng/ccu_mux.c
@@ -95,19 +95,7 @@ int ccu_mux_helper_determine_rate(struct ccu_common *common,
 		if (!parent)
 			continue;
 
-		if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) {
-			struct clk_rate_request parent_req = *req;
-			int ret = __clk_determine_rate(parent, &parent_req);
-
-			if (ret)
-				continue;
-
-			parent_rate = parent_req.rate;
-		} else {
-			parent_rate = clk_hw_get_rate(parent);
-		}
-
-		adj_parent_rate = parent_rate;
+		adj_parent_rate = parent_rate = clk_hw_get_rate(parent);
 		ccu_mux_helper_adjust_parent_for_prediv(common, cm, i,
 							&adj_parent_rate);
 
-- 
git-series 0.8.11

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/15] clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT
Date: Tue,  7 Mar 2017 09:56:23 +0100	[thread overview]
Message-ID: <06becb54f965288aba6df203a369b524d4786a11.1488876832.git-series.maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <cover.bc06ffa88f847ddd9ddd7c259415d5f61b55307b.1488876832.git-series.maxime.ripard@free-electrons.com>

The current code only rely on the parent to change its rate in the case
where CLK_SET_RATE_PARENT is set.

However, some clock rates might be obtained only through a modification of
the parent and the clock divider. Just rely on the round rate of the clocks
to give us the best computation that might be achieved for a given rate.

round_rate functions now need to honor CLK_SET_RATE_PARENT, but either the
functions already do that if they modify the parent, or don't modify the
praents at all.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/clk/sunxi-ng/ccu_mux.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/clk/sunxi-ng/ccu_mux.c b/drivers/clk/sunxi-ng/ccu_mux.c
index bae735e252b6..58b6e349a0ed 100644
--- a/drivers/clk/sunxi-ng/ccu_mux.c
+++ b/drivers/clk/sunxi-ng/ccu_mux.c
@@ -95,19 +95,7 @@ int ccu_mux_helper_determine_rate(struct ccu_common *common,
 		if (!parent)
 			continue;
 
-		if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) {
-			struct clk_rate_request parent_req = *req;
-			int ret = __clk_determine_rate(parent, &parent_req);
-
-			if (ret)
-				continue;
-
-			parent_rate = parent_req.rate;
-		} else {
-			parent_rate = clk_hw_get_rate(parent);
-		}
-
-		adj_parent_rate = parent_rate;
+		adj_parent_rate = parent_rate = clk_hw_get_rate(parent);
 		ccu_mux_helper_adjust_parent_for_prediv(common, cm, i,
 							&adj_parent_rate);
 
-- 
git-series 0.8.11

  parent reply	other threads:[~2017-03-07  9:00 UTC|newest]

Thread overview: 146+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07  8:56 [PATCH 0/15] drm: sun4i: Add support for the HDMI controller Maxime Ripard
2017-03-07  8:56 ` Maxime Ripard
2017-03-07  8:56 ` Maxime Ripard
     [not found] ` <cover.bc06ffa88f847ddd9ddd7c259415d5f61b55307b.1488876832.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-03-07  8:56   ` [PATCH 1/15] clk: divider: Make divider_round_rate take the parent clock Maxime Ripard
2017-03-07  8:56     ` Maxime Ripard
2017-03-07  8:56     ` Maxime Ripard
2017-03-07  8:56     ` [rtc-linux] " Maxime Ripard
2017-03-07  8:56     ` Maxime Ripard
2017-03-07 14:11     ` Stephen Boyd
2017-03-07 14:11       ` Stephen Boyd
2017-03-07 14:11       ` Stephen Boyd
2017-03-07 14:11       ` [rtc-linux] " Stephen Boyd
2017-03-07 14:11       ` Stephen Boyd
     [not found]       ` <20170307141157.GC10239-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-03-09 10:55         ` Maxime Ripard
2017-03-09 10:55           ` Maxime Ripard
2017-03-09 10:55           ` Maxime Ripard
2017-03-09 10:55           ` [rtc-linux] " Maxime Ripard
2017-03-09 10:55           ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 2/15] clk: sunxi-ng: Pass the parent and a pointer to the clocks round rate Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 3/15] clk: sunxi-ng: div: Switch to divider_round_rate Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56 ` Maxime Ripard [this message]
2017-03-07  8:56   ` [PATCH 4/15] clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 5/15] clk: sunxi-ng: sun5i: Export video PLLs Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07 10:21   ` [linux-sunxi] " Julian Calaby
2017-03-07 10:21     ` Julian Calaby
2017-03-07 10:21     ` Julian Calaby
2017-03-08  8:58     ` [linux-sunxi] " Maxime Ripard
2017-03-08  8:58       ` Maxime Ripard
2017-03-08  8:58       ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-08  3:39   ` Chen-Yu Tsai
2017-03-08  3:39     ` Chen-Yu Tsai
2017-03-08  3:39     ` Chen-Yu Tsai
2017-03-15 17:26   ` Rob Herring
2017-03-15 17:26     ` Rob Herring
2017-03-15 17:26     ` Rob Herring
2017-04-03 20:59     ` Maxime Ripard
2017-04-03 20:59       ` Maxime Ripard
2017-04-03 20:59       ` Maxime Ripard
2017-05-03  3:27   ` Chen-Yu Tsai
2017-05-03  3:27     ` Chen-Yu Tsai
2017-05-03  3:27     ` Chen-Yu Tsai
2017-03-07  8:56 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Maxime Ripard
2017-03-07  8:56   ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner, tcon-channel property Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-08  3:38   ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Chen-Yu Tsai
2017-03-08  3:38     ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner, tcon-channel property Chen-Yu Tsai
2017-03-08  3:38     ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Chen-Yu Tsai
2017-03-15 17:37   ` Rob Herring
2017-03-15 17:37     ` Rob Herring
2017-03-15 17:37     ` Rob Herring
2017-03-17  3:34     ` Chen-Yu Tsai
2017-03-17  3:34       ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner, tcon-channel property Chen-Yu Tsai
2017-03-17  3:34       ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Chen-Yu Tsai
2017-03-26 21:11       ` Maxime Ripard
2017-03-26 21:11         ` Maxime Ripard
2017-03-26 21:11         ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 8/15] drm/sun4i: tcon: Add channel debug Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-08  3:37   ` Chen-Yu Tsai
2017-03-08  3:37     ` Chen-Yu Tsai
2017-03-08  3:37     ` Chen-Yu Tsai
2017-03-07  8:56 ` [PATCH 9/15] drm/sun4i: tcon: Pass the encoder to the mode set functions Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-08  3:51   ` Chen-Yu Tsai
2017-03-08  3:51     ` Chen-Yu Tsai
2017-03-08  3:51     ` Chen-Yu Tsai
2017-03-08  4:16     ` Stefan Monnier
2017-03-08  4:16       ` Stefan Monnier
2017-03-08  4:16       ` Stefan Monnier
2017-03-08  4:16       ` Stefan Monnier
2017-03-09 10:58     ` Maxime Ripard
2017-03-09 10:58       ` Maxime Ripard
2017-03-09 10:58       ` Maxime Ripard
2017-03-09 11:31       ` [linux-sunxi] " Chen-Yu Tsai
2017-03-09 11:31         ` Chen-Yu Tsai
2017-03-09 11:31         ` Chen-Yu Tsai
2017-03-09 14:55         ` [linux-sunxi] " Maxime Ripard
2017-03-09 14:55           ` Maxime Ripard
2017-03-09 14:55           ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 11/15] drm/sun4i: tcon: Fix tcon channel 1 backporch calculation Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-08  4:25   ` Chen-Yu Tsai
2017-03-08  4:25     ` Chen-Yu Tsai
2017-03-08  4:25     ` Chen-Yu Tsai
2017-03-08  8:55     ` Maxime Ripard
2017-03-08  8:55       ` Maxime Ripard
2017-03-08  8:55       ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 12/15] drm/sun4i: tcon: multiply the vtotal when not in interlace Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07 10:05   ` Chen-Yu Tsai
2017-03-07 10:05     ` Chen-Yu Tsai
2017-03-07 10:05     ` Chen-Yu Tsai
2017-03-09 10:54     ` Maxime Ripard
2017-03-09 10:54       ` Maxime Ripard
2017-03-09 10:54       ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 13/15] drm/sun4i: Add HDMI support Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-04-21 15:17   ` [linux-sunxi] " Chen-Yu Tsai
2017-04-21 15:17     ` Chen-Yu Tsai
2017-04-21 15:17     ` Chen-Yu Tsai
2017-04-26  6:50     ` [linux-sunxi] " Maxime Ripard
2017-04-26  6:50       ` Maxime Ripard
2017-04-26  6:50       ` Maxime Ripard
2017-04-26  7:59       ` Chen-Yu Tsai
2017-04-26  7:59         ` Chen-Yu Tsai
2017-04-26  7:59         ` Chen-Yu Tsai
2017-05-03  8:41         ` [linux-sunxi] " Maxime Ripard
2017-05-03  8:41           ` Maxime Ripard
2017-05-03  8:41           ` Maxime Ripard
2017-03-07  8:56 ` [PATCH 14/15] ARM: sun5i: a10s: Add the HDMI controller node Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-08  3:35   ` [linux-sunxi] " Chen-Yu Tsai
2017-03-08  3:35     ` Chen-Yu Tsai
2017-03-08  3:35     ` Chen-Yu Tsai
2017-03-09 10:59     ` [linux-sunxi] " Maxime Ripard
2017-03-09 10:59       ` Maxime Ripard
2017-03-09 10:59       ` Maxime Ripard
2017-03-09 11:10       ` [linux-sunxi] " Chen-Yu Tsai
2017-03-09 11:10         ` Chen-Yu Tsai
2017-03-09 11:10         ` Chen-Yu Tsai
2017-03-07  8:56 ` [PATCH 15/15] ARM: sun5i: a10s-olinuxino: Enable HDMI Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-07  8:56   ` Maxime Ripard
2017-03-08  3:36   ` Chen-Yu Tsai
2017-03-08  3:36     ` Chen-Yu Tsai
2017-03-08  3:36     ` Chen-Yu Tsai
2017-03-07 14:06 ` [PATCH 0/15] drm: sun4i: Add support for the HDMI controller Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06becb54f965288aba6df203a369b524d4786a11.1488876832.git-series.maxime.ripard@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.