From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH] xfs_db: set b_ops to NULL in set_cur for types without verifiers
Date: Thu, 27 Aug 2020 11:53:33 -0500 [thread overview]
Message-ID: <06cdcef6-2f44-c702-198b-4ae53052ec28@redhat.com> (raw)
If we are using set_cur() to set a type that has no verifier ops,
be sure to set b_ops to NULL so that the old verifiers don't run
against the buffer anymore, which may have changed size.
Fixes: cdabe556 ("xfs_db: consolidate set_iocur_type behavior")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/db/io.c b/db/io.c
index 9309f361..c79cf105 100644
--- a/db/io.c
+++ b/db/io.c
@@ -561,8 +561,10 @@ set_cur(
return;
iocur_top->buf = bp->b_addr;
iocur_top->bp = bp;
- if (!ops)
+ if (!ops) {
+ bp->b_ops = NULL;
bp->b_flags |= LIBXFS_B_UNCHECKED;
+ }
iocur_top->bb = blknum;
iocur_top->blen = len;
next reply other threads:[~2020-08-27 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 16:53 Eric Sandeen [this message]
2020-08-27 17:22 ` [PATCH] xfs_db: set b_ops to NULL in set_cur for types without verifiers Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06cdcef6-2f44-c702-198b-4ae53052ec28@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.