All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geliang Tang <geliangtang@163.com>
To: Sekhar Nori <nsekhar@ti.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Russell King <linux@arm.linux.org.uk>
Cc: Geliang Tang <geliangtang@163.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 6/7] ARM: davinci: fix a problematic usage of WARN()
Date: Wed, 25 Nov 2015 21:12:19 +0800	[thread overview]
Message-ID: <06d69890c56bd84a831a1dccee26e34b4988a241.1448456395.git.geliangtang@163.com> (raw)
In-Reply-To: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com>
In-Reply-To: <e20618e9dd688161c7a539bc041b7951efeac351.1448456395.git.geliangtang@163.com>

WARN() takes a condition and a format string. The condition was
omitted. So I added it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 arch/arm/mach-davinci/board-dm355-evm.c     | 2 +-
 arch/arm/mach-davinci/board-dm355-leopard.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
index c71dd99..e47f24c 100644
--- a/arch/arm/mach-davinci/board-dm355-evm.c
+++ b/arch/arm/mach-davinci/board-dm355-evm.c
@@ -385,7 +385,7 @@ static __init void dm355_evm_init(void)
 
 	aemif = clk_get(&dm355evm_dm9000.dev, "aemif");
 	if (IS_ERR(aemif))
-		WARN("%s: unable to get AEMIF clock\n", __func__);
+		WARN(1, "%s: unable to get AEMIF clock\n", __func__);
 	else
 		clk_prepare_enable(aemif);
 
diff --git a/arch/arm/mach-davinci/board-dm355-leopard.c b/arch/arm/mach-davinci/board-dm355-leopard.c
index 680a7a2..83b625c 100644
--- a/arch/arm/mach-davinci/board-dm355-leopard.c
+++ b/arch/arm/mach-davinci/board-dm355-leopard.c
@@ -243,7 +243,7 @@ static __init void dm355_leopard_init(void)
 
 	aemif = clk_get(&dm355leopard_dm9000.dev, "aemif");
 	if (IS_ERR(aemif))
-		WARN("%s: unable to get AEMIF clock\n", __func__);
+		WARN(1, "%s: unable to get AEMIF clock\n", __func__);
 	else
 		clk_prepare_enable(aemif);
 
-- 
2.5.0



WARNING: multiple messages have this Message-ID (diff)
From: geliangtang@163.com (Geliang Tang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] ARM: davinci: fix a problematic usage of WARN()
Date: Wed, 25 Nov 2015 21:12:19 +0800	[thread overview]
Message-ID: <06d69890c56bd84a831a1dccee26e34b4988a241.1448456395.git.geliangtang@163.com> (raw)
In-Reply-To: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com>

WARN() takes a condition and a format string. The condition was
omitted. So I added it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 arch/arm/mach-davinci/board-dm355-evm.c     | 2 +-
 arch/arm/mach-davinci/board-dm355-leopard.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
index c71dd99..e47f24c 100644
--- a/arch/arm/mach-davinci/board-dm355-evm.c
+++ b/arch/arm/mach-davinci/board-dm355-evm.c
@@ -385,7 +385,7 @@ static __init void dm355_evm_init(void)
 
 	aemif = clk_get(&dm355evm_dm9000.dev, "aemif");
 	if (IS_ERR(aemif))
-		WARN("%s: unable to get AEMIF clock\n", __func__);
+		WARN(1, "%s: unable to get AEMIF clock\n", __func__);
 	else
 		clk_prepare_enable(aemif);
 
diff --git a/arch/arm/mach-davinci/board-dm355-leopard.c b/arch/arm/mach-davinci/board-dm355-leopard.c
index 680a7a2..83b625c 100644
--- a/arch/arm/mach-davinci/board-dm355-leopard.c
+++ b/arch/arm/mach-davinci/board-dm355-leopard.c
@@ -243,7 +243,7 @@ static __init void dm355_leopard_init(void)
 
 	aemif = clk_get(&dm355leopard_dm9000.dev, "aemif");
 	if (IS_ERR(aemif))
-		WARN("%s: unable to get AEMIF clock\n", __func__);
+		WARN(1, "%s: unable to get AEMIF clock\n", __func__);
 	else
 		clk_prepare_enable(aemif);
 
-- 
2.5.0

  reply	other threads:[~2015-11-25 13:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 13:12 [PATCH 1/7] drm/msm/mdp: fix a problematic usage of WARN_ON() Geliang Tang
2015-11-25 13:12 ` [PATCH 2/7] drm/vmwgfx: " Geliang Tang
2015-11-25 13:12   ` [PATCH 3/7] iio: " Geliang Tang
2015-11-25 13:12     ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Geliang Tang
2015-11-25 13:12       ` Geliang Tang
2015-11-25 13:12       ` [PATCH 5/7] vfio: fix a problematic usage of WARN() Geliang Tang
2015-11-25 13:12         ` Geliang Tang [this message]
2015-11-25 13:12           ` [PATCH 6/7] ARM: davinci: " Geliang Tang
2015-11-25 13:12           ` [PATCH 7/7] powerpc: " Geliang Tang
2015-11-26  5:25             ` Michael Ellerman
2015-11-25 13:39           ` [PATCH 6/7] ARM: davinci: " Arnd Bergmann
2015-11-25 13:39             ` Arnd Bergmann
2015-11-25 14:13             ` [PATCH v2] " Geliang Tang
2015-11-25 14:13               ` Geliang Tang
2015-11-25 20:21               ` kbuild test robot
2015-11-25 20:21                 ` kbuild test robot
2015-11-25 20:28                 ` Arnd Bergmann
2015-11-25 20:28                   ` Arnd Bergmann
2015-11-26  0:35                   ` [PATCH v3] " Geliang Tang
2015-11-26  0:35                     ` Geliang Tang
2015-12-15  9:58                     ` Sekhar Nori
2015-12-15  9:58                       ` Sekhar Nori
2015-11-25 13:35         ` [PATCH 5/7] vfio: " Alex Williamson
2015-11-25 13:47       ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Grumbach, Emmanuel
2015-11-25 13:14     ` [PATCH 3/7] iio: fix a problematic usage of WARN_ON() Lars-Peter Clausen
2015-11-25 15:50   ` [PATCH 2/7] drm/vmwgfx: " Sinclair Yeh
2015-11-26 14:51   ` Thomas Hellstrom
2015-11-26 14:51     ` Thomas Hellstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06d69890c56bd84a831a1dccee26e34b4988a241.1448456395.git.geliangtang@163.com \
    --to=geliangtang@163.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.