All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v2 39/39] drm/bridge: remove ->get_edid callback
Date: Wed,  3 Jan 2024 12:08:53 +0200	[thread overview]
Message-ID: <09308b5024b0fd54ce6516fc229390421bf88b64.1704276309.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1704276309.git.jani.nikula@intel.com>

There are no more users of the ->get_edid callback left. They've all
been converted to ->edid_read. Remove the callback, and the fallback in
drm_bridge_edid_read().

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/drm_bridge.c | 19 -------------------
 include/drm/drm_bridge.h     | 30 ------------------------------
 2 files changed, 49 deletions(-)

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index a3065d4aa3d6..521a71c61b16 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -1216,9 +1216,6 @@ EXPORT_SYMBOL_GPL(drm_bridge_get_modes);
  * DRM_BRIDGE_OP_EDID bridge ops flag, call &drm_bridge_funcs.edid_read to get
  * the EDID and return it. Otherwise return NULL.
  *
- * If &drm_bridge_funcs.edid_read is not set, fall back to using
- * &drm_bridge_funcs.get_edid and wrapping it in struct drm_edid.
- *
  * RETURNS:
  * The retrieved EDID on success, or NULL otherwise.
  */
@@ -1228,22 +1225,6 @@ const struct drm_edid *drm_bridge_edid_read(struct drm_bridge *bridge,
 	if (!(bridge->ops & DRM_BRIDGE_OP_EDID))
 		return NULL;
 
-	/* Transitional: Fall back to ->get_edid. */
-	if (!bridge->funcs->edid_read) {
-		const struct drm_edid *drm_edid;
-		struct edid *edid;
-
-		edid = bridge->funcs->get_edid(bridge, connector);
-		if (!edid)
-			return NULL;
-
-		drm_edid = drm_edid_alloc(edid, (edid->extensions + 1) * EDID_LENGTH);
-
-		kfree(edid);
-
-		return drm_edid;
-	}
-
 	return bridge->funcs->edid_read(bridge, connector);
 }
 EXPORT_SYMBOL_GPL(drm_bridge_edid_read);
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index ee12f829aaf7..7293c02e17c5 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -588,36 +588,6 @@ struct drm_bridge_funcs {
 	const struct drm_edid *(*edid_read)(struct drm_bridge *bridge,
 					    struct drm_connector *connector);
 
-	/**
-	 * @get_edid:
-	 *
-	 * Read and parse the EDID data of the connected display.
-	 *
-	 * The @get_edid callback is the preferred way of reporting mode
-	 * information for a display connected to the bridge output. Bridges
-	 * that support reading EDID shall implement this callback and leave
-	 * the @get_modes callback unimplemented.
-	 *
-	 * The caller of this operation shall first verify the output
-	 * connection status and refrain from reading EDID from a disconnected
-	 * output.
-	 *
-	 * This callback is optional. Bridges that implement it shall set the
-	 * DRM_BRIDGE_OP_EDID flag in their &drm_bridge->ops.
-	 *
-	 * The connector parameter shall be used for the sole purpose of EDID
-	 * retrieval and parsing, and shall not be stored internally by bridge
-	 * drivers for future usage.
-	 *
-	 * RETURNS:
-	 *
-	 * An edid structure newly allocated with kmalloc() (or similar) on
-	 * success, or NULL otherwise. The caller is responsible for freeing
-	 * the returned edid structure with kfree().
-	 */
-	struct edid *(*get_edid)(struct drm_bridge *bridge,
-				 struct drm_connector *connector);
-
 	/**
 	 * @hpd_notify:
 	 *
-- 
2.39.2


  parent reply	other threads:[~2024-01-03 10:13 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03 10:08 [PATCH v2 00/39] drm/bridge: switch to struct drm_edid Jani Nikula
2024-01-03 10:08 ` [PATCH v2 01/39] drm/bridge: add ->edid_read hook and drm_bridge_edid_read() Jani Nikula
2024-01-03 10:08 ` [PATCH v2 02/39] drm/bridge: switch to drm_bridge_read_edid() Jani Nikula
2024-01-03 10:33   ` Thomas Zimmermann
2024-01-03 10:57     ` Jani Nikula
2024-01-03 10:08 ` [PATCH v2 03/39] drm/bridge: chrontel-ch7033: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 04/39] drm/bridge: lt8912b: use drm_bridge_read_edid() Jani Nikula
2024-01-03 10:08 ` [PATCH v2 05/39] drm/bridge: lt8912b: clear the EDID property on failures Jani Nikula
2024-01-03 10:08 ` [PATCH v2 06/39] drm/bridge: lt8912b: use ->edid_read callback Jani Nikula
2024-01-03 10:08 ` [PATCH v2 07/39] drm/bridge: lt9611uxc: use drm_bridge_read_edid() Jani Nikula
2024-01-03 10:08 ` [PATCH v2 08/39] drm: bridge: simple-bridge: use drm_bridge_edid_read() Jani Nikula
2024-01-03 10:08 ` [PATCH v2 09/39] drm: bridge: simple-bridge: clear the EDID property on failures Jani Nikula
2024-01-03 10:08 ` [PATCH v2 10/39] drm/bridge: tfp410: use drm_bridge_edid_read() Jani Nikula
2024-01-03 10:08 ` [PATCH v2 11/39] drm/bridge: tfp410: clear the EDID property on failures Jani Nikula
2024-01-03 10:08 ` [PATCH v2 12/39] drm/meson: switch to drm_bridge_edid_read() Jani Nikula
2024-01-03 10:08 ` [PATCH v2 13/39] drm/bridge: remove drm_bridge_get_edid() in favour of drm_bridge_edid_read() Jani Nikula
2024-01-03 10:08 ` [PATCH v2 14/39] drm/bridge: anx7625: switch to ->edid_read callback Jani Nikula
2024-01-03 10:08 ` [PATCH v2 15/39] drm/bridge: cdns-mhdp8546: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 16/39] drm/bridge: cdns-mhdp8546: clear the EDID property on failures Jani Nikula
2024-01-03 10:08 ` [PATCH v2 17/39] drm/bridge: display-connector: switch to ->edid_read callback Jani Nikula
2024-01-03 10:08 ` [PATCH v2 18/39] drm/bridge: it6505: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 19/39] drm: bridge: it66121: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 20/39] drm/bridge: lt9611: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 21/39] drm/bridge: lt9611uxc: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 22/39] drm/bridge: megachips: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 23/39] drm/bridge: nxp-ptn3460: " Jani Nikula
2024-01-03 20:20   ` kernel test robot
2024-01-03 20:20     ` kernel test robot
2024-01-04 12:17     ` Jani Nikula
2024-01-09 10:14   ` [PATCH v2] " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 24/39] drm/bridge: sii902x: use display info is_hdmi Jani Nikula
2024-01-03 10:08 ` [PATCH v2 25/39] drm/bridge: sii902x: switch to ->edid_read callback Jani Nikula
2024-01-03 10:08 ` [PATCH v2 26/39] drm/mediatek/dp: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 27/39] drm/mediatek/hdmi: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 28/39] drm/msm/hdmi: fix indent Jani Nikula
2024-01-03 10:08 ` [PATCH v2 29/39] drm/msm/hdmi: switch to ->edid_read callback Jani Nikula
2024-01-03 10:08 ` [PATCH v2 30/39] drm/omap/hdmi4: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 31/39] drm/omap/hdmi5: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 32/39] drm: xlnx: zynqmp_dpsub: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 33/39] drm: adv7511: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 34/39] drm: bridge: dw_hdmi: " Jani Nikula
2024-01-04  5:44   ` kernel test robot
2024-01-04  5:44     ` kernel test robot
2024-01-04 12:21     ` Jani Nikula
2024-01-09 10:11   ` [PATCH v2] drm/bridge: nxp-ptn3460: " Jani Nikula
2024-01-09 10:16     ` Jani Nikula
2024-01-09 10:13   ` [PATCH v2] drm: bridge: dw_hdmi: " Jani Nikula
2024-01-03 10:08 ` [PATCH v2 35/39] drm: bridge: dw_hdmi: clear the EDID property and CEC address on failures Jani Nikula
2024-01-03 10:08 ` [PATCH v2 36/39] drm/bridge: tc358767: update the EDID property Jani Nikula
2024-01-03 10:08 ` [PATCH v2 37/39] drm/bridge: tc358767: switch to ->edid_read callback Jani Nikula
2024-01-03 10:08 ` [PATCH v2 38/39] drm/bridge: ti-sn65dsi86: " Jani Nikula
2024-01-03 10:08 ` Jani Nikula [this message]
2024-01-03 10:11 ` [PATCH v2 00/39] drm/bridge: switch to struct drm_edid Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09308b5024b0fd54ce6516fc229390421bf88b64.1704276309.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.