From: "Chauhan, Vijay" <Vijay.Chauhan@lsi.com>
To: "'dm-devel@redhat.com'" <dm-devel@redhat.com>
Subject: [PATCH]multipath-tools: no_path_retry for time based queuing is queuing I/O for ever
Date: Tue, 28 Jul 2009 18:21:13 +0530 [thread overview]
Message-ID: <0D1E8821739E724A86F4D16902CE275C141A357072@inbmail01.lsi.com> (raw)
Even though no_path_retry is set for time based queuing(i.e no_path_retry <N>), I/O is getting queued for ever. During all path failure condition, setup_feature() resets no_path_retry of multipath structure to NO_PATH_RETRY_QUEUE which queues I/O for ever. This patch skips resetting no_path_retry until no_path_retry is set with queue.
Signed-off-by: Vijay Chauhan <vijay.chauhan@lsi.com>
---
diff -uprN multipath-tools-orig/libmultipath/dmparser.c multipath-tools/libmultipath/dmparser.c
--- multipath-tools-orig/libmultipath/dmparser.c 2009-07-28 10:06:46.000000000 +0530
+++ multipath-tools/libmultipath/dmparser.c 2009-07-28 10:18:38.000000000 +0530
@@ -145,7 +145,10 @@ disassemble_map (vector pathvec, char *
FREE(word);
return 1;
}
- setup_feature(mpp, word);
+ if ((mpp->no_path_retry == NO_PATH_RETRY_UNDEF) ||
+ (mpp->no_path_retry == NO_PATH_RETRY_FAIL) ||
+ (mpp->no_path_retry == NO_PATH_RETRY_QUEUE))
+ setup_feature(mpp, word);
FREE(word);
}
--
reply other threads:[~2009-07-28 12:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0D1E8821739E724A86F4D16902CE275C141A357072@inbmail01.lsi.com \
--to=vijay.chauhan@lsi.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.