All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaro Koskinen <Aaro.Koskinen@nokia.com>
To: linux-omap@vger.kernel.org
Subject: [PATCH PM 2/2] OMAP McSPI: spin_unlock_irq() missing
Date: Thu,  5 Feb 2009 13:07:09 +0200	[thread overview]
Message-ID: <1233832029-21614-2-git-send-email-Aaro.Koskinen@nokia.com> (raw)
In-Reply-To: <1233832029-21614-1-git-send-email-Aaro.Koskinen@nokia.com>

spin_unlock_irq() not called on failure path

Signed-off-by: Aaro Koskinen <Aaro.Koskinen@nokia.com>
---
 drivers/spi/omap2_mcspi.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index 4d09777..56e91a4 100644
--- a/drivers/spi/omap2_mcspi.c
+++ b/drivers/spi/omap2_mcspi.c
@@ -751,7 +751,7 @@ static void omap2_mcspi_work(struct work_struct *work)
 	spin_lock_irq(&mcspi->lock);
 
 	if (omap2_mcspi_enable_clocks(mcspi))
-		return;
+		goto out;
 
 	/* We only enable one channel at a time -- the one whose message is
 	 * at the head of the queue -- although this controller would gladly
@@ -855,6 +855,7 @@ static void omap2_mcspi_work(struct work_struct *work)
 
 	omap2_mcspi_disable_clocks(mcspi);
 
+out:
 	spin_unlock_irq(&mcspi->lock);
 }
 
-- 
1.5.4.3


  reply	other threads:[~2009-02-05 11:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 11:05 [PATCH PM 0/2] OMAP McSPI: Fixes to save/restore Aaro Koskinen
2009-02-05 11:07 ` [PATCH PM 1/2] OMAP McSPI: Fix context save/restore Aaro Koskinen
2009-02-05 11:07   ` Aaro Koskinen [this message]
2009-02-05 11:51   ` Hemanth V
2009-02-05 14:29     ` Kevin Hilman
2009-02-05 14:39       ` Hemanth V
2009-02-05 14:50         ` Högander Jouni
2009-02-05 14:52         ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233832029-21614-2-git-send-email-Aaro.Koskinen@nokia.com \
    --to=aaro.koskinen@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.