All of lore.kernel.org
 help / color / mirror / Atom feed
From: ext-eero.nurkkala@nokia.com
To: linux-omap@vger.kernel.org
Cc: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
Subject: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY
Date: Thu,  5 Mar 2009 08:27:35 +0200	[thread overview]
Message-ID: <12362344552581-git-send-email-ext-eero.nurkkala@nokia.com> (raw)

From: Eero Nurkkala <ext-eero.nurkkala@nokia.com>

It is the bit 8 that is for FCLK. All other blocks in
OMAPs use the bit 8 for denying FCLK idling.

This is an RFC, I'd like some discussion. Somebody
double-check this?

Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
---
 drivers/i2c/busses/i2c-omap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 0258b55..11057eb 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -157,7 +157,7 @@
 #define SYSC_AUTOIDLE_MASK		(1 << 0)
 
 #define SYSC_IDLEMODE_SMART		0x2
-#define SYSC_CLOCKACTIVITY_FCLK		0x2
+#define SYSC_CLOCKACTIVITY_FCLK		0x1
 
 
 struct omap_i2c_dev {
-- 
1.5.2


             reply	other threads:[~2009-03-05  6:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-05  6:27 ext-eero.nurkkala [this message]
2009-03-05  8:42 ` [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY Paul Walmsley
2009-03-05  8:46   ` Eero Nurkkala
2009-03-05  8:54     ` Eero Nurkkala
2009-03-11  3:55       ` Woodruff, Richard
2009-03-11  5:51         ` Eero Nurkkala
2009-03-05 12:29     ` Menon, Nishanth
2009-03-05 12:32       ` Eero Nurkkala
2009-03-05 12:54         ` Menon, Nishanth
2009-03-06 13:41           ` Eero Nurkkala
2009-03-06 13:51             ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12362344552581-git-send-email-ext-eero.nurkkala@nokia.com \
    --to=ext-eero.nurkkala@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.