All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [PATCH] Warn if a qcow (not qcow2) file is opened
Date: Mon, 29 Jun 2009 17:04:49 +0300	[thread overview]
Message-ID: <1246284289-25394-1-git-send-email-avi@redhat.com> (raw)

The qcow block driver format is no longer maintained and likely contains
serious data corruptors.  Urge users to stay away for it, and advertise
the new and improved replacement.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 block/qcow.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/block/qcow.c b/block/qcow.c
index 55a68a6..2aef6a6 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -101,6 +101,11 @@ static int qcow_open(BlockDriverState *bs, const char *filename, int flags)
         return ret;
     if (bdrv_pread(s->hd, 0, &header, sizeof(header)) != sizeof(header))
         goto fail;
+
+    fprintf(stderr,
+            "WARNING: the qcow file format is no longer supported.\n"
+            "         Please convert your images to qcow2.\n");
+
     be32_to_cpus(&header.magic);
     be32_to_cpus(&header.version);
     be64_to_cpus(&header.backing_file_offset);
-- 
1.6.0.6


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened
Date: Mon, 29 Jun 2009 17:04:49 +0300	[thread overview]
Message-ID: <1246284289-25394-1-git-send-email-avi@redhat.com> (raw)

The qcow block driver format is no longer maintained and likely contains
serious data corruptors.  Urge users to stay away for it, and advertise
the new and improved replacement.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 block/qcow.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/block/qcow.c b/block/qcow.c
index 55a68a6..2aef6a6 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -101,6 +101,11 @@ static int qcow_open(BlockDriverState *bs, const char *filename, int flags)
         return ret;
     if (bdrv_pread(s->hd, 0, &header, sizeof(header)) != sizeof(header))
         goto fail;
+
+    fprintf(stderr,
+            "WARNING: the qcow file format is no longer supported.\n"
+            "         Please convert your images to qcow2.\n");
+
     be32_to_cpus(&header.magic);
     be32_to_cpus(&header.version);
     be64_to_cpus(&header.backing_file_offset);
-- 
1.6.0.6

             reply	other threads:[~2009-06-29 14:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-29 14:04 Avi Kivity [this message]
2009-06-29 14:04 ` [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened Avi Kivity
2009-06-30  8:34 ` Kevin Wolf
2009-06-30 13:32   ` Anthony Liguori
2009-06-30 13:32     ` Anthony Liguori
2009-06-30 13:53     ` Kevin Wolf
2009-06-30 13:57     ` Avi Kivity
2009-06-30 13:57       ` [Qemu-devel] " Avi Kivity
2009-06-30 14:21       ` Paul Brook
2009-06-30 14:21         ` Paul Brook
2009-06-30 14:40         ` Daniel P. Berrange
2009-06-30 14:40           ` Daniel P. Berrange
2009-06-30 16:42         ` Anthony Liguori
2009-06-30 16:42           ` [Qemu-devel] " Anthony Liguori
2009-07-01 17:14     ` Andreas Färber
2009-07-02  7:22       ` Kevin Wolf
2009-07-02  7:22         ` Kevin Wolf
2009-06-30 12:05 ` Amit Shah
2009-06-30 12:05   ` [Qemu-devel] " Amit Shah
2009-06-30 12:53   ` Kevin Wolf
2009-06-30 12:53     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246284289-25394-1-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.