All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@amd.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org, Andre Przywara <andre.przywara@amd.com>
Subject: [PATCH] qemu-kvm: remove "KVM misreports CPUID" hack
Date: Fri, 3 Jul 2009 14:23:59 +0200	[thread overview]
Message-ID: <1246623839-24572-1-git-send-email-andre.przywara@amd.com> (raw)

This should be no longer necessary.
Effectively reverts 143eb2bd043e82bcf353cf82d33c127f06411d82.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>
---
 kvm/libkvm/libkvm-x86.c |    9 ---------
 qemu-kvm-x86.c          |    9 ---------
 2 files changed, 0 insertions(+), 18 deletions(-)

Hi Avi,

I am not sure what caused your problem back in May when you committed this,
but it seems to work without this now. I booted Win7RC 64bit and WinXP 64bit
and saw no problems.

Regards,
Andre.

diff --git a/kvm/libkvm/libkvm-x86.c b/kvm/libkvm/libkvm-x86.c
index 9ca77d5..67f41b4 100644
--- a/kvm/libkvm/libkvm-x86.c
+++ b/kvm/libkvm/libkvm-x86.c
@@ -639,15 +639,6 @@ uint32_t kvm_get_supported_cpuid(kvm_context_t kvm, uint32_t function, int reg)
 				break;
 			case R_EDX:
 				ret = cpuid->entries[i].edx;
-                                if (function == 1) {
-                                    /* kvm misreports the following features
-                                     */
-                                    ret |= 1 << 12; /* MTRR */
-                                    ret |= 1 << 16; /* PAT */
-                                    ret |= 1 << 7;  /* MCE */
-                                    ret |= 1 << 14; /* MCA */
-                                }
-
 				/* On Intel, kvm returns cpuid according to
 				 * the Intel spec, so add missing bits
 				 * according to the AMD spec:
diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c
index 7505380..2811665 100644
--- a/qemu-kvm-x86.c
+++ b/qemu-kvm-x86.c
@@ -649,15 +649,6 @@ uint32_t kvm_get_supported_cpuid(kvm_context_t kvm, uint32_t function, int reg)
 				break;
 			case R_EDX:
 				ret = cpuid->entries[i].edx;
-                                if (function == 1) {
-                                    /* kvm misreports the following features
-                                     */
-                                    ret |= 1 << 12; /* MTRR */
-                                    ret |= 1 << 16; /* PAT */
-                                    ret |= 1 << 7;  /* MCE */
-                                    ret |= 1 << 14; /* MCA */
-                                }
-
 				/* On Intel, kvm returns cpuid according to
 				 * the Intel spec, so add missing bits
 				 * according to the AMD spec:
-- 
1.6.1.3



             reply	other threads:[~2009-07-03 12:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-03 12:23 Andre Przywara [this message]
2009-07-04 15:21 ` [PATCH] qemu-kvm: remove "KVM misreports CPUID" hack Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246623839-24572-1-git-send-email-andre.przywara@amd.com \
    --to=andre.przywara@amd.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.