All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Valentin <eduardo.valentin@nokia.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Linux-OMAP <linux-omap@vger.kernel.org>,
	ALSA-Devel <alsa-devel@vger.kernel.org>,
	Jarkko Nikula <jhnikula@gmail.com>,
	"Nurkkala Eero.An (EXT-Offcode/Oulu)"
	<ext-Eero.Nurkkala@nokia.com>,
	"Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Eero Nurkkala <ext-eero.nurkkala@nokia.com>,
	Eduardo Valentin <eduardo.valentin@nokia.com>
Subject: [PATCHv4 11/20] OMAP: McBSP: Retain McBSP FCLK clockactivity
Date: Mon, 17 Aug 2009 14:51:10 +0300	[thread overview]
Message-ID: <1250509879-6703-12-git-send-email-eduardo.valentin@nokia.com> (raw)
In-Reply-To: <1250509879-6703-1-git-send-email-eduardo.valentin@nokia.com>

From: Eero Nurkkala <ext-eero.nurkkala@nokia.com>

FCLK may get autogated so that it prevents the McBSP
to work properly. It is the bit 9 that must be set
for maintaining the McBSP FCLK.

Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>
---
 arch/arm/plat-omap/include/mach/mcbsp.h |    1 +
 arch/arm/plat-omap/mcbsp.c              |    6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/arm/plat-omap/include/mach/mcbsp.h b/arch/arm/plat-omap/include/mach/mcbsp.h
index fe10ae8..70e950e 100644
--- a/arch/arm/plat-omap/include/mach/mcbsp.h
+++ b/arch/arm/plat-omap/include/mach/mcbsp.h
@@ -254,6 +254,7 @@
 #define RDISABLE		0x0001
 
 /********************** McBSP SYSCONFIG bit definitions ********************/
+#define CLOCKACTIVITY(value)	((value)<<8)
 #define SIDLEMODE(value)	((value)<<3)
 #define ENAWAKEUP		0x0004
 #define SOFTRST			0x0002
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index 86bfad8..2c274e6 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -316,8 +316,8 @@ static inline void omap34xx_mcbsp_request(struct omap_mcbsp *mcbsp)
 		u16 syscon;
 
 		syscon = OMAP_MCBSP_READ(mcbsp->io_base, SYSCON);
-		syscon &= ~(ENAWAKEUP | SIDLEMODE(0x03));
-		syscon |= (ENAWAKEUP | SIDLEMODE(0x02));
+		syscon &= ~(ENAWAKEUP | SIDLEMODE(0x03) | CLOCKACTIVITY(0x03));
+		syscon |= (ENAWAKEUP | SIDLEMODE(0x02) | CLOCKACTIVITY(0x02));
 		OMAP_MCBSP_WRITE(mcbsp->io_base, SYSCON, syscon);
 
 		OMAP_MCBSP_WRITE(mcbsp->io_base, WAKEUPEN, XRDYEN | RRDYEN);
@@ -333,7 +333,7 @@ static inline void omap34xx_mcbsp_free(struct omap_mcbsp *mcbsp)
 		u16 syscon;
 
 		syscon = OMAP_MCBSP_READ(mcbsp->io_base, SYSCON);
-		syscon &= ~(ENAWAKEUP | SIDLEMODE(0x03));
+		syscon &= ~(ENAWAKEUP | SIDLEMODE(0x03) | CLOCKACTIVITY(0x03));
 		OMAP_MCBSP_WRITE(mcbsp->io_base, SYSCON, syscon);
 
 		OMAP_MCBSP_WRITE(mcbsp->io_base, WAKEUPEN, 0);
-- 
1.6.2.GIT


  parent reply	other threads:[~2009-08-17 12:05 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 11:50 [PATCHv4 00/20] OMAP ASoC changes in DMA utilization Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 01/20] OMAP: McBSP: Provide functions for ASoC frame syncronization Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 02/20] OMAP: McBSP: Add IRQEN, IRQSTATUS, THRESHOLD2 and THRESHOLD1 registers Eduardo Valentin
2009-08-17 13:53   ` Tony Lindgren
2009-08-17 13:53   ` Tony Lindgren
2009-08-17 14:13     ` Eduardo Valentin
2009-08-17 14:13     ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 03/20] OMAP: McBSP: Use appropriate value for startup delay Eduardo Valentin
2009-08-17 13:56   ` Tony Lindgren
2009-08-17 14:09     ` [PATCHv5 " Eduardo Valentin
2009-08-17 13:56   ` [PATCHv4 " Tony Lindgren
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 04/20] OMAP: McBSP: Add transmit/receive threshold handler Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 05/20] OMAP: McBSP: Create and export max_(r|t)x_thres property Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 06/20] OMAP3: McBSP: Lower the maximum buffersize for McBSP1,3,4,5 Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 06/20] OMAP3: McBSP: Lower the maximum buffersize for McBSP1, 3, 4, 5 Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 07/20] OMAP: McBSP: Rename thres sysfs symbols Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 08/20] OMAP: McBSP: Add link DMA mode selection Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 09/20] OMAP: McBSP: Wakeups utilized Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 10/20] OMAP: McBSP: Change wakeup signals Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin [this message]
2009-08-17 11:51 ` [PATCHv4 11/20] OMAP: McBSP: Retain McBSP FCLK clockactivity Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 12/20] OMAP: McBSP: Configure NO IDLE mode for DMA mode different of threshold Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 13/20] OMAP: McBSP: Do not enable wakeups for no-idle mode Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 14/20] OMAP: McBSP: Let element DMA mode hit retention also Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 15/20] ASoC: OMAP: Make DMA 64 aligned Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 14:00   ` Tony Lindgren
2009-08-17 14:35     ` Eduardo Valentin
2009-08-17 14:00   ` Tony Lindgren
2009-08-17 11:51 ` [PATCHv4 16/20] ASoC: OMAP: Enable DMA burst mode Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 13:25   ` Jarkko Nikula
2009-08-17 14:01     ` Tony Lindgren
2009-08-17 14:01     ` Tony Lindgren
2009-08-17 14:29       ` [PATCH] " Eduardo Valentin
2009-08-17 14:39       ` [PATCHv4 16/20] " Eduardo Valentin
2009-08-17 14:39       ` Eduardo Valentin
2009-08-17 13:25   ` Jarkko Nikula
2009-08-17 11:51 ` [PATCHv4 17/20] ASoC: Add runtime check for RFIG and XFIG Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 18/20] ASoC: Always syncronize audio transfers on frames Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 19/20] ASoC: OMAP: Use McBSP threshold to playback and capture Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 20/20] ASoC: OMAP: Use DMA operating mode of McBSP Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 14:02   ` Tony Lindgren
2009-08-17 14:02   ` Tony Lindgren
2009-08-17 14:19     ` Eduardo Valentin
2009-08-17 14:19     ` Eduardo Valentin
2009-08-17 14:05 ` [PATCHv4 00/20] OMAP ASoC changes in DMA utilization Jarkko Nikula
2009-08-19  7:40   ` Eduardo Valentin
2009-08-19  7:48     ` Eduardo Valentin
2009-08-19  8:26       ` Mark Brown
2009-08-24 14:00         ` [alsa-devel] " Tony Lindgren
2009-08-19  7:48     ` Eduardo Valentin
2009-08-19  7:40   ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250509879-6703-12-git-send-email-eduardo.valentin@nokia.com \
    --to=eduardo.valentin@nokia.com \
    --cc=alsa-devel@vger.kernel.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=ext-Eero.Nurkkala@nokia.com \
    --cc=jhnikula@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.