All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Valentin <eduardo.valentin@nokia.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Linux-OMAP <linux-omap@vger.kernel.org>,
	ALSA-Devel <alsa-devel@vger.kernel.org>,
	Jarkko Nikula <jhnikula@gmail.com>,
	"Nurkkala Eero.An (EXT-Offcode/Oulu)"
	<ext-Eero.Nurkkala@nokia.com>,
	"Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Eero Nurkkala <ext-eero.nurkkala@nokia.com>
Subject: [PATCHv4 18/20] ASoC: Always syncronize audio transfers on frames
Date: Mon, 17 Aug 2009 14:51:17 +0300	[thread overview]
Message-ID: <1250509879-6703-19-git-send-email-eduardo.valentin@nokia.com> (raw)
In-Reply-To: <1250509879-6703-1-git-send-email-eduardo.valentin@nokia.com>

From: Eero Nurkkala <ext-eero.nurkkala@nokia.com>

All these steps are required for ASoC to behave correctly.
rccr and xccr are format dependent, for example TDM audio
has different values than I2S or DSP_A. Also the
omap_mcbsp_xmit_enable and/or omap_mcbsp_recv_enable must
be called right after the DMA has started.
This provides no longer L and R channels switching at random.

Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
---
 sound/soc/omap/omap-mcbsp.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index a7b0961..76c32f8 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -189,8 +189,12 @@ static int omap_mcbsp_dai_trigger(struct snd_pcm_substream *substream, int cmd,
 	case SNDRV_PCM_TRIGGER_START:
 	case SNDRV_PCM_TRIGGER_RESUME:
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
-		mcbsp_data->active++;
 		omap_mcbsp_start(mcbsp_data->bus_id, play, !play);
+		/* Make sure data transfer is frame synchronized */
+		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+			omap_mcbsp_xmit_enable(mcbsp_data->bus_id, 1);
+		else
+			omap_mcbsp_recv_enable(mcbsp_data->bus_id, 1);
 		break;
 
 	case SNDRV_PCM_TRIGGER_STOP:
@@ -336,11 +340,15 @@ static int omap_mcbsp_dai_set_dai_fmt(struct snd_soc_dai *cpu_dai,
 		/* 1-bit data delay */
 		regs->rcr2	|= RDATDLY(1);
 		regs->xcr2	|= XDATDLY(1);
+		regs->rccr	|= RFULL_CYCLE | RDMAEN | RDISABLE;
+		regs->xccr	|= (DXENDLY(1) | XDMAEN | XDISABLE);
 		break;
 	case SND_SOC_DAIFMT_DSP_A:
 		/* 1-bit data delay */
 		regs->rcr2      |= RDATDLY(1);
 		regs->xcr2      |= XDATDLY(1);
+		regs->rccr	|= RFULL_CYCLE | RDMAEN | RDISABLE;
+		regs->xccr	|= (DXENDLY(1) | XDMAEN | XDISABLE);
 		/* Invert FS polarity configuration */
 		temp_fmt ^= SND_SOC_DAIFMT_NB_IF;
 		break;
-- 
1.6.2.GIT


  parent reply	other threads:[~2009-08-17 12:05 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 11:50 [PATCHv4 00/20] OMAP ASoC changes in DMA utilization Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 01/20] OMAP: McBSP: Provide functions for ASoC frame syncronization Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 02/20] OMAP: McBSP: Add IRQEN, IRQSTATUS, THRESHOLD2 and THRESHOLD1 registers Eduardo Valentin
2009-08-17 13:53   ` Tony Lindgren
2009-08-17 13:53   ` Tony Lindgren
2009-08-17 14:13     ` Eduardo Valentin
2009-08-17 14:13     ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 03/20] OMAP: McBSP: Use appropriate value for startup delay Eduardo Valentin
2009-08-17 13:56   ` Tony Lindgren
2009-08-17 14:09     ` [PATCHv5 " Eduardo Valentin
2009-08-17 13:56   ` [PATCHv4 " Tony Lindgren
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 04/20] OMAP: McBSP: Add transmit/receive threshold handler Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 05/20] OMAP: McBSP: Create and export max_(r|t)x_thres property Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 06/20] OMAP3: McBSP: Lower the maximum buffersize for McBSP1,3,4,5 Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 06/20] OMAP3: McBSP: Lower the maximum buffersize for McBSP1, 3, 4, 5 Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 07/20] OMAP: McBSP: Rename thres sysfs symbols Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 08/20] OMAP: McBSP: Add link DMA mode selection Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 09/20] OMAP: McBSP: Wakeups utilized Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 10/20] OMAP: McBSP: Change wakeup signals Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 11/20] OMAP: McBSP: Retain McBSP FCLK clockactivity Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 12/20] OMAP: McBSP: Configure NO IDLE mode for DMA mode different of threshold Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 13/20] OMAP: McBSP: Do not enable wakeups for no-idle mode Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 14/20] OMAP: McBSP: Let element DMA mode hit retention also Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 15/20] ASoC: OMAP: Make DMA 64 aligned Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 14:00   ` Tony Lindgren
2009-08-17 14:35     ` Eduardo Valentin
2009-08-17 14:00   ` Tony Lindgren
2009-08-17 11:51 ` [PATCHv4 16/20] ASoC: OMAP: Enable DMA burst mode Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 13:25   ` Jarkko Nikula
2009-08-17 14:01     ` Tony Lindgren
2009-08-17 14:01     ` Tony Lindgren
2009-08-17 14:29       ` [PATCH] " Eduardo Valentin
2009-08-17 14:39       ` [PATCHv4 16/20] " Eduardo Valentin
2009-08-17 14:39       ` Eduardo Valentin
2009-08-17 13:25   ` Jarkko Nikula
2009-08-17 11:51 ` [PATCHv4 17/20] ASoC: Add runtime check for RFIG and XFIG Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin [this message]
2009-08-17 11:51 ` [PATCHv4 18/20] ASoC: Always syncronize audio transfers on frames Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 19/20] ASoC: OMAP: Use McBSP threshold to playback and capture Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 11:51 ` [PATCHv4 20/20] ASoC: OMAP: Use DMA operating mode of McBSP Eduardo Valentin
2009-08-17 11:51 ` Eduardo Valentin
2009-08-17 14:02   ` Tony Lindgren
2009-08-17 14:02   ` Tony Lindgren
2009-08-17 14:19     ` Eduardo Valentin
2009-08-17 14:19     ` Eduardo Valentin
2009-08-17 14:05 ` [PATCHv4 00/20] OMAP ASoC changes in DMA utilization Jarkko Nikula
2009-08-19  7:40   ` Eduardo Valentin
2009-08-19  7:48     ` Eduardo Valentin
2009-08-19  8:26       ` Mark Brown
2009-08-24 14:00         ` [alsa-devel] " Tony Lindgren
2009-08-19  7:48     ` Eduardo Valentin
2009-08-19  7:40   ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250509879-6703-19-git-send-email-eduardo.valentin@nokia.com \
    --to=eduardo.valentin@nokia.com \
    --cc=alsa-devel@vger.kernel.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=ext-Eero.Nurkkala@nokia.com \
    --cc=jhnikula@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.