All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-parisc@vger.kernel.org
Cc: Russell King <rmk@arm.linux.org.uk>,
	Christoph Hellwig <hch@lst.de>, Paul Mundt <lethal@linux-sh.org>,
	James Bottomley <jejb@external.hp.com>,
	James Bottomley <James.Bottomley@suse.de>
Subject: [PATCH 6/6] xfs: fix xfs to work with Virtually Indexed architectures
Date: Thu, 17 Sep 2009 18:07:01 -0500	[thread overview]
Message-ID: <1253228821-4700-7-git-send-email-James.Bottomley@suse.de> (raw)
In-Reply-To: <1253228821-4700-6-git-send-email-James.Bottomley@suse.de>

From: James Bottomley <jejb@external.hp.com>

xfs_buf.c includes what is essentially a hand rolled version of
blk_rq_map_kern().  In order to work properly with the vmalloc buffers
that xfs uses, this hand rolled routine must also implement the flushing
API for vmap/vmalloc areas.

Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---
 fs/xfs/linux-2.6/xfs_buf.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c
index 965df12..320a6e4 100644
--- a/fs/xfs/linux-2.6/xfs_buf.c
+++ b/fs/xfs/linux-2.6/xfs_buf.c
@@ -1132,12 +1132,26 @@ xfs_buf_bio_end_io(
 	xfs_buf_t		*bp = (xfs_buf_t *)bio->bi_private;
 	unsigned int		blocksize = bp->b_target->bt_bsize;
 	struct bio_vec		*bvec = bio->bi_io_vec + bio->bi_vcnt - 1;
+	void			*vaddr = NULL;
+	int			i;
 
 	xfs_buf_ioerror(bp, -error);
 
+	if (is_vmalloc_addr(bp->b_addr))
+		for (i = 0; i < bp->b_page_count; i++)
+			if (bvec->bv_page == bp->b_pages[i]) {
+				vaddr = bp->b_addr + i*PAGE_SIZE;
+				break;
+			}
+
 	do {
 		struct page	*page = bvec->bv_page;
 
+		if (is_vmalloc_addr(bp->b_addr)) {
+			invalidate_kernel_dcache_addr(vaddr);
+			vaddr -= PAGE_SIZE;
+		}
+
 		ASSERT(!PagePrivate(page));
 		if (unlikely(bp->b_error)) {
 			if (bp->b_flags & XBF_READ)
@@ -1202,6 +1216,9 @@ _xfs_buf_ioapply(
 		bio->bi_end_io = xfs_buf_bio_end_io;
 		bio->bi_private = bp;
 
+		if (is_vmalloc_addr(bp->b_addr))
+			flush_kernel_dcache_addr(bp->b_addr);
+
 		bio_add_page(bio, bp->b_pages[0], PAGE_CACHE_SIZE, 0);
 		size = 0;
 
@@ -1228,6 +1245,9 @@ next_chunk:
 		if (nbytes > size)
 			nbytes = size;
 
+		if (is_vmalloc_addr(bp->b_addr))
+			flush_kernel_dcache_addr(bp->b_addr + PAGE_SIZE*map_i);
+
 		rbytes = bio_add_page(bio, bp->b_pages[map_i], nbytes, offset);
 		if (rbytes < nbytes)
 			break;
-- 
1.6.3.3

  reply	other threads:[~2009-09-17 23:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17 23:06 [PATCH 0/6] fix xfs by making I/O to vmap/vmalloc areas work James Bottomley
2009-09-17 23:06 ` [PATCH 1/6] mm: add coherence API for DMA to vmalloc/vmap areas James Bottomley
2009-09-17 23:06   ` [PATCH 2/6] parisc: add mm " James Bottomley
2009-09-17 23:06     ` [PATCH 3/6] arm: " James Bottomley
2009-09-17 23:06       ` [PATCH 4/6] sh: " James Bottomley
2009-09-17 23:07         ` [PATCH 5/6] block: permit I/O to vmalloc/vmap kernel pages James Bottomley
2009-09-17 23:07           ` James Bottomley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-11-17 17:03 [PATCH 0/6] fix xfs by making I/O to vmap/vmalloc areas work James Bottomley
2009-11-17 17:03 ` [PATCH 1/6] mm: add coherence API for DMA to vmalloc/vmap areas James Bottomley
2009-11-17 17:03   ` [PATCH 2/6] parisc: add mm " James Bottomley
2009-11-17 17:03     ` [PATCH 3/6] arm: " James Bottomley
2009-11-17 17:03       ` [PATCH 4/6] sh: " James Bottomley
2009-11-17 17:03         ` [PATCH 5/6] block: permit I/O to vmalloc/vmap kernel pages James Bottomley
2009-11-17 17:03           ` [PATCH 6/6] xfs: fix xfs to work with Virtually Indexed architectures James Bottomley
2009-09-09 15:52 [PATCH 0/6] fix xfs by making I/O to vmap/vmalloc areas work James Bottomley
2009-09-09 15:52 ` [PATCH 1/6] mm: add coherence API for DMA to vmalloc/vmap areas James Bottomley
2009-09-09 15:52   ` [PATCH 2/6] parisc: add mm " James Bottomley
2009-09-09 15:52     ` [PATCH 3/6] arm: " James Bottomley
2009-09-09 15:52       ` [PATCH 4/6] sh: " James Bottomley
2009-09-09 15:52         ` [PATCH 5/6] block: permit I/O to vmalloc/vmap kernel pages James Bottomley
2009-09-09 15:52           ` [PATCH 6/6] xfs: fix xfs to work with Virtually Indexed architectures James Bottomley
2009-09-09 17:55             ` Christoph Hellwig
2009-09-11 21:57             ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253228821-4700-7-git-send-email-James.Bottomley@suse.de \
    --to=james.bottomley@suse.de \
    --cc=hch@lst.de \
    --cc=jejb@external.hp.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.