All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: linux-input@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Subject: [PATCH 1/2] Input: atkbd - add forced release keys quirk for Positivo I30
Date: Fri, 16 Oct 2009 19:18:14 -0300	[thread overview]
Message-ID: <1255731495-27552-1-git-send-email-herton@mandriva.com.br> (raw)

Positivo I30 doesn't send release key event for volume up/down/mute
keys. The key list is the same as previous added Soltech TA12 quirk,
so integrate this using same list.

Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
---
 drivers/input/keyboard/atkbd.c |   16 +++++++++++++---
 1 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 4709e15..296f1fd 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -904,9 +904,10 @@ static unsigned int atkbd_amilo_xi3650_forced_release_keys[] = {
 };
 
 /*
- * Soltech TA12 system with broken key release on volume keys and mute key
+ * Many notebooks don't send key release event for volume up/down/mute
+ * keys, with key list below common among them
  */
-static unsigned int atkdb_soltech_ta12_forced_release_keys[] = {
+static unsigned int atkbd_mute_volume_forced_release_keys[] = {
 	0xa0, 0xae, 0xb0, -1U
 };
 
@@ -1647,7 +1648,16 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "TA12"),
 		},
 		.callback = atkbd_setup_forced_release,
-		.driver_data = atkdb_soltech_ta12_forced_release_keys,
+		.driver_data = atkbd_mute_volume_forced_release_keys,
+	},
+	{
+		.ident = "Positivo I30",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "POSITIVO"),
+			DMI_MATCH(DMI_BOARD_NAME, "I30"),
+		},
+		.callback = atkbd_setup_forced_release,
+		.driver_data = atkbd_mute_volume_forced_release_keys,
 	},
 	{ }
 };
-- 
1.6.4.4


             reply	other threads:[~2009-10-16 22:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16 22:18 Herton Ronaldo Krzesinski [this message]
2009-10-16 22:18 ` [PATCH 2/2] Input: atkbd - remove duplicated release key list quirks for some machines Herton Ronaldo Krzesinski
2009-10-18  7:08   ` Dmitry Torokhov
2009-10-18  7:07 ` [PATCH 1/2] Input: atkbd - add forced release keys quirk for Positivo I30 Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255731495-27552-1-git-send-email-herton@mandriva.com.br \
    --to=herton@mandriva.com.br \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.