All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: linux-acpi@vger.kernel.org
Cc: lenb@kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: [PATCH] acpi: Disable explicit power state retrieval on fans
Date: Tue, 10 Nov 2009 15:09:12 -0500	[thread overview]
Message-ID: <1257883752-2163-1-git-send-email-mjg@redhat.com> (raw)

https://bugzilla.redhat.com/show_bug.cgi?id=531916 describes a system
with a _PSC method for the fan that always returns "on". There's no
benefit in us always requesting the state of the fan when performing
transitions - we want to do everything we can to ensure that the fan turns
on when it should do, not risk hardware damage by believing the hardware
when it tells us the fan is already on. Given that the Leading Other OS(tm)
works fine on this machine, it seems likely that it behaves in much this
way.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
 drivers/acpi/fan.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
index f419849..835b55e 100644
--- a/drivers/acpi/fan.c
+++ b/drivers/acpi/fan.c
@@ -256,6 +256,7 @@ static int acpi_fan_add(struct acpi_device *device)
 		goto end;
 	}
 
+	device->power.flags.explicit_get = 0;
 	device->flags.force_power_state = 1;
 	acpi_bus_set_power(device->handle, state);
 	device->flags.force_power_state = 0;
-- 
1.6.5.2


             reply	other threads:[~2009-11-10 20:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 20:09 Matthew Garrett [this message]
2009-11-24 14:36 ` [PATCH] acpi: Disable explicit power state retrieval on fans Matthew Garrett
2009-12-11  3:52 ` Zhang Rui
2009-12-17  8:02   ` Zhang Rui
     [not found]     ` <20091217191353.GA11041@srcf.ucam.org>
2009-12-18  1:02       ` Zhang Rui
2009-12-29  2:47     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257883752-2163-1-git-send-email-mjg@redhat.com \
    --to=mjg@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.