All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@nokia.com>
To: Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Cc: Tony Lindgren <tony@atomide.com>, Felipe Balbi <felipe.balbi@nokia.com>
Subject: [rft/rfc/patch-2.6.32-omap1+ 6/6] cbus: no ternary on return
Date: Wed, 16 Dec 2009 01:44:13 +0200	[thread overview]
Message-ID: <1260920653-18503-7-git-send-email-felipe.balbi@nokia.com> (raw)
In-Reply-To: <1260920653-18503-1-git-send-email-felipe.balbi@nokia.com>

data is reset to 0 if is_read is true. No need
to use ternary operator before returning.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/cbus/cbus.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/cbus/cbus.c b/drivers/cbus/cbus.c
index 615f447..35f7c71 100644
--- a/drivers/cbus/cbus.c
+++ b/drivers/cbus/cbus.c
@@ -121,7 +121,7 @@ static int cbus_transfer(struct cbus_host *host, int dev, int reg, int data)
 
 	spin_unlock_irqrestore(&host->lock, flags);
 
-	return is_read ? data : 0;
+	return data;
 }
 
 /*
-- 
1.6.6.rc0


      parent reply	other threads:[~2009-12-15 23:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-15 23:44 [rft/rfc/patch-2.6.32-omap1+ 0/6] more cbus fixes Felipe Balbi
2009-12-15 23:44 ` [rft/rfc/patch-2.6.32-omap1+ 1/6] cbus: convert u32 base to void __iomem *base Felipe Balbi
2009-12-15 23:44 ` [rft/rfc/patch-2.6.32-omap1+ 2/6] cbus: NULL global variable on exit Felipe Balbi
2009-12-15 23:44 ` [rft/rfc/patch-2.6.32-omap1+ 3/6] cbus: checkpatch.pl fix on cbus.c Felipe Balbi
2009-12-15 23:44 ` [rft/rfc/patch-2.6.32-omap1+ 4/6] cbus: don't export the global cbus_host variable Felipe Balbi
2009-12-15 23:44 ` [rft/rfc/patch-2.6.32-omap1+ 5/6] cbus: rely on gpiolib Felipe Balbi
2009-12-15 23:44 ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260920653-18503-7-git-send-email-felipe.balbi@nokia.com \
    --to=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.