All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergio Aguirre <saaguirre@ti.com>
To: linux-omap@vger.kernel.org
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
	Vikram Pandita <vikram.pandita@ti.com>,
	Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>,
	Felipe Balbi <me@felipebalbi.com>,
	Sergio Aguirre <saaguirre@ti.com>
Subject: [RFC part1/2 merge v3][PATCH 02/10] omap2/3/4: serial: Remove condition for getting uart4_phys
Date: Tue,  9 Mar 2010 10:16:46 -0600	[thread overview]
Message-ID: <1268151414-17071-3-git-send-email-saaguirre@ti.com> (raw)
In-Reply-To: <1268151414-17071-1-git-send-email-saaguirre@ti.com>

This check is invalid, since we haven't filled the
omap_revision var at this point.

Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
---
 arch/arm/mach-omap2/serial.c |   14 +-------------
 1 files changed, 1 insertions(+), 13 deletions(-)

diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index 6010d3d..c9e203b 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -115,7 +115,6 @@ static struct plat_serial8250_port serial_platform_data2[] = {
 	}
 };
 
-#if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
 static struct plat_serial8250_port serial_platform_data3[] = {
 	{
 		.irq		= 70,
@@ -128,23 +127,12 @@ static struct plat_serial8250_port serial_platform_data3[] = {
 	}
 };
 
-static inline void omap2_set_globals_uart4(struct omap_globals *omap2_globals)
-{
-	serial_platform_data3[0].mapbase = omap2_globals->uart4_phys;
-}
-#else
-static inline void omap2_set_globals_uart4(struct omap_globals *omap2_globals)
-{
-}
-#endif
-
 void __init omap2_set_globals_uart(struct omap_globals *omap2_globals)
 {
 	serial_platform_data0[0].mapbase = omap2_globals->uart1_phys;
 	serial_platform_data1[0].mapbase = omap2_globals->uart2_phys;
 	serial_platform_data2[0].mapbase = omap2_globals->uart3_phys;
-	if (cpu_is_omap3630() || cpu_is_omap44xx())
-		omap2_set_globals_uart4(omap2_globals);
+	serial_platform_data3[0].mapbase = omap2_globals->uart4_phys;
 }
 
 static inline unsigned int __serial_read_reg(struct uart_port *up,
-- 
1.6.3.3


  parent reply	other threads:[~2010-03-09 16:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09 16:16 [RFC part1/2 merge v3][PATCH 00/10] omap2/3/4: uart4 fixes + zoom2/3 changes Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 01/10] OMAP3: serial: Check for zero-based physical addr Sergio Aguirre
2010-03-09 16:21   ` Felipe Balbi
2010-03-09 16:30     ` Aguirre, Sergio
2010-03-09 17:39       ` Felipe Balbi
2010-03-09 16:16 ` Sergio Aguirre [this message]
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 03/10] ARM: OMAP3630: PRCM: Add UART4 control bits Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 04/10] OMAP clock: Add uart4_ick/fck definitions for 3630 Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 05/10] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 06/10] omap3: serial: Fix uart4 handling for 3630 Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 07/10] omap3: zoom2/3 / 3630sdp: Don't init always all uarts Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 08/10] omap3: 3630sdp: Explicitly enable all UARTs Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 09/10] omap3: zoom 2/3: Change debugboard serial port id Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 10/10] omap3: zoom2/3: Register only 1 8250 port Sergio Aguirre
2010-03-09 16:33 ` [RFC part1/2 merge v3][PATCH 00/10] omap2/3/4: uart4 fixes + zoom2/3 changes Aguirre, Sergio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268151414-17071-3-git-send-email-saaguirre@ti.com \
    --to=saaguirre@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=me@felipebalbi.com \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.