From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, John Kacur <jkacur@gmail.com>,
Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Subject: [PATCH 3/3] input: remove BKL from serio_raw
Date: Tue, 9 Mar 2010 16:19:46 -0300 [thread overview]
Message-ID: <1268162386-2745-3-git-send-email-cascardo@holoscopio.com> (raw)
In-Reply-To: <1268162386-2745-2-git-send-email-cascardo@holoscopio.com>
serio_raw open function already uses a mutex.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
drivers/input/serio/serio_raw.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c
index 27fdaaf..debe4a1 100644
--- a/drivers/input/serio/serio_raw.c
+++ b/drivers/input/serio/serio_raw.c
@@ -81,10 +81,9 @@ static int serio_raw_open(struct inode *inode, struct file *file)
struct serio_raw_list *list;
int retval = 0;
- lock_kernel();
retval = mutex_lock_interruptible(&serio_raw_mutex);
if (retval)
- goto out_bkl;
+ return retval;
if (!(serio_raw = serio_raw_locate(iminor(inode)))) {
retval = -ENODEV;
@@ -109,8 +108,6 @@ static int serio_raw_open(struct inode *inode, struct file *file)
out:
mutex_unlock(&serio_raw_mutex);
-out_bkl:
- unlock_kernel();
return retval;
}
--
1.6.6.1
next prev parent reply other threads:[~2010-03-09 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 19:19 [PATCH 1/3] input: remove BKL from mousedev Thadeu Lima de Souza Cascardo
2010-03-09 19:19 ` [PATCH 2/3] input: use input_mutex instead of BKL when opening input device Thadeu Lima de Souza Cascardo
2010-03-09 19:19 ` Thadeu Lima de Souza Cascardo [this message]
2010-03-09 20:06 ` [PATCH 3/3] input: remove BKL from serio_raw Arnd Bergmann
2010-03-09 20:06 ` [PATCH 2/3] input: use input_mutex instead of BKL when opening input device Arnd Bergmann
2010-03-09 20:12 ` Arnd Bergmann
2010-03-09 20:59 ` Thadeu Lima de Souza Cascardo
2010-03-10 6:20 ` Dmitry Torokhov
2010-03-10 6:49 ` Oliver Neukum
2010-03-10 6:56 ` Dmitry Torokhov
2010-03-09 20:05 ` [PATCH 1/3] input: remove BKL from mousedev Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268162386-2745-3-git-send-email-cascardo@holoscopio.com \
--to=cascardo@holoscopio.com \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=jkacur@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.