All of lore.kernel.org
 help / color / mirror / Atom feed
From: felipe.balbi@nokia.com
To: Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Cc: Felipe Balbi <felipe.balbi@nokia.com>
Subject: [RFC PATCH 19/37] cbus: retu: convert to a platform_driver
Date: Wed,  7 Apr 2010 19:04:10 +0300	[thread overview]
Message-ID: <1270656268-7034-20-git-send-email-felipe.balbi@nokia.com> (raw)
In-Reply-To: <1270656268-7034-1-git-send-email-felipe.balbi@nokia.com>

From: Felipe Balbi <felipe.balbi@nokia.com>

preparing this driver for mainline. Convert into
a platform_driver and prepare to split platform_device
code from platform_driver code.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/cbus/retu.c |   29 +++++++++++++++--------------
 1 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/drivers/cbus/retu.c b/drivers/cbus/retu.c
index 8b85221..ea09c17 100644
--- a/drivers/cbus/retu.c
+++ b/drivers/cbus/retu.c
@@ -336,7 +336,7 @@ static void retu_power_off(void)
  * Probe for the Retu ASIC and allocate memory
  * for its device-struct if found
  */
-static int __devinit retu_probe(struct device *dev)
+static int __devinit retu_probe(struct platform_device *pdev)
 {
 	int rev, ret;
 
@@ -350,13 +350,13 @@ static int __devinit retu_probe(struct device *dev)
 			machine_is_nokia_n810_wimax()) {
 		retu_irq_pin = 108;
 	} else {
-		dev_err(dev, "cbus: Unsupported board for tahvo\n");
+		dev_err(&pdev->dev, "cbus: Unsupported board for tahvo\n");
 		return -ENODEV;
 	}
 
 	ret = gpio_request(retu_irq_pin, "RETU irq");
 	if (ret < 0) {
-		dev_err(dev, "Unable to reserve IRQ GPIO\n");
+		dev_err(&pdev->dev, "Unable to reserve IRQ GPIO\n");
 		return ret;
 	}
 
@@ -372,7 +372,7 @@ static int __devinit retu_probe(struct device *dev)
 	if (rev & (1 << 7))
 		retu_is_vilma = 1;
 
-	dev_info(dev, "%s v%d.%d found\n", retu_is_vilma ? "Vilma" : "Retu",
+	dev_info(&pdev->dev, "%s v%d.%d found\n", retu_is_vilma ? "Vilma" : "Retu",
 	       (rev >> 4) & 0x07, rev & 0x0f);
 
 	/* Mask all RETU interrupts */
@@ -381,7 +381,7 @@ static int __devinit retu_probe(struct device *dev)
 	ret = request_irq(gpio_to_irq(retu_irq_pin), retu_irq_handler, 0,
 			  "retu", 0);
 	if (ret < 0) {
-		dev_err(dev, "Unable to register IRQ handler\n");
+		dev_err(&pdev->dev, "Unable to register IRQ handler\n");
 		gpio_free(retu_irq_pin);
 		return ret;
 	}
@@ -393,7 +393,7 @@ static int __devinit retu_probe(struct device *dev)
 #ifdef CONFIG_CBUS_RETU_USER
 	/* Initialize user-space interface */
 	if (retu_user_init() < 0) {
-		dev_err(dev, "Unable to initialize driver\n");
+		dev_err(&pdev->dev, "Unable to initialize driver\n");
 		free_irq(gpio_to_irq(retu_irq_pin), 0);
 		gpio_free(retu_irq_pin);
 		return ret;
@@ -403,7 +403,7 @@ static int __devinit retu_probe(struct device *dev)
 	return 0;
 }
 
-static int retu_remove(struct device *dev)
+static int __devexit retu_remove(struct platform_device *pdev)
 {
 #ifdef CONFIG_CBUS_RETU_USER
 	retu_user_cleanup();
@@ -422,11 +422,12 @@ static void retu_device_release(struct device *dev)
 	complete(&device_release);
 }
 
-static struct device_driver retu_driver = {
-	.name		= "retu",
-	.bus		= &platform_bus_type,
+static struct platform_driver retu_driver = {
 	.probe		= retu_probe,
-	.remove		= retu_remove,
+	.remove		= __devexit_p(retu_remove),
+	.driver		= {
+		.name	= "retu",
+	},
 };
 
 static struct platform_device retu_device = {
@@ -452,13 +453,13 @@ static int __init retu_init(void)
 
 	init_completion(&device_release);
 
-	ret = driver_register(&retu_driver);
+	ret = platform_driver_register(&retu_driver);
 	if (ret < 0)
 		return ret;
 
 	ret = platform_device_register(&retu_device);
 	if (ret < 0) {
-		driver_unregister(&retu_driver);
+		platform_driver_unregister(&retu_driver);
 		return ret;
 	}
 
@@ -471,7 +472,7 @@ static int __init retu_init(void)
 static void __exit retu_exit(void)
 {
 	platform_device_unregister(&retu_device);
-	driver_unregister(&retu_driver);
+	platform_driver_unregister(&retu_driver);
 	wait_for_completion(&device_release);
 }
 
-- 
1.7.0.rc0.33.g7c3932


  parent reply	other threads:[~2010-04-07 16:05 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-07 16:03 [RFC PATCH 00/37] cbus patches felipe.balbi
2010-04-07 16:03 ` [RFC PATCH 01/37] cbus: convert u32 base to void __iomem *base felipe.balbi
2010-04-07 16:03 ` [RFC PATCH 02/37] cbus: NULL global variable on exit felipe.balbi
2010-04-07 16:03 ` [RFC PATCH 03/37] cbus: checkpatch.pl fix on cbus.c felipe.balbi
2010-04-07 16:03 ` [RFC PATCH 04/37] cbus: don't export the global cbus_host variable felipe.balbi
2010-04-07 16:03 ` [RFC PATCH 05/37] cbus: rely on gpiolib felipe.balbi
2010-04-07 16:03 ` [RFC PATCH 06/37] cbus: no ternary on return felipe.balbi
2010-04-07 16:03 ` [RFC PATCH 07/37] cbus: add read/write flag to cbus_transfer felipe.balbi
2010-04-07 16:03 ` [RFC PATCH 08/37] cbus: don't type case when issuing read/write felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 09/37] cbus: fix a resource leakage felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 10/37] cbus: move cbus_host definition to C source felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 11/37] cbus: handle possible errors on cbus_send/receive_bit felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 12/37] cbus: introduce cbus_send/receive_data wrappers felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 13/37] cbus: add kerneldoc felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 14/37] cbus: retu-wdt: fix compile breakage felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 15/37] cbus: retu: fix compile breakage on retu-headset felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 16/37] cbus: retu: split one MODULE_AUTHOR into several felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 17/37] cbus: retu: don't assing ret inside the if () felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 18/37] cbus: retu: convert printk to dev_* felipe.balbi
2010-04-07 16:04 ` felipe.balbi [this message]
2010-04-07 16:04 ` [RFC PATCH 20/37] cbus: tahvo: split MODULE_AUTHOR into several entries felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 21/37] cbus: tahvo: move EXPORT_SYMBOL macros closer to functions felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 22/37] cbus: tahvo: don't assign ret inside if () felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 23/37] cbus: tahvo: convert printk into dev_* felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 24/37] cbus: tahvo: convert to platform_driver felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 25/37] cbus: retu: allocate platform_device for Retu's children felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 26/37] cbus: retu-pwrbutton: convert to platform_driver felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 27/37] cbus: retu-headset: simplify module_init felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 28/37] cbus: retu-rtc: remove platform_device code felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 29/37] cbus: retu-rtc: convert to platform_driver felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 30/37] cbus: retu-rtc: split MODULE_AUTHOR into several entries felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 31/37] cbus: retu-rtc: get rid of globals felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 32/37] cbus: retu-rtc: move retu_rtc_barrier up on source code felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 33/37] cbus: retu-rtc: make checkpatch.pl happy felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 34/37] cbus: retu-rtc: switch to rtc class device felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 35/37] cbus: retu-wdt: remove the platform_device felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 36/37] cbus: retu-wtd: convert to platform_driver felipe.balbi
2010-04-07 16:04 ` [RFC PATCH 37/37] cbus: retu-wdt: misc cleanup on retu-wdt driver felipe.balbi
2010-04-08  9:23 ` [RFC PATCH 00/37] cbus patches Tony Lindgren
2010-04-24  0:45   ` Tony Lindgren
2010-04-26  5:25     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270656268-7034-20-git-send-email-felipe.balbi@nokia.com \
    --to=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.