All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Valentin <eduardo.valentin@nokia.com>
To: Core-Review <core-review@ok.research.nokia.com>
Cc: "\\\"Hogander Jouni (Nokia-D/Tampere)\\\""
	<jouni.hogander@nokia.com>,
	"\\\"Koskinen Aaro (Nokia-D/Helsinki)\\\""
	<aaro.koskinen@nokia.com>,
	Amit Kucheria <amit.kucheria@verdurent.com>,
	linux-omap@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: [PATCHv3 02/11] mfd: Add comments for the twl4030-power register and bit layout
Date: Thu, 22 Apr 2010 11:07:34 +0300	[thread overview]
Message-ID: <1271923663-23668-3-git-send-email-eduardo.valentin@nokia.com> (raw)
In-Reply-To: <1271923663-23668-1-git-send-email-eduardo.valentin@nokia.com>

From: Amit Kucheria <amit.kucheria@verdurent.com>

Describe how the resource registers are laid out and the various bit-fields in
them.

Signed-off-by: Amit Kucheria <amit.kucheria@verdurent.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
---
 drivers/mfd/twl4030-power.c |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index 8f82e22..2bec947 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -72,14 +72,22 @@ static u8 twl4030_start_script_address = 0x2b;
 #define R_KEY_1			0xC0
 #define R_KEY_2			0x0C
 
-/* resource configuration registers */
-
+/* resource configuration registers
+   <RESOURCE>_DEV_GRP   at address 'n+0'
+   <RESOURCE>_TYPE      at address 'n+1'
+   <RESOURCE>_REMAP     at address 'n+2'
+   <RESOURCE>_DEDICATED at address 'n+3'
+*/
 #define DEV_GRP_OFFSET		0
 #define TYPE_OFFSET		1
 
 /* Bit positions in the registers */
+
+/* <RESOURCE>_DEV_GRP */
 #define DEV_GRP_SHIFT		5
 #define DEV_GRP_MASK		(7 << DEV_GRP_SHIFT)
+
+/* <RESOURCE>_TYPE */
 #define TYPE_SHIFT		0
 #define TYPE_MASK		(7 << TYPE_SHIFT)
 #define TYPE2_SHIFT		3
-- 
1.7.0.4.361.g8b5fe.dirty


  parent reply	other threads:[~2010-04-22  8:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1271923663-23668-1-git-send-email-eduardo.valentin@nokia.com>
2010-04-22  8:07 ` [PATCHv3 01/11] mfd: twl4030-power: Rename DEVGROUP to DEV_GRP Eduardo Valentin
2010-04-22  8:19   ` Eduardo Valentin
2010-04-22  8:07 ` Eduardo Valentin [this message]
2010-04-22  8:07 ` [PATCHv3 03/11] mfd: Add support for remapping twl4030-power power states Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271923663-23668-3-git-send-email-eduardo.valentin@nokia.com \
    --to=eduardo.valentin@nokia.com \
    --cc=aaro.koskinen@nokia.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=core-review@ok.research.nokia.com \
    --cc=jouni.hogander@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.