All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] i915: fix ironlake edp panel setup (v2)
Date: Tue, 29 Jun 2010 09:47:04 -0400	[thread overview]
Message-ID: <1277819224.2586.48.camel@atropine> (raw)
In-Reply-To: <20100629084443.GH10521@zhen-devel.sh.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1121 bytes --]

On Tue, 2010-06-29 at 16:44 +0800, Zhenyu Wang wrote:
> On 2010.06.28 14:04:56 +0800, Zhenyu Wang wrote:
> > 
> > sorry, this is still broken on the 16x9 panel. 
> > 
> > 'intel_dp_link_required' is 107840*18/8 = 242640, 'intel_dp_max_data_rate' is
> > 270000*1*8/10 = 216000. So it will fail in both check.
> 
> Dave, here's dmesg in working (upstream) and your patch applied cases.
> Sorry, this panel does have EDID but is invalid.

That's not "has invalid EDID", that's "really doesn't have EDID at all".
Might be DisplayID!  Any chance you can try a patch like this and give
me the dmesg?  It'll still look like an EDID failure but it should be
something more interesting than cc cc cc cc ...

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index bd74b3f..16beed2 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -201,7 +201,7 @@ bool drm_edid_is_valid(struct edid *edid)
 }
 EXPORT_SYMBOL(drm_edid_is_valid);
 
-#define DDC_ADDR 0x50
+#define DDC_ADDR 0x52
 #define DDC_SEGMENT_ADDR 0x30
 /**
  * Get EDID information via I2C.

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2010-06-29 13:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-27 23:45 [PATCH] i915: fix ironlake edp panel setup (v2) Dave Airlie
2010-06-28  6:04 ` Zhenyu Wang
2010-06-28  6:28   ` Dave Airlie
2010-06-28 12:57     ` Ben Guthro
2010-06-29  8:44   ` Zhenyu Wang
2010-06-29 13:47     ` Adam Jackson [this message]
2010-06-29 15:34       ` Zhenyu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277819224.2586.48.camel@atropine \
    --to=ajax@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=zhenyuw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.