All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 18/29] drm/i915/crt: Flush register prior to waiting for vblank.
Date: Sun, 22 Aug 2010 12:05:37 +0100	[thread overview]
Message-ID: <1282475148-15951-19-git-send-email-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <1282475148-15951-1-git-send-email-chris@chris-wilson.co.uk>

If we don't flush the write then we can not be sure that the border
colour will have taken effect by the time we try to read it back.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_crt.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index 4b77351..f915793 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -327,6 +327,7 @@ intel_crt_load_detect(struct drm_crtc *crtc, struct intel_encoder *intel_encoder
 	if (IS_I9XX(dev)) {
 		uint32_t pipeconf = I915_READ(pipeconf_reg);
 		I915_WRITE(pipeconf_reg, pipeconf | PIPECONF_FORCE_BORDER);
+		POSTING_READ(pipeconf_reg);
 		/* Wait for next Vblank to substitue
 		 * border color for Color info */
 		intel_wait_for_vblank(dev, pipe);
-- 
1.7.1

  parent reply	other threads:[~2010-08-22 11:06 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-22 11:05 More patches (resend) Chris Wilson
2010-08-22 11:05 ` [PATCH 01/29] drm/i915: unload: fix intel dp encoder cleanup Chris Wilson
2010-08-22 11:05 ` [PATCH 02/29] drm/i915: unload: fix error_work races Chris Wilson
2010-08-22 11:05 ` [PATCH 03/29] drm/i915: unload: fix hotplug_work races Chris Wilson
2010-08-22 11:05 ` [PATCH 04/29] drm/i915: unload: don't leak error state Chris Wilson
2010-08-22 11:05 ` [PATCH 05/29] drm/i915: unload: fix idle_timer/idle_work races Chris Wilson
2010-08-22 11:05 ` [PATCH 06/29] drm/i915: unload: fix unpin_work related races Chris Wilson
2010-08-22 11:05 ` [PATCH 07/29] drm/i915: unload: ensure that gem is idle Chris Wilson
2010-08-22 11:05 ` [PATCH 08/29] drm/i915: unload: fix retire_work races Chris Wilson
2010-08-22 11:05 ` [PATCH 09/29] drm/i915: Fixup intel_wait_for_vblank*() Chris Wilson
2010-08-23 16:56   ` [PATCH] drm/i915: Drop the msleep parameter to wait_for() Chris Wilson
2010-08-23 23:16     ` Peter Clifton
2010-08-23 23:33       ` Chris Wilson
2010-08-23 23:42         ` Peter Clifton
2010-08-22 11:05 ` [PATCH 10/29] drm/i915: Avoid using msleep under kdb and wait_for() Chris Wilson
2010-08-22 11:05 ` [PATCH 11/29] drm/i915: Include a generation number in the device info Chris Wilson
2010-08-22 11:05 ` [PATCH 12/29] drm/i915: Fix offset page-flips on i965+ Chris Wilson
2010-08-22 11:05 ` [PATCH 13/29] drm/i915: Clear scanline waits after disabling the pipe Chris Wilson
2010-08-22 11:05 ` [PATCH 14/29] drm/i915: Sanity check user framebuffer parameters on creation Chris Wilson
2010-08-22 11:05 ` [PATCH 15/29] drm/i915: Re-use set_base_atomic to share setting of the display registers Chris Wilson
2010-08-22 11:05 ` [PATCH 16/29] drm/i915/sdvo: Propagate error from switching control buses Chris Wilson
2010-08-22 11:05 ` [PATCH 17/29] drm/i915: Add ringbuffer wait reset to hangcheck Chris Wilson
2010-08-22 11:05 ` Chris Wilson [this message]
2010-08-22 11:05 ` [PATCH 19/29] drm/i915/dp: Boost timeout for enabling transcoder to 100ms Chris Wilson
2010-08-22 11:05 ` [PATCH 20/29] drm/i915/sdvo: Guess the DDC bus in absence of VBIOS Chris Wilson
2010-08-22 11:05 ` [PATCH 21/29] drm/i915/tv: Flush register writes before sleeping Chris Wilson
2010-08-22 11:05 ` [PATCH 22/29] drm/i915/dp: Really try 5 times before giving up Chris Wilson
2010-08-30 22:35   ` Eric Anholt
2010-08-22 11:05 ` [PATCH 23/29] drm/i915/debug: Include Ironlake in self-refresh status Chris Wilson
2010-08-22 11:05 ` [PATCH 24/29] drm/i915: Allocate the PCI resource for the MCHBAR Chris Wilson
2010-08-22 11:05 ` [PATCH 25/29] drm/i915: Use the VBT from OpRegion when available (v2) Chris Wilson
2010-08-22 11:05 ` [PATCH 26/29] drm/i915: Invert watermarks used for i8xx, i9xx Chris Wilson
2010-08-30 22:39   ` Eric Anholt
2010-08-22 11:05 ` [PATCH 27/29] drm: Scan EDID for an audio-capable HDMI output Chris Wilson
2010-08-23 15:05   ` Adam Jackson
2010-08-22 11:05 ` [PATCH 28/29] drm/i915/hdmi: Only enable audio if supported by the monitor Chris Wilson
2010-08-22 11:05 ` [PATCH 29/29] drm/i915: Tightly scope intel_encoder to prevent invalid use Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282475148-15951-19-git-send-email-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.