All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Cristau <jcristau@debian.org>
To: intel-gfx@lists.freedesktop.org, Chris Wilson <chris@chris-wilson.co.uk>
Cc: Julien Cristau <jcristau@debian.org>
Subject: [PATCH] Disable DRI2 if we're running on shadowfb
Date: Wed, 22 Sep 2010 13:47:27 +0200	[thread overview]
Message-ID: <1285156047-21138-1-git-send-email-jcristau@debian.org> (raw)

Without this change, DRI2 gets enabled but doesn't work and glxinfo
crashes my X server.

Signed-off-by: Julien Cristau <jcristau@debian.org>
---
 src/intel_driver.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/intel_driver.c b/src/intel_driver.c
index c0ad69e..ad90174 100644
--- a/src/intel_driver.c
+++ b/src/intel_driver.c
@@ -830,12 +830,6 @@ I830ScreenInit(int scrnIndex, ScreenPtr screen, int argc, char **argv)
 
 	scrn->videoRam = device->regions[fb_bar].size / 1024;
 
-#ifdef DRI2
-	if (intel->directRenderingType == DRI_NONE
-	    && I830DRI2ScreenInit(screen))
-		intel->directRenderingType = DRI_DRI2;
-#endif
-
 	intel->force_fallback = FALSE;
 	intel->use_shadow = FALSE;
 
@@ -859,8 +853,15 @@ I830ScreenInit(int scrnIndex, ScreenPtr screen, int argc, char **argv)
 		xf86DrvMsg(scrn->scrnIndex, X_CONFIG,
 			   "Shadow buffer enabled,"
 			   " GPU acceleration disabled.\n");
+		intel->directRenderingType = DRI_DISABLED;
 	}
 
+#ifdef DRI2
+	if (intel->directRenderingType == DRI_NONE
+	    && I830DRI2ScreenInit(screen))
+		intel->directRenderingType = DRI_DRI2;
+#endif
+
 	/* SwapBuffers delays to avoid tearing */
 	intel->swapbuffers_wait = TRUE;
 
-- 
1.7.1

             reply	other threads:[~2010-09-22 11:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22 11:47 Julien Cristau [this message]
2010-09-22 12:17 ` [PATCH] Disable DRI2 if we are running on shadowfb Chris Wilson
2010-09-23 12:50   ` [PATCH] glx: Fix use after free in DrawableGone Kristian Høgsberg
2010-09-23 13:04     ` [PATCH v2] " Kristian Høgsberg
     [not found]       ` <1285247051-2717-1-git-send-email-krh-1OA22m9ORUweIZ0/mPfg9Q@public.gmane.org>
2010-09-23 13:55         ` Chris Wilson
2010-09-23 16:51         ` Jeremy Huddleston
     [not found]           ` <A7B70C84-4699-4A06-8769-6195E3B8A631-2kanFRK1NckAvxtiuMwx3w@public.gmane.org>
2010-09-23 17:25             ` Kristian Høgsberg
2010-09-27 12:42               ` Kristian Høgsberg
     [not found]                 ` <AANLkTimm9mbEHgzmKr7xNm3HSfUyfnoZ2OFe_RTDoPF6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-27 17:08                   ` Jeremy Huddleston
2010-09-28 15:05         ` Keith Packard
     [not found] ` <1285156047-21138-1-git-send-email-jcristau-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2010-09-22 12:32   ` [PATCH] glx: Avoid use-after-free after drawableGone Chris Wilson
     [not found]     ` <1285158749-9056-1-git-send-email-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
2010-09-22 15:12       ` jamey-sH+B+fTmh7PR7s880joybQ
2010-09-22 15:21       ` Adam Jackson
2010-09-22 13:35 ` [PATCH] Disable DRI2 if we're running on shadowfb Owain Ainsworth
2010-09-22 14:42   ` [PATCH] Disable DRI2 if we are " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285156047-21138-1-git-send-email-jcristau@debian.org \
    --to=jcristau@debian.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.