All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fernando Guzman Lugo <x0095840@ti.com>
To: <Hiroshi.DOYU@nokia.com>, <david.cohen@nokia.com>
Cc: <felipe.contreras@nokia.com>, <ameya.palande@nokia.com>,
	<linux-kernel@vger.kernel.org>, <andy.shevchenko@gmail.com>,
	<linux-omap@vger.kernel.org>,
	Fernando Guzman Lugo <x0095840@ti.com>
Subject: [PATCHv2 1/3] iovmm: no gap checking for fixed address
Date: Mon,  4 Oct 2010 16:02:15 -0500	[thread overview]
Message-ID: <1286226137-1233-2-git-send-email-x0095840@ti.com> (raw)
In-Reply-To: <1286226137-1233-1-git-send-email-x0095840@ti.com>

If some fixed da address is wanted to be mapped and the page
is freed but it is used as gap, the mapping will fail.
This patch is fixing that and olny keeps the gap for
not fixed address.

Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
---
 arch/arm/plat-omap/iovmm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index 24ca9c4..34f0012 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -289,7 +289,7 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
 	prev_end = 0;
 	list_for_each_entry(tmp, &obj->mmap, list) {
 
-		if (prev_end >= start)
+		if (prev_end > start)
 			break;
 
 		if (start + bytes <= tmp->da_start)
@@ -301,7 +301,7 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
 		prev_end = tmp->da_end;
 	}
 
-	if ((start > prev_end) && (ULONG_MAX - start >= bytes))
+	if ((start >= prev_end) && (ULONG_MAX - start + 1 >= bytes))
 		goto found;
 
 	dev_dbg(obj->dev, "%s: no space to fit %08x(%x) flags: %08x\n",
-- 
1.6.3.3


WARNING: multiple messages have this Message-ID (diff)
From: Fernando Guzman Lugo <x0095840@ti.com>
To: Hiroshi.DOYU@nokia.com, david.cohen@nokia.com
Cc: felipe.contreras@nokia.com, ameya.palande@nokia.com,
	linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com,
	linux-omap@vger.kernel.org,
	Fernando Guzman Lugo <x0095840@ti.com>
Subject: [PATCHv2 1/3] iovmm: no gap checking for fixed address
Date: Mon,  4 Oct 2010 16:02:15 -0500	[thread overview]
Message-ID: <1286226137-1233-2-git-send-email-x0095840@ti.com> (raw)
In-Reply-To: <1286226137-1233-1-git-send-email-x0095840@ti.com>

If some fixed da address is wanted to be mapped and the page
is freed but it is used as gap, the mapping will fail.
This patch is fixing that and olny keeps the gap for
not fixed address.

Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
---
 arch/arm/plat-omap/iovmm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index 24ca9c4..34f0012 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -289,7 +289,7 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
 	prev_end = 0;
 	list_for_each_entry(tmp, &obj->mmap, list) {
 
-		if (prev_end >= start)
+		if (prev_end > start)
 			break;
 
 		if (start + bytes <= tmp->da_start)
@@ -301,7 +301,7 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
 		prev_end = tmp->da_end;
 	}
 
-	if ((start > prev_end) && (ULONG_MAX - start >= bytes))
+	if ((start >= prev_end) && (ULONG_MAX - start + 1 >= bytes))
 		goto found;
 
 	dev_dbg(obj->dev, "%s: no space to fit %08x(%x) flags: %08x\n",
-- 
1.6.3.3


  reply	other threads:[~2010-10-04 20:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 21:02 [PATCHv2 0/3] iovmm: fixes for iovmm module Fernando Guzman Lugo
2010-10-04 21:02 ` Fernando Guzman Lugo
2010-10-04 21:02 ` Fernando Guzman Lugo [this message]
2010-10-04 21:02   ` [PATCHv2 1/3] iovmm: no gap checking for fixed address Fernando Guzman Lugo
2010-10-04 21:02   ` [PATCHv2 2/3] iovmm: add superpages support to fixed da address Fernando Guzman Lugo
2010-10-04 21:02     ` Fernando Guzman Lugo
2010-10-04 21:02     ` [PATCHv2 3/3] iovmm: replace __iounmap with omap_iounmap Fernando Guzman Lugo
2010-10-04 21:02       ` Fernando Guzman Lugo
2010-10-10 15:22     ` [PATCHv2 2/3] iovmm: add superpages support to fixed da address Felipe Contreras
2010-10-11 15:33       ` Guzman Lugo, Fernando
2010-10-11 15:33         ` Guzman Lugo, Fernando
2010-10-12 11:09         ` Felipe Contreras
2010-10-12 11:09           ` Felipe Contreras
2010-10-12 14:10           ` Guzman Lugo, Fernando
2010-10-12 14:10             ` Guzman Lugo, Fernando
2010-10-13 16:43             ` Felipe Contreras
2010-10-13 16:43               ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286226137-1233-2-git-send-email-x0095840@ti.com \
    --to=x0095840@ti.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=ameya.palande@nokia.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=david.cohen@nokia.com \
    --cc=felipe.contreras@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.