From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Cc: Jason Wang <jason77.wang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, amit.kucheria-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org, David Jander <david-/Q/L1SwJa3aEVqv0pETR8A@public.gmane.org>, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: [PATCH 7/6] spi/imx: Support different fifo sizes Date: Fri, 8 Oct 2010 11:24:01 +0200 [thread overview] Message-ID: <1286529841-20800-1-git-send-email-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20100902143908.GK14214-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> From: David Jander <david@protonic.nl> The i.MX51 ECSPI has a fifo size of 64 entries instead of 8 entries as found on the other cspi bus devices. Cc: Jason Wang <jason77.wang@gmail.com> Signed-off-by: David Jander <david@protonic.nl> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, this patch depends on patches already acked by Grant Likely and sitting in Sascha Hauer's imx-for-2.6.37 branch. Best regards Uwe drivers/spi/spi_imx.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c index 6bab2cf..55a38e2 100644 --- a/drivers/spi/spi_imx.c +++ b/drivers/spi/spi_imx.c @@ -77,6 +77,7 @@ struct spi_imx_devtype_data { void (*trigger)(struct spi_imx_data *); int (*rx_available)(struct spi_imx_data *); void (*reset)(struct spi_imx_data *); + unsigned int fifosize; }; struct spi_imx_data { @@ -541,6 +542,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = mx1_trigger, .rx_available = mx1_rx_available, .reset = mx1_reset, + .fifosize = 8, }, #endif #ifdef CONFIG_SPI_IMX_VER_0_0 @@ -550,6 +552,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = mx27_trigger, .rx_available = mx27_rx_available, .reset = spi_imx0_0_reset, + .fifosize = 8, }, #endif #ifdef CONFIG_SPI_IMX_VER_0_4 @@ -559,6 +562,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = mx31_trigger, .rx_available = mx31_rx_available, .reset = spi_imx0_4_reset, + .fifosize = 8, }, #endif #ifdef CONFIG_SPI_IMX_VER_0_7 @@ -568,6 +572,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = mx31_trigger, .rx_available = mx31_rx_available, .reset = spi_imx0_4_reset, + .fifosize = 8, }, #endif #ifdef CONFIG_SPI_IMX_VER_2_3 @@ -577,6 +582,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = spi_imx2_3_trigger, .rx_available = spi_imx2_3_rx_available, .reset = spi_imx2_3_reset, + .fifosize = 64, }, #endif }; @@ -596,7 +602,7 @@ static void spi_imx_chipselect(struct spi_device *spi, int is_active) static void spi_imx_push(struct spi_imx_data *spi_imx) { - while (spi_imx->txfifo < 8) { + while (spi_imx->txfifo < spi_imx->devtype_data.fifosize) { if (!spi_imx->count) break; spi_imx->tx(spi_imx); -- 1.7.2.3 ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 7/6] spi/imx: Support different fifo sizes Date: Fri, 8 Oct 2010 11:24:01 +0200 [thread overview] Message-ID: <1286529841-20800-1-git-send-email-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20100902143908.GK14214@pengutronix.de> From: David Jander <david@protonic.nl> The i.MX51 ECSPI has a fifo size of 64 entries instead of 8 entries as found on the other cspi bus devices. Cc: Jason Wang <jason77.wang@gmail.com> Signed-off-by: David Jander <david@protonic.nl> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> --- Hello, this patch depends on patches already acked by Grant Likely and sitting in Sascha Hauer's imx-for-2.6.37 branch. Best regards Uwe drivers/spi/spi_imx.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c index 6bab2cf..55a38e2 100644 --- a/drivers/spi/spi_imx.c +++ b/drivers/spi/spi_imx.c @@ -77,6 +77,7 @@ struct spi_imx_devtype_data { void (*trigger)(struct spi_imx_data *); int (*rx_available)(struct spi_imx_data *); void (*reset)(struct spi_imx_data *); + unsigned int fifosize; }; struct spi_imx_data { @@ -541,6 +542,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = mx1_trigger, .rx_available = mx1_rx_available, .reset = mx1_reset, + .fifosize = 8, }, #endif #ifdef CONFIG_SPI_IMX_VER_0_0 @@ -550,6 +552,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = mx27_trigger, .rx_available = mx27_rx_available, .reset = spi_imx0_0_reset, + .fifosize = 8, }, #endif #ifdef CONFIG_SPI_IMX_VER_0_4 @@ -559,6 +562,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = mx31_trigger, .rx_available = mx31_rx_available, .reset = spi_imx0_4_reset, + .fifosize = 8, }, #endif #ifdef CONFIG_SPI_IMX_VER_0_7 @@ -568,6 +572,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = mx31_trigger, .rx_available = mx31_rx_available, .reset = spi_imx0_4_reset, + .fifosize = 8, }, #endif #ifdef CONFIG_SPI_IMX_VER_2_3 @@ -577,6 +582,7 @@ static struct spi_imx_devtype_data spi_imx_devtype_data[] __devinitdata = { .trigger = spi_imx2_3_trigger, .rx_available = spi_imx2_3_rx_available, .reset = spi_imx2_3_reset, + .fifosize = 64, }, #endif }; @@ -596,7 +602,7 @@ static void spi_imx_chipselect(struct spi_device *spi, int is_active) static void spi_imx_push(struct spi_imx_data *spi_imx) { - while (spi_imx->txfifo < 8) { + while (spi_imx->txfifo < spi_imx->devtype_data.fifosize) { if (!spi_imx->count) break; spi_imx->tx(spi_imx); -- 1.7.2.3
next prev parent reply other threads:[~2010-10-08 9:24 UTC|newest] Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-09-02 7:51 [PATCH 0/6] add spi support for i.MX51 in the existing spi_imx driver Jason Wang 2010-09-02 7:51 ` Jason Wang 2010-09-02 7:51 ` [PATCH 1/6] spi-imx: add CSPI and eCSPI support for i.MX51 MCU Jason Wang 2010-09-02 7:51 ` Jason Wang 2010-09-02 7:52 ` [PATCH 2/6] i.MX5/clock: add eCSPI and CSPI clock definitions Jason Wang 2010-09-02 7:52 ` Jason Wang 2010-09-02 7:52 ` [PATCH 3/6] mx5: add support to dynamically register spi_imx devices (imx51 3ds) Jason Wang 2010-09-02 7:52 ` Jason Wang 2010-09-02 7:52 ` [PATCH 4/6] mx5/iomux: add iomux definitions for eCSPI2 on the imx51_3ds board Jason Wang 2010-09-02 7:52 ` Jason Wang 2010-09-02 7:52 ` [PATCH 5/6] mx51_3ds: add eCSPI2 support " Jason Wang 2010-09-02 7:52 ` Jason Wang 2010-09-02 7:52 ` [PATCH 6/6] mx51_3ds: add SPI NOR flash in the board init stage Jason Wang 2010-09-02 7:52 ` Jason Wang 2010-09-02 15:05 ` [PATCH 5/6] mx51_3ds: add eCSPI2 support on the imx51_3ds board Uwe Kleine-König 2010-09-02 15:05 ` Uwe Kleine-König 2010-09-03 6:24 ` Jason Wang 2010-09-03 6:24 ` Jason Wang 2010-09-02 15:02 ` [PATCH 3/6] mx5: add support to dynamically register spi_imx devices (imx51 3ds) Uwe Kleine-König 2010-09-02 15:02 ` Uwe Kleine-König 2010-09-03 6:22 ` Jason Wang 2010-09-03 6:22 ` Jason Wang 2010-09-02 15:01 ` [PATCH 2/6] i.MX5/clock: add eCSPI and CSPI clock definitions Uwe Kleine-König 2010-09-02 15:01 ` Uwe Kleine-König 2010-09-03 6:22 ` Jason Wang 2010-09-03 6:22 ` Jason Wang 2010-09-10 9:47 ` Uwe Kleine-König 2010-09-10 9:47 ` Uwe Kleine-König [not found] ` <20100910094714.GF30558-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-09-10 10:04 ` Lothar Waßmann 2010-09-10 10:04 ` Lothar Waßmann 2010-09-13 3:31 ` Jason Wang 2010-09-13 3:31 ` Jason Wang 2010-09-02 14:53 ` [PATCH 1/6] spi-imx: add CSPI and eCSPI support for i.MX51 MCU Uwe Kleine-König 2010-09-02 14:53 ` Uwe Kleine-König 2010-09-02 15:11 ` Lothar Waßmann 2010-09-02 15:11 ` Lothar Waßmann 2010-09-02 17:29 ` Baruch Siach 2010-09-02 17:29 ` Baruch Siach 2010-09-02 17:57 ` Uwe Kleine-König 2010-09-02 17:57 ` Uwe Kleine-König 2010-09-03 8:49 ` Lothar Waßmann 2010-09-03 8:49 ` Lothar Waßmann 2010-09-03 6:16 ` Jason Wang 2010-09-03 6:16 ` Jason Wang 2010-09-03 7:54 ` Uwe Kleine-König 2010-09-03 7:54 ` Uwe Kleine-König 2010-09-02 8:27 ` [PATCH 0/6] add spi support for i.MX51 in the existing spi_imx driver Uwe Kleine-König 2010-09-02 8:27 ` Uwe Kleine-König 2010-09-02 10:07 ` Jason Wang 2010-09-02 10:07 ` Jason Wang 2010-09-02 14:39 ` Uwe Kleine-König 2010-09-02 14:39 ` Uwe Kleine-König 2010-09-02 14:41 ` [PATCH 1/6] ARM: mx51: clean up mx51 header Uwe Kleine-König 2010-09-02 14:41 ` Uwe Kleine-König 2010-09-02 14:41 ` [PATCH 2/6] ARM: mx51: fix naming of spi related defines Uwe Kleine-König 2010-09-02 14:41 ` Uwe Kleine-König 2010-09-02 14:42 ` [PATCH 3/6] ARM: imx: change the way spi-imx devices are registered Uwe Kleine-König 2010-09-02 14:42 ` Uwe Kleine-König 2010-09-02 14:42 ` [PATCH 4/6] ARM: mx51: Add spi clock and spi_imx device registration Uwe Kleine-König 2010-09-02 14:42 ` Uwe Kleine-König [not found] ` <1283438523-19697-4-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-09-03 5:46 ` Jason Wang 2010-09-03 5:46 ` Jason Wang 2010-09-02 14:42 ` [PATCH 5/6] spi-imx: Add i.MX51 support Uwe Kleine-König 2010-09-02 14:42 ` Uwe Kleine-König 2010-09-09 5:33 ` Grant Likely 2010-09-09 5:33 ` Grant Likely 2010-09-09 7:27 ` Uwe Kleine-König 2010-09-09 7:27 ` Uwe Kleine-König 2010-09-02 14:42 ` [PATCH 6/6] ARM: mx5/mx51_babbage: Add spi support Uwe Kleine-König 2010-09-02 14:42 ` Uwe Kleine-König 2010-09-03 3:18 ` [PATCH 0/6] add spi support for i.MX51 in the existing spi_imx driver Jason Wang 2010-09-03 3:18 ` Jason Wang 2010-09-03 6:41 ` Amit Kucheria 2010-09-03 6:41 ` Amit Kucheria 2010-09-03 9:34 ` Robert Schwebel 2010-09-03 9:34 ` Robert Schwebel 2010-09-17 9:52 ` Uwe Kleine-König 2010-09-17 9:52 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 01/16] spi/imx: default to m on platforms that have such devices Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 03/16] spi/imx: get rid of more ifs depending on the used cpu Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 12/16] ARM: mx5/clock-mx51: new macro that defines a clk with all members Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König [not found] ` <20100917095247.GB30441-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-09-17 9:54 ` [PATCH 02/16] spi/imx: convert driver to use platform ids Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 04/16] spi/imx: save the spi chip select in config struct, not the gpio to use Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König [not found] ` <1284717274-12850-4-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-09-17 11:11 ` Lothar Waßmann 2010-09-17 11:11 ` Lothar Waßmann 2010-09-17 11:20 ` Russell King - ARM Linux 2010-09-17 11:20 ` Russell King - ARM Linux 2010-09-19 8:47 ` Jason Wang 2010-09-19 8:47 ` Jason Wang 2010-09-17 9:54 ` [PATCH 05/16] spi/imx: add support for imx51's eCSPI and CSPI Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 06/16] ARM: imx: change the way spi-imx devices are registered Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 07/16] ARM: imx: use platform ids for spi_imx devices Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 08/16] ARM: mx51: clean up mx51 header Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 09/16] ARM: mx51: fix naming of spi related defines Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 10/16] ARM: mx5: add spi_imx device registration Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 11/16] ARM: mx5/clock-mx51: refactor ccgr callbacks to use common code Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 13/16] ARM: mx5/clock-mx51: add spi clocks Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 14/16] ARM: mx5/iomux-mx51: add iomux definitions for eCSPI2 on the imx51_3ds board Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 15/16] ARM: mx5/mx51_3ds: add eCSPI2 support " Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-17 9:54 ` [PATCH 16/16] ARM: mx5/mx51_3ds: add SPI NOR flash in the board init stage Uwe Kleine-König 2010-09-17 9:54 ` Uwe Kleine-König 2010-09-19 8:53 ` [PATCH 0/6] add spi support for i.MX51 in the existing spi_imx driver Jason Wang 2010-09-19 8:53 ` Jason Wang 2010-09-20 15:33 ` Uwe Kleine-König 2010-09-20 15:33 ` Uwe Kleine-König 2010-09-21 1:39 ` Jason Wang 2010-09-21 1:39 ` Jason Wang 2010-09-24 7:00 ` Grant Likely 2010-09-24 7:00 ` Grant Likely 2010-09-24 9:11 ` Uwe Kleine-König 2010-09-24 9:11 ` Uwe Kleine-König 2010-09-24 16:12 ` Grant Likely 2010-09-24 16:12 ` Grant Likely 2010-09-24 18:18 ` Uwe Kleine-König 2010-09-24 18:18 ` Uwe Kleine-König [not found] ` <20100902143908.GK14214-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-10-08 9:24 ` Uwe Kleine-König [this message] 2010-10-08 9:24 ` [PATCH 7/6] spi/imx: Support different fifo sizes Uwe Kleine-König [not found] ` <1286529841-20800-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-10-08 16:39 ` Grant Likely 2010-10-08 16:39 ` Grant Likely
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1286529841-20800-1-git-send-email-u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \ --cc=amit.kucheria-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \ --cc=david-/Q/L1SwJa3aEVqv0pETR8A@public.gmane.org \ --cc=jason77.wang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.