All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/4] drm/i915: Declare waits on GPU as io waits, to reduce C-state reduction.
Date: Mon,  1 Nov 2010 13:23:43 -0700	[thread overview]
Message-ID: <1288643024-5706-4-git-send-email-eric@anholt.net> (raw)
In-Reply-To: <1288643024-5706-1-git-send-email-eric@anholt.net>

Because of this, the C-state governor will consider our process
"performance critical" and avoid dropping CPU power during these
temporary sleeps.  There are two benefits of this: We don't lose our
cache contents (whose value is not well reflected in the metrics of
the governor), and also don't reduce memory bandwidth, which can
reduce GPU performance and increase the time we wait!

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/i915/i915_gem.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 8eb8453..8991588 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1988,12 +1988,12 @@ i915_do_wait_request(struct drm_device *dev, uint32_t seqno,
 		ring->waiting_gem_seqno = seqno;
 		ring->user_irq_get(dev, ring);
 		if (interruptible)
-			ret = wait_event_interruptible(ring->irq_queue,
+			ret = io_wait_event_interruptible(ring->irq_queue,
 				i915_seqno_passed(
 					ring->get_seqno(dev, ring), seqno)
 				|| atomic_read(&dev_priv->mm.wedged));
 		else
-			wait_event(ring->irq_queue,
+			io_wait_event(ring->irq_queue,
 				i915_seqno_passed(
 					ring->get_seqno(dev, ring), seqno)
 				|| atomic_read(&dev_priv->mm.wedged));
-- 
1.7.2.3

  parent reply	other threads:[~2010-11-01 20:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01 20:23 [RFC] Hack to avoid C-state reduction during graphics activity Eric Anholt
2010-11-01 20:23 ` [PATCH 1/4] sched: Export io_schedule_timeout() Eric Anholt
2010-11-01 20:23 ` [PATCH 2/4] Add io_ variants of wait_event() and wait_event_interruptible() Eric Anholt
2010-11-01 20:23 ` Eric Anholt [this message]
2010-11-01 20:23 ` [PATCH 4/4] cpuidle: Hack iowait weighting to avoid C-state reduction for graphics Eric Anholt
2010-11-02 12:20   ` [Intel-gfx] " ykzhao
2010-11-02 15:42     ` Eric Anholt
2010-11-02 20:00       ` [Intel-gfx] " Alexey Fisher
2010-11-02 20:44         ` Chris Wilson
2010-11-01 21:00 ` [RFC] Hack to avoid C-state reduction during graphics activity Andrew Lutomirski
2010-11-01 21:43   ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288643024-5706-4-git-send-email-eric@anholt.net \
    --to=eric@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.