All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@redhat.com>
To: david@fromorbit.com, linux-kernel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com,
	cluster-dev
Subject: [PATCH 5/6] Btrfs: fail if we try to use hole punch
Date: Mon, 15 Nov 2010 12:05:22 -0500	[thread overview]
Message-ID: <1289840723-3056-6-git-send-email-josef@redhat.com> (raw)
In-Reply-To: <1289840723-3056-1-git-send-email-josef@redhat.com>

Btrfs doesn't have the ability to punch holes yet, so make sure we return
EOPNOTSUPP if we try to use hole punching through fallocate.  This support can
be added later.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
---
 fs/btrfs/inode.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 78877d7..6f08892 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6936,6 +6936,10 @@ static long btrfs_fallocate(struct inode *inode, int mode,
 	alloc_start = offset & ~mask;
 	alloc_end =  (offset + len + mask) & ~mask;
 
+	/* We only support the FALLOC_FL_KEEP_SIZE mode */
+	if (mode && (mode != FALLOC_FL_KEEP_SIZE))
+		return -EOPNOTSUPP;
+
 	/*
 	 * wait for ordered IO before we have any locks.  We'll loop again
 	 * below with the locks held.
-- 
1.6.6.1

WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <josef@redhat.com>
To: david@fromorbit.com, linux-kernel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com,
	cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com
Subject: [PATCH 5/6] Btrfs: fail if we try to use hole punch
Date: Mon, 15 Nov 2010 12:05:22 -0500	[thread overview]
Message-ID: <1289840723-3056-6-git-send-email-josef@redhat.com> (raw)
In-Reply-To: <1289840723-3056-1-git-send-email-josef@redhat.com>

Btrfs doesn't have the ability to punch holes yet, so make sure we return
EOPNOTSUPP if we try to use hole punching through fallocate.  This support can
be added later.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
---
 fs/btrfs/inode.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 78877d7..6f08892 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6936,6 +6936,10 @@ static long btrfs_fallocate(struct inode *inode, int mode,
 	alloc_start = offset & ~mask;
 	alloc_end =  (offset + len + mask) & ~mask;
 
+	/* We only support the FALLOC_FL_KEEP_SIZE mode */
+	if (mode && (mode != FALLOC_FL_KEEP_SIZE))
+		return -EOPNOTSUPP;
+
 	/*
 	 * wait for ordered IO before we have any locks.  We'll loop again
 	 * below with the locks held.
-- 
1.6.6.1


WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <josef@redhat.com>
To: david@fromorbit.com, linux-kernel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com,
	cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com
Subject: [PATCH 5/6] Btrfs: fail if we try to use hole punch
Date: Mon, 15 Nov 2010 12:05:22 -0500	[thread overview]
Message-ID: <1289840723-3056-6-git-send-email-josef@redhat.com> (raw)
In-Reply-To: <1289840723-3056-1-git-send-email-josef@redhat.com>

Btrfs doesn't have the ability to punch holes yet, so make sure we return
EOPNOTSUPP if we try to use hole punching through fallocate.  This support can
be added later.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
---
 fs/btrfs/inode.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 78877d7..6f08892 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6936,6 +6936,10 @@ static long btrfs_fallocate(struct inode *inode, int mode,
 	alloc_start = offset & ~mask;
 	alloc_end =  (offset + len + mask) & ~mask;
 
+	/* We only support the FALLOC_FL_KEEP_SIZE mode */
+	if (mode && (mode != FALLOC_FL_KEEP_SIZE))
+		return -EOPNOTSUPP;
+
 	/*
 	 * wait for ordered IO before we have any locks.  We'll loop again
 	 * below with the locks held.
-- 
1.6.6.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <josef@redhat.com>
To: david@fromorbit.com, linux-kernel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com,
	cluster-dev
Subject: [Ocfs2-devel] [PATCH 5/6] Btrfs: fail if we try to use hole punch
Date: Mon, 15 Nov 2010 17:14:54 -0000	[thread overview]
Message-ID: <1289840723-3056-6-git-send-email-josef@redhat.com> (raw)
In-Reply-To: <1289840723-3056-1-git-send-email-josef@redhat.com>

Btrfs doesn't have the ability to punch holes yet, so make sure we return
EOPNOTSUPP if we try to use hole punching through fallocate.  This support can
be added later.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
---
 fs/btrfs/inode.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 78877d7..6f08892 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6936,6 +6936,10 @@ static long btrfs_fallocate(struct inode *inode, int mode,
 	alloc_start = offset & ~mask;
 	alloc_end =  (offset + len + mask) & ~mask;
 
+	/* We only support the FALLOC_FL_KEEP_SIZE mode */
+	if (mode && (mode != FALLOC_FL_KEEP_SIZE))
+		return -EOPNOTSUPP;
+
 	/*
 	 * wait for ordered IO before we have any locks.  We'll loop again
 	 * below with the locks held.
-- 
1.6.6.1

  parent reply	other threads:[~2010-11-15 17:05 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 17:05 Hole Punching V2 Josef Bacik
2010-11-15 17:14 ` [Ocfs2-devel] " Josef Bacik
2010-11-15 17:05 ` Josef Bacik
2010-11-15 17:05 ` Josef Bacik
2010-11-15 17:05 ` [PATCH 1/6] fs: add hole punching to fallocate Josef Bacik
2010-11-15 17:14   ` [Ocfs2-devel] " Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-16 11:16   ` Jan Kara
2010-11-16 11:16     ` [Ocfs2-devel] " Jan Kara
2010-11-16 11:16     ` [Cluster-devel] " Jan Kara
2010-11-16 11:16     ` Jan Kara
2010-11-16 11:43     ` Jan Kara
2010-11-16 11:43       ` [Ocfs2-devel] " Jan Kara
2010-11-16 11:43       ` [Cluster-devel] " Jan Kara
2010-11-16 11:43       ` Jan Kara
2010-11-16 12:52       ` Josef Bacik
2010-11-16 12:53         ` [Ocfs2-devel] " Josef Bacik
2010-11-16 12:52         ` Josef Bacik
2010-11-16 13:14         ` Jan Kara
2010-11-16 13:14           ` [Ocfs2-devel] " Jan Kara
2010-11-16 13:14           ` [Cluster-devel] " Jan Kara
2010-11-16 13:14           ` Jan Kara
2010-11-17  0:22           ` Andreas Dilger
2010-11-17  0:22             ` [Ocfs2-devel] " Andreas Dilger
2010-11-17  0:22             ` Andreas Dilger
2010-11-17  2:11             ` Dave Chinner
2010-11-17  2:12               ` [Ocfs2-devel] " Dave Chinner
2010-11-17  2:11               ` Dave Chinner
2010-11-17  2:28               ` Josef Bacik
2010-11-17  2:29                 ` [Ocfs2-devel] " Josef Bacik
2010-11-17  2:28                 ` Josef Bacik
2010-11-17  2:34                 ` Josef Bacik
2010-11-17  2:35                   ` [Ocfs2-devel] " Josef Bacik
2010-11-17  2:34                   ` Josef Bacik
2010-11-17  9:30                   ` Andreas Dilger
2010-11-17  9:30                     ` [Ocfs2-devel] " Andreas Dilger
2010-11-17  9:30                     ` Andreas Dilger
2010-11-17  9:19               ` Andreas Dilger
2010-11-17  9:19                 ` [Ocfs2-devel] " Andreas Dilger
2010-11-17  9:19                 ` Andreas Dilger
2010-11-16 12:53     ` Josef Bacik
2010-11-16 12:54       ` [Ocfs2-devel] " Josef Bacik
2010-11-16 12:53       ` Josef Bacik
2010-11-15 17:05 ` [PATCH 2/6] XFS: handle hole punching via fallocate properly Josef Bacik
2010-11-15 17:14   ` [Ocfs2-devel] " Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-15 17:05 ` [PATCH 3/6] Ocfs2: " Josef Bacik
2010-11-15 17:14   ` [Ocfs2-devel] " Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-16 11:50   ` Jan Kara
2010-11-16 11:50     ` [Ocfs2-devel] " Jan Kara
2010-11-16 11:50     ` [Cluster-devel] " Jan Kara
2010-11-16 11:50     ` Jan Kara
2010-11-17 23:27   ` Joel Becker
2010-11-17 23:28     ` [Ocfs2-devel] " Joel Becker
2010-11-17 23:27     ` [Cluster-devel] " Joel Becker
2010-11-17 23:27     ` Joel Becker
2010-11-15 17:05 ` [PATCH 4/6] Ext4: fail if we try to use hole punch Josef Bacik
2010-11-15 17:14   ` [Ocfs2-devel] " Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-16 11:52   ` Jan Kara
2010-11-16 11:52     ` [Ocfs2-devel] " Jan Kara
2010-11-16 11:52     ` [Cluster-devel] " Jan Kara
2010-11-16 11:52     ` Jan Kara
2010-11-16 12:25   ` Avi Kivity
2010-11-16 12:25     ` [Ocfs2-devel] " Avi Kivity
2010-11-16 12:25     ` Avi Kivity
2010-11-16 12:50     ` Josef Bacik
2010-11-16 12:50       ` [Ocfs2-devel] " Josef Bacik
2010-11-16 12:50       ` Josef Bacik
2010-11-16 13:07       ` Avi Kivity
2010-11-16 13:07         ` [Ocfs2-devel] " Avi Kivity
2010-11-16 13:07         ` Avi Kivity
2010-11-16 16:05         ` Josef Bacik
2010-11-16 16:06           ` [Ocfs2-devel] " Josef Bacik
2010-11-16 16:05           ` Josef Bacik
2010-11-16 20:47           ` Greg Freemyer
2010-11-16 20:47             ` [Ocfs2-devel] " Greg Freemyer
2010-11-16 20:47             ` Greg Freemyer
2010-11-16 20:47             ` Greg Freemyer
2010-11-16 20:47             ` Greg Freemyer
2010-11-17  3:06         ` Ted Ts'o
2010-11-17  3:06           ` [Ocfs2-devel] " Ted Ts'o
2010-11-17  3:06           ` Ted Ts'o
2010-11-17  6:31           ` Josef Bacik
2010-11-17  6:32             ` [Ocfs2-devel] " Josef Bacik
2010-11-17  6:31             ` Josef Bacik
2010-11-17  6:31             ` Josef Bacik
2010-11-17  6:31           ` Josef Bacik
2010-11-16 16:20   ` Pádraig Brady
2010-11-16 16:21     ` [Ocfs2-devel] " Pádraig Brady
2010-11-16 16:20     ` Pádraig Brady
2010-11-16 16:20     ` Pádraig Brady
2010-11-16 16:33     ` Josef Bacik
2010-11-16 16:33       ` [Ocfs2-devel] " Josef Bacik
2010-11-16 16:33       ` Josef Bacik
2010-11-16 16:33       ` Josef Bacik
2010-11-16 16:56       ` Pádraig Brady
2010-11-15 17:05 ` Josef Bacik [this message]
2010-11-15 17:14   ` [Ocfs2-devel] [PATCH 5/6] Btrfs: " Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-15 17:05 ` [PATCH 6/6] Gfs2: " Josef Bacik
2010-11-15 17:14   ` [Ocfs2-devel] " Josef Bacik
2010-11-15 17:05   ` Josef Bacik
2010-11-15 17:05   ` Josef Bacik
  -- strict thread matches above, loose matches on Subject: below --
2010-11-18  1:46 Hole Punching V3 Josef Bacik
2010-11-18  1:46 ` [PATCH 5/6] Btrfs: fail if we try to use hole punch Josef Bacik
2010-11-18  1:46   ` Josef Bacik
2010-11-18  1:46   ` Josef Bacik
2010-11-08 20:32 [PATCH 1/6] fs: add hole punching to fallocate Josef Bacik
2010-11-08 20:32 ` [PATCH 5/6] Btrfs: fail if we try to use hole punch Josef Bacik
2010-11-08 20:32   ` Josef Bacik
2010-11-08 20:32   ` Josef Bacik
2010-11-09 10:05   ` Will Newton
2010-11-09 10:05     ` Will Newton
2010-11-09 10:05     ` Will Newton
2010-11-09 10:05     ` Will Newton
2010-11-09 12:53     ` Josef Bacik
2010-11-09 12:53       ` Josef Bacik
2010-11-09 12:53       ` Josef Bacik
2010-11-09 12:53       ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289840723-3056-6-git-send-email-josef@redhat.com \
    --to=josef@redhat.com \
    --cc=cmm@us.ibm.com \
    --cc=david@fromorbit.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.