From: "Henrik Rydberg" <rydberg@euromail.se>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Henrik Rydberg <rydberg@euromail.se>
Subject: [PATCH] input: mt: Identify pointer emulation contact
Date: Fri, 10 Dec 2010 00:19:05 +0100 [thread overview]
Message-ID: <1291936745-4973-1-git-send-email-rydberg@euromail.se> (raw)
For MT applications, the tracking id provides a robust way to know
when a touch is new; essential information to determine when _not_ to
emit motion events, for instance. Currently, ST applications do not
have the equivalent information, but instead rely on global properties
such as a change in number of fingers. Moreover, some MT applications
need to know which contact correponds to the pointer. This patch adds
the ABS_TRACKING_ID axis and emits it in
input_mt_report_pointer_emulation(), provided the proper absbit is
setup by the driver.
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
drivers/input/input-mt.c | 4 +++-
include/linux/input.h | 1 +
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c
index afaf059..bcd2c22 100644
--- a/drivers/input/input-mt.c
+++ b/drivers/input/input-mt.c
@@ -105,7 +105,8 @@ EXPORT_SYMBOL(input_mt_report_slot_state);
* @dev: input device with allocated MT slots
*
* Performs legacy pointer emulation via BTN_TOUCH, ABS_X, ABS_Y and
- * ABS_PRESSURE. Touchpad finger count is emulated using
+ * ABS_PRESSURE. If enabled, ABS_TRACKING_ID is emitted whenever the
+ * pointer contact changes. Touchpad finger count is emulated using
* BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP, BTN_TOOL_TRIPLETAP and
* BTN_TOOL_QUADTAP.
*
@@ -146,6 +147,7 @@ void input_mt_report_pointer_emulation(struct input_dev *dev)
input_event(dev, EV_ABS, ABS_X, x);
input_event(dev, EV_ABS, ABS_Y, y);
input_event(dev, EV_ABS, ABS_PRESSURE, p);
+ input_event(dev, EV_ABS, ABS_TRACKING_ID, oldid);
} else {
input_event(dev, EV_ABS, ABS_PRESSURE, 0);
}
diff --git a/include/linux/input.h b/include/linux/input.h
index 65f7799..01dde9b 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -716,6 +716,7 @@ struct input_keymap_entry {
#define ABS_TILT_X 0x1a
#define ABS_TILT_Y 0x1b
#define ABS_TOOL_WIDTH 0x1c
+#define ABS_TRACKING_ID 0x1d /* ID of contact governing ABS_{X,Y} */
#define ABS_VOLUME 0x20
--
1.7.1
next reply other threads:[~2010-12-09 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 23:19 Henrik Rydberg [this message]
2010-12-09 23:49 ` [PATCH] input: mt: Identify pointer emulation contact Dmitry Torokhov
2010-12-10 7:28 ` Henrik Rydberg
2010-12-10 15:11 ` Chris Bagwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291936745-4973-1-git-send-email-rydberg@euromail.se \
--to=rydberg@euromail.se \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.