All of lore.kernel.org
 help / color / mirror / Atom feed
From: andros@netapp.com
To: trond.myklebust@netapp.com
Cc: bfields@redhat.com, linux-nfs@vger.kernel.org,
	Andy Adamson <andros@netapp.com>
Subject: [PATCH_V5 06/11] NFS implement v4.0 callback_ident
Date: Mon, 20 Dec 2010 16:04:43 -0500	[thread overview]
Message-ID: <1292879088-7821-7-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1292879088-7821-6-git-send-email-andros@netapp.com>

From: Andy Adamson <andros@netapp.com>

Provide a unique callback identifier per SETCLIENTID call used to identify the
v4.0 callback service associated with the clientid.

Do not worry about wrap around. Zero value means unset.

Signed-off-by: Andy Adamson <andros@netapp.com>
---
 fs/nfs/nfs4proc.c         |    5 +++++
 fs/nfs/nfs4state.c        |    1 +
 include/linux/nfs_fs_sb.h |    1 +
 include/linux/nfs_xdr.h   |    1 +
 4 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 4435e5e..ab5a2c4 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -3470,6 +3470,8 @@ do_state_recovery:
 	return -EAGAIN;
 }
 
+static u32 current_cb_ident = 1;
+
 int nfs4_proc_setclientid(struct nfs_client *clp, u32 program,
 		unsigned short port, struct rpc_cred *cred,
 		struct nfs4_setclientid_res *res)
@@ -3478,6 +3480,7 @@ int nfs4_proc_setclientid(struct nfs_client *clp, u32 program,
 	struct nfs4_setclientid setclientid = {
 		.sc_verifier = &sc_verifier,
 		.sc_prog = program,
+		.sc_cb_ident = current_cb_ident++,
 	};
 	struct rpc_message msg = {
 		.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_SETCLIENTID],
@@ -3522,6 +3525,8 @@ int nfs4_proc_setclientid(struct nfs_client *clp, u32 program,
 			if (++clp->cl_id_uniquifier == 0)
 				break;
 	}
+	if (status == NFS_OK)
+		res->cb_ident = setclientid.sc_cb_ident;
 	return status;
 }
 
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index f575a31..fe61422 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -79,6 +79,7 @@ int nfs4_init_clientid(struct nfs_client *clp, struct rpc_cred *cred)
 	if (status != 0)
 		goto out;
 	clp->cl_clientid = clid.clientid;
+	clp->cl_cb_ident = clid.cb_ident;
 	nfs4_schedule_state_renewal(clp);
 out:
 	return status;
diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h
index 452d964..1eaa054 100644
--- a/include/linux/nfs_fs_sb.h
+++ b/include/linux/nfs_fs_sb.h
@@ -71,6 +71,7 @@ struct nfs_client {
 	 */
 	char			cl_ipaddr[48];
 	unsigned char		cl_id_uniquifier;
+	u32			cl_cb_ident;	/* v4.0 callback identifier */
 	const struct nfs4_minor_version_ops *cl_mvops;
 #endif /* CONFIG_NFS_V4 */
 
diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
index 80f0719..24e77a6 100644
--- a/include/linux/nfs_xdr.h
+++ b/include/linux/nfs_xdr.h
@@ -868,6 +868,7 @@ struct nfs4_setclientid {
 struct nfs4_setclientid_res {
 	u64				clientid;
 	nfs4_verifier			confirm;
+	u32				cb_ident;
 };
 
 struct nfs4_statfs_arg {
-- 
1.6.6


  reply	other threads:[~2010-12-20 22:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 21:04 [PATCH_V5 0/11] NFSv4 callback find client fix Version 5 andros
2010-12-20 21:04 ` [PATCH_V5 01/11] SUNRPC move svc_drop to caller of svc_process_common andros
2010-12-20 21:04   ` [PATCH_V5 02/11] SUNRPC fix bc_send print andros
2010-12-20 21:04     ` [PATCH_V5 03/11] SUNRPC new transport for the NFSv4.1 shared back channel andros
2010-12-20 21:04       ` [PATCH_V5 04/11] NFS use svc_create_xprt for NFSv4.1 callback service andros
2010-12-20 21:04         ` [PATCH_V5 05/11] NFS do not clear minor version at nfs_client free andros
2010-12-20 21:04           ` andros [this message]
2010-12-20 21:04             ` [PATCH_V5 07/11] NFS associate sessionid with callback connection andros
2010-12-20 21:04               ` [PATCH_V5 08/11] NFS reference nfs_client across cb_compound processing andros
2010-12-20 21:04                 ` [PATCH_V5 09/11] NFS RPC_AUTH_GSS unsupported on v4.1 back channel andros
2010-12-20 21:04                   ` [PATCH_V5 10/11] NFS add session back channel draining andros
2010-12-20 21:04                     ` [PATCH_V5 11/11] NFS rename client back channel transport field andros
2010-12-22 22:27                   ` [PATCH_V5 09/11] NFS RPC_AUTH_GSS unsupported on v4.1 back channel J. Bruce Fields
2010-12-22 22:26                 ` [PATCH_V5 08/11] NFS reference nfs_client across cb_compound processing J. Bruce Fields
2010-12-22 22:24       ` [PATCH_V5 03/11] SUNRPC new transport for the NFSv4.1 shared back channel J. Bruce Fields
2010-12-24 17:43         ` J. Bruce Fields
2010-12-21 18:23   ` [PATCH_V5 01/11] SUNRPC move svc_drop to caller of svc_process_common J. Bruce Fields
2010-12-22 22:00     ` Andy Adamson
2010-12-22 22:18       ` J. Bruce Fields
2010-12-24  3:43     ` Labiaga, Ricardo
2010-12-24 17:01       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292879088-7821-7-git-send-email-andros@netapp.com \
    --to=andros@netapp.com \
    --cc=bfields@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.