From: Dave Airlie <airlied@gmail.com> To: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.sf.net, linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com> Subject: [PATCH 1/3] fb: fix overlapping test off-by-one. Date: Tue, 21 Dec 2010 11:41:15 +1000 [thread overview] Message-ID: <1292895677-4242-2-git-send-email-airlied@gmail.com> (raw) In-Reply-To: <1292895677-4242-1-git-send-email-airlied@gmail.com> From: Dave Airlie <airlied@redhat.com> On my system with a radeon x2, the first GPU was not overlapping vesa but the test decided it was. Signed-off-by: Dave Airlie <airlied@redhat.com> --- drivers/video/fbmem.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c index 0e6aa3d..4ac1201 100644 --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c @@ -1458,7 +1458,7 @@ static bool apertures_overlap(struct aperture *gen, struct aperture *hw) if (gen->base == hw->base) return true; /* is the generic aperture base inside the hw base->hw base+size */ - if (gen->base > hw->base && gen->base <= hw->base + hw->size) + if (gen->base > hw->base && gen->base < hw->base + hw->size) return true; return false; } -- 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Dave Airlie <airlied@gmail.com> To: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.sf.net, linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com> Subject: [PATCH 1/3] fb: fix overlapping test off-by-one. Date: Tue, 21 Dec 2010 01:41:15 +0000 [thread overview] Message-ID: <1292895677-4242-2-git-send-email-airlied@gmail.com> (raw) In-Reply-To: <1292895677-4242-1-git-send-email-airlied@gmail.com> From: Dave Airlie <airlied@redhat.com> On my system with a radeon x2, the first GPU was not overlapping vesa but the test decided it was. Signed-off-by: Dave Airlie <airlied@redhat.com> --- drivers/video/fbmem.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c index 0e6aa3d..4ac1201 100644 --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c @@ -1458,7 +1458,7 @@ static bool apertures_overlap(struct aperture *gen, struct aperture *hw) if (gen->base = hw->base) return true; /* is the generic aperture base inside the hw base->hw base+size */ - if (gen->base > hw->base && gen->base <= hw->base + hw->size) + if (gen->base > hw->base && gen->base < hw->base + hw->size) return true; return false; } -- 1.7.1
next prev parent reply other threads:[~2010-12-21 1:41 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-12-21 1:41 vt/fbcon binding and handover fixes Dave Airlie 2010-12-21 1:41 ` Dave Airlie 2010-12-21 1:41 ` [PATCH 1/3] fb: fix overlapping test off-by-one Dave Airlie 2010-12-21 1:41 ` Dave Airlie 2010-12-21 1:41 ` Dave Airlie [this message] 2010-12-21 1:41 ` Dave Airlie 2010-12-21 7:29 ` Michel Dänzer 2010-12-21 7:29 ` Michel Dänzer 2010-12-21 7:29 ` Michel Dänzer 2010-12-21 7:29 ` Michel Dänzer 2010-12-24 3:28 ` Paul Mundt 2010-12-24 3:28 ` Paul Mundt 2010-12-24 3:28 ` Paul Mundt 2010-12-24 3:28 ` Paul Mundt 2010-12-23 16:40 ` [PATCH] Update fbdev fb_fix_screeninfo James Simmons 2010-12-21 1:41 ` [PATCH 2/3] vt: fix issue when fbcon wants to takeover a second time Dave Airlie 2010-12-21 1:41 ` Dave Airlie 2010-12-21 1:41 ` Dave Airlie 2010-12-21 1:41 ` Dave Airlie 2011-01-06 23:57 ` Dave Airlie 2011-01-07 0:50 ` Greg KH 2011-01-07 0:52 ` Dave Airlie 2010-12-21 1:41 ` [PATCH 3/3] fbcon: fix situation where fbcon gets deinitialised and can't reinit Dave Airlie 2010-12-21 1:41 ` Dave Airlie 2010-12-21 1:41 ` Dave Airlie 2010-12-24 3:30 ` Paul Mundt 2010-12-24 3:30 ` Paul Mundt 2010-12-24 3:30 ` Paul Mundt 2010-12-24 3:30 ` Paul Mundt 2010-12-21 1:41 ` Dave Airlie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1292895677-4242-2-git-send-email-airlied@gmail.com \ --to=airlied@gmail.com \ --cc=airlied@redhat.com \ --cc=dri-devel@lists.sf.net \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.