All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Tony <tony@atomide.com>
Cc: l-o <linux-omap@vger.kernel.org>,
	l-a <linux-arm-kernel@lists.infradead.org>,
	Nishanth Menon <nm@ti.com>
Subject: [PATCH 2/2] OMAP2+: TWL: include pm header for init protos
Date: Mon,  3 Jan 2011 12:58:30 -0600	[thread overview]
Message-ID: <1294081110-23695-3-git-send-email-nm@ti.com> (raw)
In-Reply-To: <1294081110-23695-1-git-send-email-nm@ti.com>

twl_init functions are declared in pm.h and used in pm.c
pm.h header defining the protos need to be included to
ensure that omap_twl.c has consistent function definition.
This fixes sparse warning:
arch/arm/mach-omap2/omap_twl.c:237:12: warning: symbol 'omap4_twl_init' was not declared. Should it be static?
arch/arm/mach-omap2/omap_twl.c:256:12: warning: symbol 'omap3_twl_init' was not declared. Should it be static?

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/mach-omap2/omap_twl.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
index 65ab4e3..00e1d2b 100644
--- a/arch/arm/mach-omap2/omap_twl.c
+++ b/arch/arm/mach-omap2/omap_twl.c
@@ -20,6 +20,8 @@
 
 #include <plat/voltage.h>
 
+#include "pm.h"
+
 #define OMAP3_SRI2C_SLAVE_ADDR		0x12
 #define OMAP3_VDD_MPU_SR_CONTROL_REG	0x00
 #define OMAP3_VDD_CORE_SR_CONTROL_REG	0x01
-- 
1.6.3.3


WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] OMAP2+: TWL: include pm header for init protos
Date: Mon,  3 Jan 2011 12:58:30 -0600	[thread overview]
Message-ID: <1294081110-23695-3-git-send-email-nm@ti.com> (raw)
In-Reply-To: <1294081110-23695-1-git-send-email-nm@ti.com>

twl_init functions are declared in pm.h and used in pm.c
pm.h header defining the protos need to be included to
ensure that omap_twl.c has consistent function definition.
This fixes sparse warning:
arch/arm/mach-omap2/omap_twl.c:237:12: warning: symbol 'omap4_twl_init' was not declared. Should it be static?
arch/arm/mach-omap2/omap_twl.c:256:12: warning: symbol 'omap3_twl_init' was not declared. Should it be static?

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/mach-omap2/omap_twl.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
index 65ab4e3..00e1d2b 100644
--- a/arch/arm/mach-omap2/omap_twl.c
+++ b/arch/arm/mach-omap2/omap_twl.c
@@ -20,6 +20,8 @@
 
 #include <plat/voltage.h>
 
+#include "pm.h"
+
 #define OMAP3_SRI2C_SLAVE_ADDR		0x12
 #define OMAP3_VDD_MPU_SR_CONTROL_REG	0x00
 #define OMAP3_VDD_CORE_SR_CONTROL_REG	0x01
-- 
1.6.3.3

  parent reply	other threads:[~2011-01-03 18:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-03 18:58 [PATCH 0/2] OMAP: TWL: sparse fixes Nishanth Menon
2011-01-03 18:58 ` Nishanth Menon
2011-01-03 18:58 ` [PATCH 1/2] OMAP2+: TWL: make conversion routines static Nishanth Menon
2011-01-03 18:58   ` Nishanth Menon
2011-01-03 18:58 ` Nishanth Menon [this message]
2011-01-03 18:58   ` [PATCH 2/2] OMAP2+: TWL: include pm header for init protos Nishanth Menon
2011-01-03 22:36 ` [PATCH 0/2] OMAP: TWL: sparse fixes Russell King - ARM Linux
2011-01-03 22:36   ` Russell King - ARM Linux
2011-01-03 22:39   ` Nishanth Menon
2011-01-03 22:39     ` Nishanth Menon
2011-01-04 20:37     ` Nishanth Menon
2011-01-04 20:37       ` Nishanth Menon
2011-01-05  0:25       ` Russell King - ARM Linux
2011-01-05  0:25         ` Russell King - ARM Linux
2011-01-05 13:32         ` Nishanth Menon
2011-01-05 13:32           ` Nishanth Menon
2011-01-04 18:00 ` Kevin Hilman
2011-01-04 18:00   ` Kevin Hilman
2011-01-04 22:44   ` Kevin Hilman
2011-01-04 22:44     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294081110-23695-3-git-send-email-nm@ti.com \
    --to=nm@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.