All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sourav Poddar <sourav.poddar@ti.com>
To: LW@karo-electronics.de
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org, gadiyar@ti.com, charu@ti.com,
	grinberg@compulab.co.il, balbi@ti.com,
	Sourav Poddar <sourav.poddar@ti.com>,
	Dmitry Torokhov <dtor@mail.ru>
Subject: [PATCH v3 2/2] Input: ads7846: use gpio_request_one to configure pendown_gpio
Date: Thu,  3 Feb 2011 20:51:46 +0530	[thread overview]
Message-ID: <1296746506-12221-1-git-send-email-sourav.poddar@ti.com> (raw)

The ads7846 driver requests a gpio but does not currently
configure it explicitly as an input. Use gpio_request_one
to request and configure it at one shot.

Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
Cc: Dmitry Torokhov <dtor@mail.ru>

---
 Links related to the previous discussions:
 http://permalink.gmane.org/gmane.linux.ports.arm.omap/51300

 drivers/input/touchscreen/ads7846.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index ce5baee..7480460 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -956,7 +956,8 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784
 		return 0;
 	}
 
-	err = gpio_request(pdata->gpio_pendown, "ads7846_pendown");
+	err = gpio_request_one(pdata->gpio_pendown, GPIOF_DIR_IN,
+						"ads7846_pendown");
 	if (err) {
 		dev_err(&spi->dev, "failed to request pendown GPIO%d\n",
 			pdata->gpio_pendown);
-- 
1.7.0.4


WARNING: multiple messages have this Message-ID (diff)
From: sourav.poddar@ti.com (Sourav Poddar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] Input: ads7846: use gpio_request_one to configure pendown_gpio
Date: Thu,  3 Feb 2011 20:51:46 +0530	[thread overview]
Message-ID: <1296746506-12221-1-git-send-email-sourav.poddar@ti.com> (raw)

The ads7846 driver requests a gpio but does not currently
configure it explicitly as an input. Use gpio_request_one
to request and configure it at one shot.

Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
Cc: Dmitry Torokhov <dtor@mail.ru>

---
 Links related to the previous discussions:
 http://permalink.gmane.org/gmane.linux.ports.arm.omap/51300

 drivers/input/touchscreen/ads7846.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index ce5baee..7480460 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -956,7 +956,8 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784
 		return 0;
 	}
 
-	err = gpio_request(pdata->gpio_pendown, "ads7846_pendown");
+	err = gpio_request_one(pdata->gpio_pendown, GPIOF_DIR_IN,
+						"ads7846_pendown");
 	if (err) {
 		dev_err(&spi->dev, "failed to request pendown GPIO%d\n",
 			pdata->gpio_pendown);
-- 
1.7.0.4

             reply	other threads:[~2011-02-03 15:22 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 15:21 Sourav Poddar [this message]
2011-02-03 15:21 ` [PATCH v3 2/2] Input: ads7846: use gpio_request_one to configure pendown_gpio Sourav Poddar
2011-02-03 16:54 ` Dmitry Torokhov
2011-02-03 16:54   ` Dmitry Torokhov
2011-02-03 17:19   ` Dmitry Torokhov
2011-02-03 17:19     ` Dmitry Torokhov
2011-02-03 22:12     ` Wolfram Sang
2011-02-03 22:12       ` Wolfram Sang
2011-02-04  8:05     ` Varadarajan, Charulatha
2011-02-04  8:05       ` Varadarajan, Charulatha
2011-02-04 12:59     ` Poddar, Sourav
2011-02-04 12:59       ` Poddar, Sourav
2011-02-04 13:32     ` G, Manjunath Kondaiah
2011-02-04 13:32       ` G, Manjunath Kondaiah
2011-02-04 13:37       ` Kishore Kadiyala
2011-02-04 13:37         ` Kishore Kadiyala
2011-02-04 13:41         ` G, Manjunath Kondaiah
2011-02-04 13:41           ` G, Manjunath Kondaiah
2011-02-04 14:08       ` Wolfram Sang
2011-02-04 14:08         ` Wolfram Sang
2011-02-04 14:16         ` G, Manjunath Kondaiah
2011-02-04 14:16           ` G, Manjunath Kondaiah
2011-02-04 14:47           ` Igor Grinberg
2011-02-04 14:47             ` Igor Grinberg
2011-02-04 15:11             ` Poddar, Sourav
2011-02-04 15:11               ` Poddar, Sourav
2011-02-04 15:30               ` Igor Grinberg
2011-02-04 15:30                 ` Igor Grinberg
2011-02-05  6:59                 ` Poddar, Sourav
2011-02-05  6:59                   ` Poddar, Sourav
2011-02-06  7:31                   ` Igor Grinberg
2011-02-06  7:31                     ` Igor Grinberg
2011-02-04 15:15             ` G, Manjunath Kondaiah
2011-02-04 15:15               ` G, Manjunath Kondaiah
2011-02-04 15:37               ` Igor Grinberg
2011-02-04 15:37                 ` Igor Grinberg
2011-02-04 16:09                 ` Dmitry Torokhov
2011-02-04 16:09                   ` Dmitry Torokhov
2011-02-04 14:54           ` Wolfram Sang
2011-02-04 14:54             ` Wolfram Sang
2011-02-04 15:13     ` Igor Grinberg
2011-02-04 15:13       ` Igor Grinberg
2011-02-03 17:05 ` Wolfram Sang
2011-02-03 17:05   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296746506-12221-1-git-send-email-sourav.poddar@ti.com \
    --to=sourav.poddar@ti.com \
    --cc=LW@karo-electronics.de \
    --cc=balbi@ti.com \
    --cc=charu@ti.com \
    --cc=dtor@mail.ru \
    --cc=gadiyar@ti.com \
    --cc=grinberg@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.