All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lesly A M <leslyam@ti.com>
To: linux-omap@vger.kernel.org
Cc: Lesly A M <leslyam@ti.com>, Nishanth Menon <nm@ti.com>,
	David Derrick <dderrick@ti.com>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: [PATCH 1/8] omap3: pm: Fix for the TRITON sleep/wakeup sequence
Date: Sat, 26 Feb 2011 17:55:32 +0530	[thread overview]
Message-ID: <1298723139-1693-2-git-send-email-leslyam@ti.com> (raw)
In-Reply-To: <1298723139-1693-1-git-send-email-leslyam@ti.com>

Since the function to populate the sleep script is getting called always
irrespective of the flag "TWL4030_SLEEP_SCRIPT", other scripts data
is getting over written by the sleep script. Adding the missing brackets for
if statement to fix the issue.

Signed-off-by: Lesly A M <leslyam@ti.com>
Cc: Nishanth Menon <nm@ti.com>
Cc: David Derrick <dderrick@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
 drivers/mfd/twl4030-power.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index 16422de..2c0d4d1 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -447,12 +447,13 @@ static int __init load_twl4030_script(struct twl4030_script *tscript,
 		if (err)
 			goto out;
 	}
-	if (tscript->flags & TWL4030_SLEEP_SCRIPT)
+	if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
 		if (order)
 			pr_warning("TWL4030: Bad order of scripts (sleep "\
 					"script before wakeup) Leads to boot"\
 					"failure on some boards\n");
 		err = twl4030_config_sleep_sequence(address);
+	}
 out:
 	return err;
 }
-- 
1.7.0.4


  reply	other threads:[~2011-02-26 12:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-26 12:25 [PATCH v7 0/8] omap3: pm: TWL4030 power scripts and workaround for TWL errata 27 Lesly A M
2011-02-26 12:25 ` Lesly A M [this message]
2011-03-01 22:33   ` [PATCH 1/8] omap3: pm: Fix for the TRITON sleep/wakeup sequence Kevin Hilman
2011-03-02  6:08     ` Manuel, Lesly Arackal
2011-02-26 12:25 ` [PATCH 2/8] omap3: pm: Correct the warning print during script loading Lesly A M
2011-02-26 12:25 ` [PATCH 3/8] omap3: pm: Correcting the sys_offmode signal polarity Lesly A M
2011-03-01 22:35   ` Kevin Hilman
2011-03-02  6:11     ` Manuel, Lesly Arackal
2011-02-26 12:25 ` [PATCH 4/8] omap3: pm: TWL4030 power scripts for OMAP3 boards Lesly A M
2011-02-26 12:25 ` [PATCH 5/8] omap3: pm: TWL5030 version checking Lesly A M
2011-02-28  7:24   ` Krishnamoorthy, Balaji T
2011-02-28 11:04     ` Manuel, Lesly Arackal
2011-02-28 11:24       ` Krishnamoorthy, Balaji T
2011-02-26 12:25 ` [PATCH 6/8] mfd: TWL4030: changes for TRITON Errata 27 workaround Lesly A M
2011-02-26 12:25 ` [PATCH 7/8] omap3430: Updating the board file to use TWL4030 scripts Lesly A M
2011-02-26 12:25 ` [PATCH 8/8] omap3630: " Lesly A M
2011-03-01 22:31 ` [PATCH v7 0/8] omap3: pm: TWL4030 power scripts and workaround for TWL errata 27 Kevin Hilman
2011-03-02  5:57   ` Manuel, Lesly Arackal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298723139-1693-2-git-send-email-leslyam@ti.com \
    --to=leslyam@ti.com \
    --cc=dderrick@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.