All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sage Weil <sage@newdream.net>
To: ceph-devel@vger.kernel.org
Cc: Sage Weil <sage@newdream.net>
Subject: [PATCH 2/8] ceph: do not set I_COMPLETE
Date: Thu,  3 Mar 2011 12:40:04 -0800	[thread overview]
Message-ID: <1299184810-19125-3-git-send-email-sage@newdream.net> (raw)
In-Reply-To: <1299184810-19125-1-git-send-email-sage@newdream.net>

Do not set the I_COMPLETE flag on directories until we resolve races with
dcache pruning.

Signed-off-by: Sage Weil <sage@newdream.net>
---
 fs/ceph/dir.c   |    2 +-
 fs/ceph/inode.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
index 0bc68de..9b4f9d9 100644
--- a/fs/ceph/dir.c
+++ b/fs/ceph/dir.c
@@ -409,7 +409,7 @@ more:
 	spin_lock(&inode->i_lock);
 	if (ci->i_release_count == fi->dir_release_count) {
 		dout(" marking %p complete\n", inode);
-		ci->i_ceph_flags |= CEPH_I_COMPLETE;
+		/* ci->i_ceph_flags |= CEPH_I_COMPLETE; */
 		ci->i_max_offset = filp->f_pos;
 	}
 	spin_unlock(&inode->i_lock);
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index 5625463..193bfa5 100644
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -707,7 +707,7 @@ static int fill_inode(struct inode *inode,
 		    (issued & CEPH_CAP_FILE_EXCL) == 0 &&
 		    (ci->i_ceph_flags & CEPH_I_COMPLETE) == 0) {
 			dout(" marking %p complete (empty)\n", inode);
-			ci->i_ceph_flags |= CEPH_I_COMPLETE;
+			/* ci->i_ceph_flags |= CEPH_I_COMPLETE; */
 			ci->i_max_offset = 2;
 		}
 		break;
-- 
1.7.0


  parent reply	other threads:[~2011-03-03 20:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 20:40 Queue for 2.6.38 Sage Weil
2011-03-03 20:40 ` [PATCH 1/8] Revert "ceph: keep reference to parent inode on ceph_dentry" Sage Weil
2011-03-03 20:40 ` Sage Weil [this message]
2011-03-03 20:40 ` [PATCH 3/8] ceph: do not clear I_COMPLETE from d_release Sage Weil
2011-03-03 20:40 ` [PATCH 4/8] libceph: fix handling of short returns from get_user_pages Sage Weil
2011-03-03 20:40 ` [PATCH 5/8] libceph: retry after authorization failure Sage Weil
2011-03-03 20:40 ` [PATCH 6/8] libceph: fix msgr backoff Sage Weil
2011-03-03 20:40 ` [PATCH 7/8] libceph: fix msgr keepalive flag Sage Weil
2011-03-03 20:40 ` [PATCH 8/8] libceph: fix msgr standby handling Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299184810-19125-3-git-send-email-sage@newdream.net \
    --to=sage@newdream.net \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.