All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Andy Whitcroft <apw@canonical.com>
Subject: [PATCH 4/4] drm/i915: Prevent fence-reuse stalls
Date: Fri, 18 Mar 2011 22:35:19 +0000	[thread overview]
Message-ID: <1300487719-26578-5-git-send-email-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <1300487719-26578-1-git-send-email-chris@chris-wilson.co.uk>

With the last bug preventing fence pipelining fixed (or at least the
last known bug), re-enable pipelining to avoid stalling on fence
acquisition between batches.

Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 2dbf8f7..78dba7a 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2575,9 +2575,6 @@ i915_gem_object_get_fence(struct drm_i915_gem_object *obj,
 	struct drm_i915_fence_reg *reg;
 	int ret;
 
-	/* XXX disable pipelining. There are bugs. Shocking. */
-	pipelined = NULL;
-
 	/* Just update our place in the LRU if our fence is getting reused. */
 	if (obj->fence_reg != I915_FENCE_REG_NONE) {
 		reg = &dev_priv->fence_regs[obj->fence_reg];
-- 
1.7.2.3

  parent reply	other threads:[~2011-03-18 22:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18 22:35 Pipelined fence fixes Chris Wilson
2011-03-18 22:35 ` [PATCH 1/4] drm/i915: Track fence setup separately from fenced object lifetime Chris Wilson
2011-03-19 22:35   ` Daniel Vetter
2011-03-19 22:42     ` Chris Wilson
2011-03-19 23:11       ` Daniel Vetter
2011-03-18 22:35 ` [PATCH 2/4] drm/i915: Invalidate fenced read domains upon flush Chris Wilson
2011-03-19 22:49   ` Daniel Vetter
2011-03-18 22:35 ` [PATCH 3/4] drm/i915: Cleanup handling of last_fenced_seqno Chris Wilson
2011-03-19 22:55   ` Daniel Vetter
2011-03-19 23:09     ` Chris Wilson
2011-03-18 22:35 ` Chris Wilson [this message]
2011-03-19 22:57   ` [PATCH 4/4] drm/i915: Prevent fence-reuse stalls Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300487719-26578-5-git-send-email-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=apw@canonical.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.