From: Chris Wilson <chris@chris-wilson.co.uk> To: Alessandro Suardi <alessandro.suardi@gmail.com> Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, Chris Wilson <chris@chris-wilson.co.uk> Subject: [PATCH] drm/i915/lvds: Always return connected in the absence of better information Date: Thu, 24 Mar 2011 13:30:44 +0000 [thread overview] Message-ID: <1300973444-6084-1-git-send-email-chris@chris-wilson.co.uk> (raw) In-Reply-To: <AANLkTikY23FxMVtqTNra05O3CxXZQ5=bvmppTiySHNq=@mail.gmail.com> The LVDS connector should default to connected. We tried our best to verify the claims of the BIOS that the hardware exists during init(), and then during detect() we then try to verify that the panel is open. In the event of an unsucessful query, we should then always report that the LVDS panel is connected. This was only the case for gen3/4, later generations leaked the return value from the panel probe instead. Reported-by: Alessandro Suardi <alessandro.suardi@gmail.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/intel_lvds.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index 1a311ad..86cd30b 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -473,19 +473,13 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connector, bool force) { struct drm_device *dev = connector->dev; - enum drm_connector_status status = connector_status_connected; + enum drm_connector_status status; status = intel_panel_detect(dev); if (status != connector_status_unknown) return status; - /* ACPI lid methods were generally unreliable in this generation, so - * don't even bother. - */ - if (IS_GEN2(dev) || IS_GEN3(dev)) - return connector_status_connected; - - return status; + return connector_status_connected; } /** -- 1.7.4.1
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk> To: Alessandro Suardi <alessandro.suardi@gmail.com> Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/i915/lvds: Always return connected in the absence of better information Date: Thu, 24 Mar 2011 13:30:44 +0000 [thread overview] Message-ID: <1300973444-6084-1-git-send-email-chris@chris-wilson.co.uk> (raw) In-Reply-To: <AANLkTikY23FxMVtqTNra05O3CxXZQ5=bvmppTiySHNq=@mail.gmail.com> The LVDS connector should default to connected. We tried our best to verify the claims of the BIOS that the hardware exists during init(), and then during detect() we then try to verify that the panel is open. In the event of an unsucessful query, we should then always report that the LVDS panel is connected. This was only the case for gen3/4, later generations leaked the return value from the panel probe instead. Reported-by: Alessandro Suardi <alessandro.suardi@gmail.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/intel_lvds.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index 1a311ad..86cd30b 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -473,19 +473,13 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connector, bool force) { struct drm_device *dev = connector->dev; - enum drm_connector_status status = connector_status_connected; + enum drm_connector_status status; status = intel_panel_detect(dev); if (status != connector_status_unknown) return status; - /* ACPI lid methods were generally unreliable in this generation, so - * don't even bother. - */ - if (IS_GEN2(dev) || IS_GEN3(dev)) - return connector_status_connected; - - return status; + return connector_status_connected; } /** -- 1.7.4.1
next prev parent reply other threads:[~2011-03-24 13:52 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-03-24 11:30 regression: GM45 on Dell Latitude E6400 display from 1440x900 to 1024x768 somewhere between 2.6.38-git2 and -git7 Alessandro Suardi 2011-03-24 11:45 ` Chris Wilson 2011-03-24 12:03 ` Alessandro Suardi 2011-03-24 12:27 ` Chris Wilson 2011-03-24 13:11 ` Alessandro Suardi 2011-03-24 13:30 ` Chris Wilson [this message] 2011-03-24 13:30 ` [PATCH] drm/i915/lvds: Always return connected in the absence of better information Chris Wilson 2011-03-24 14:18 ` Alessandro Suardi 2011-03-24 18:12 ` [Intel-gfx] " Keith Packard 2011-03-24 18:12 ` Keith Packard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1300973444-6084-1-git-send-email-chris@chris-wilson.co.uk \ --to=chris@chris-wilson.co.uk \ --cc=alessandro.suardi@gmail.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.