All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Mathew McKernan <matmckernan@rauland.com.au>,
	stable@kernel.org, Chris Wilson <chris@chris-wilson.co.uk>
Subject: [PATCH 1/3] drm/i915/tv: Remember the detected TV type
Date: Tue, 12 Apr 2011 06:51:37 +0100	[thread overview]
Message-ID: <1302587499-9962-2-git-send-email-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <1302587499-9962-1-git-send-email-chris@chris-wilson.co.uk>

From: Mathew McKernan <matmckernan@rauland.com.au>

During detect() we would probe the connection bits to determine if
there was a TV attached, and what video input type (Component, S-Video,
Composite, etc) to use. However, we promptly discarded this vital bit of
information and never propagated it to where it was used to determine
the correct modes and setup the control registers. Fix it!

This fixes a regression from 7b334fcb45b757ffb093696ca3de1b0c8b4a33f1.

Reported-and-tested-by: Mathew McKernan <matmckernan@rauland.com.au>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35977
Signed-off-by: Mathew McKernan <matmckernan@rauland.com.au>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: stable@kernel.org
---
 drivers/gpu/drm/i915/intel_tv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index c27887f..84a733b 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -1356,7 +1356,9 @@ intel_tv_detect(struct drm_connector *connector, bool force)
 	if (type < 0)
 		return connector_status_disconnected;
 
+	intel_tv->type = type;
 	intel_tv_find_better_format(connector);
+
 	return connector_status_connected;
 }
 
-- 
1.7.4.1

_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable

  reply	other threads:[~2011-04-12  5:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  5:51 i915 TV fixes Chris Wilson
2011-04-12  5:51 ` Chris Wilson [this message]
2011-04-12  8:34   ` [PATCH 1/3] drm/i915/tv: Remember the detected TV type Paul Menzel
2011-04-12  8:43     ` Chris Wilson
2011-04-12  9:21       ` Paul Menzel
2011-04-12  5:51 ` [PATCH 2/3] drm/i915/tv: Only poll for TV connections Chris Wilson
2011-04-12  5:51 ` [PATCH 3/3] drm/i915/tv: Fix modeset flickering introduced in 7f58aabc3 Chris Wilson
2011-04-12 15:16   ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302587499-9962-2-git-send-email-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matmckernan@rauland.com.au \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.