From: Adrian Hunter <adrian.hunter@nokia.com> To: Tony Lindgren <tony@atomide.com> Cc: Madhusudhan Chikkature <madhu.cr@ti.com>, linux-omap Mailing List <linux-omap@vger.kernel.org>, linux-mmc Mailing List <linux-mmc@vger.kernel.org>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Sudhir Bera <ext-sudhir.bera@nokia.com>, Adrian Hunter <adrian.hunter@nokia.com> Subject: [PATCH 07/22] mmc: omap_hsmmc: fix missing mmc_release_host() in no_off case Date: Thu, 5 May 2011 14:51:07 +0300 [thread overview] Message-ID: <1304596282-4095-8-git-send-email-adrian.hunter@nokia.com> (raw) In-Reply-To: <1304596282-4095-1-git-send-email-adrian.hunter@nokia.com> From: Sudhir Bera <ext-sudhir.bera@nokia.com> In fact the no_off check here will not be hit because 'omap_hsmmc_disabled_to_sleep()' won't schedule a deeper disable in the no_off case. Signed-off-by: Sudhir Bera <ext-sudhir.bera@nokia.com> Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com> --- drivers/mmc/host/omap_hsmmc.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index bab25ff..bd52849 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1852,14 +1852,13 @@ static int omap_hsmmc_sleep_to_off(struct omap_hsmmc_host *host) return 0; if (mmc_slot(host).no_off) - return 0; + goto out; if (!((host->mmc->caps & MMC_CAP_NONREMOVABLE) || mmc_slot(host).card_detect || (mmc_slot(host).get_cover_state && mmc_slot(host).get_cover_state(host->dev, host->slot_id)))) { - mmc_release_host(host->mmc); - return 0; + goto out; } mmc_slot(host).set_power(host->dev, host->slot_id, 0, 0); @@ -1870,7 +1869,7 @@ static int omap_hsmmc_sleep_to_off(struct omap_hsmmc_host *host) host->dpm_state == CARDSLEEP ? "CARDSLEEP" : "REGSLEEP"); host->dpm_state = OFF; - +out: mmc_release_host(host->mmc); return 0; -- 1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: adrian.hunter@nokia.com (Adrian Hunter) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/22] mmc: omap_hsmmc: fix missing mmc_release_host() in no_off case Date: Thu, 5 May 2011 14:51:07 +0300 [thread overview] Message-ID: <1304596282-4095-8-git-send-email-adrian.hunter@nokia.com> (raw) In-Reply-To: <1304596282-4095-1-git-send-email-adrian.hunter@nokia.com> From: Sudhir Bera <ext-sudhir.bera@nokia.com> In fact the no_off check here will not be hit because 'omap_hsmmc_disabled_to_sleep()' won't schedule a deeper disable in the no_off case. Signed-off-by: Sudhir Bera <ext-sudhir.bera@nokia.com> Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com> --- drivers/mmc/host/omap_hsmmc.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index bab25ff..bd52849 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1852,14 +1852,13 @@ static int omap_hsmmc_sleep_to_off(struct omap_hsmmc_host *host) return 0; if (mmc_slot(host).no_off) - return 0; + goto out; if (!((host->mmc->caps & MMC_CAP_NONREMOVABLE) || mmc_slot(host).card_detect || (mmc_slot(host).get_cover_state && mmc_slot(host).get_cover_state(host->dev, host->slot_id)))) { - mmc_release_host(host->mmc); - return 0; + goto out; } mmc_slot(host).set_power(host->dev, host->slot_id, 0, 0); @@ -1870,7 +1869,7 @@ static int omap_hsmmc_sleep_to_off(struct omap_hsmmc_host *host) host->dpm_state == CARDSLEEP ? "CARDSLEEP" : "REGSLEEP"); host->dpm_state = OFF; - +out: mmc_release_host(host->mmc); return 0; -- 1.7.0.4
next prev parent reply other threads:[~2011-05-05 11:51 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-05-05 11:51 [PATCH 00/22] omap_hsmmc patches Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 01/22] OMAP: sDMA: descriptor autoloading feature Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-06 6:22 ` Tony Lindgren 2011-05-06 6:22 ` Tony Lindgren 2011-05-05 11:51 ` [PATCH 02/22] OMAP: DMA: add omap_dma_has_sglist() Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 03/22] OMAP: DMA: Ensure the sglist registers are cleared Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 04/22] mmc: omap hsmmc: adaptation of sdma descriptor Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 05/22] mmc: omap_hsmmc: fix dma sglist use Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 06/22] mmc: omap_hsmmc: limit scatterlist size for sDMA autoloading Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter [this message] 2011-05-05 11:51 ` [PATCH 07/22] mmc: omap_hsmmc: fix missing mmc_release_host() in no_off case Adrian Hunter 2011-05-05 13:08 ` Sergei Shtylyov 2011-05-05 13:08 ` Sergei Shtylyov 2011-05-05 11:51 ` [PATCH 08/22] mmc: omap_hsmmc: correct debug report error status mnemonics Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-06 8:35 ` S, Venkatraman 2011-05-06 8:35 ` S, Venkatraman 2011-05-05 11:51 ` [PATCH 09/22] mmc: omap_hsmmc: move hardcoded frequency constants to definition block Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 10/22] mmc: omap_hsmmc: reduce a bit the error handlers in probe() Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 11/22] mmc: omap_hsmmc: split duplicate code to calc_divisor() function Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 12/22] mmc: omap_hsmmc: introduce start_clock and re-use stop_clock Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 13/22] mmc: omap_hsmmc: fix few bugs when set the clock divisor Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 12:53 ` Grazvydas Ignotas 2011-05-05 12:53 ` Grazvydas Ignotas 2011-05-05 11:51 ` [PATCH 14/22] mmc: omap_hsmmc: split same pieces of code to separate functions Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 15/22] OMAP: hsmmc: Do not mux the slot if non default muxing is already done Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 16/22] OMAP: board-rm680: set MMC nomux flag Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 17/22] mmc: omap_hsmmc: ensure pbias configuration is always done Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 18/22] mmc: omap_hsmmc: fix oops in omap_hsmmc_dma_cb Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 19/22] OMAP: hsmmc: implement clock switcher Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 13:34 ` Grazvydas Ignotas 2011-05-05 13:34 ` Grazvydas Ignotas 2011-05-05 11:51 ` [PATCH 20/22] mmc: omap_hsmmc: adjust host controller clock in regard to current OPP Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 21/22] OMAP: hsmmc: add platform data for eMMC hardware reset gpio Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter 2011-05-05 11:51 ` [PATCH 22/22] mmc: omap_hsmmc: add a hardware reset before initialization Adrian Hunter 2011-05-05 11:51 ` Adrian Hunter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1304596282-4095-8-git-send-email-adrian.hunter@nokia.com \ --to=adrian.hunter@nokia.com \ --cc=ext-sudhir.bera@nokia.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=madhu.cr@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.