From: Tarun Kanti DebBarma <tarun.kanti@ti.com> To: linux-omap@vger.kernel.org Cc: khilman@ti.com, santosh.shilimkar@ti.com, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Charulatha V <charu@ti.com> Subject: [PATCH 08/15] OMAP2+: GPIO: make workaround_enabled bank specific Date: Tue, 24 May 2011 19:54:47 +0530 [thread overview] Message-ID: <1306247094-25372-9-git-send-email-tarun.kanti@ti.com> (raw) In-Reply-To: <1306247094-25372-1-git-send-email-tarun.kanti@ti.com> From: Charulatha V <charu@ti.com> Make workaround_enabled flag bank-specific instead of using a single flag for all the banks together. This would be helpful while making use of runtime framework in OMAP GPIO driver which would make the driver handle each GPIO bank independently. Also rename workaround_enabled flag to off_mode_wkup_wa_enabled Signed-off-by: Charulatha V <charu@ti.com> --- drivers/gpio/gpio_omap.c | 15 +++++---------- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio_omap.c b/drivers/gpio/gpio_omap.c index bc02ec5..fcc60be 100644 --- a/drivers/gpio/gpio_omap.c +++ b/drivers/gpio/gpio_omap.c @@ -72,6 +72,7 @@ struct gpio_bank { struct device *dev; bool dbck_flag; bool loses_context; + bool off_mode_wkup_wa_enabled; int stride; u32 width; u32 ctx_lost_cnt_before; @@ -1077,6 +1078,7 @@ static void __init omap_gpio_chip_init(struct gpio_bank *bank) static int gpio; bank->mod_usage = 0; + bank->off_mode_wkup_wa_enabled = false; /* * REVISIT eventually switch from OMAP-specific gpio structs * over to the generic ones @@ -1316,11 +1318,8 @@ static struct sys_device omap_gpio_device = { static void omap_gpio_save_context(struct gpio_bank *bank); static void omap_gpio_restore_context(struct gpio_bank *bank); -static int workaround_enabled; - void omap2_gpio_prepare_for_idle(int off_mode) { - int c = 0; struct gpio_bank *bank; list_for_each_entry(bank, &omap_gpio_list, node) { @@ -1378,7 +1377,7 @@ void omap2_gpio_prepare_for_idle(int off_mode) __raw_writel(l2, bank->base + OMAP4_GPIO_RISINGDETECT); } - c++; + bank->off_mode_wkup_wa_enabled = true; save_gpio_ctx: pdev = to_platform_device(bank->dev); @@ -1386,11 +1385,6 @@ save_gpio_ctx: omap_device_get_context_loss_count(pdev); omap_gpio_save_context(bank); } - if (!c) { - workaround_enabled = 0; - return; - } - workaround_enabled = 1; } void omap2_gpio_resume_after_idle(void) @@ -1415,7 +1409,7 @@ void omap2_gpio_resume_after_idle(void) if (ctx_lost_cnt_after == bank->ctx_lost_cnt_before) continue; - if (!workaround_enabled) + if (!bank->off_mode_wkup_wa_enabled) goto restore_gpio_ctx; if (!(bank->enabled_non_wakeup_gpios)) @@ -1495,6 +1489,7 @@ void omap2_gpio_resume_after_idle(void) } restore_gpio_ctx: + bank->off_mode_wkup_wa_enabled = false; omap_gpio_restore_context(bank); } -- 1.6.0.4
WARNING: multiple messages have this Message-ID (diff)
From: tarun.kanti@ti.com (Tarun Kanti DebBarma) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 08/15] OMAP2+: GPIO: make workaround_enabled bank specific Date: Tue, 24 May 2011 19:54:47 +0530 [thread overview] Message-ID: <1306247094-25372-9-git-send-email-tarun.kanti@ti.com> (raw) In-Reply-To: <1306247094-25372-1-git-send-email-tarun.kanti@ti.com> From: Charulatha V <charu@ti.com> Make workaround_enabled flag bank-specific instead of using a single flag for all the banks together. This would be helpful while making use of runtime framework in OMAP GPIO driver which would make the driver handle each GPIO bank independently. Also rename workaround_enabled flag to off_mode_wkup_wa_enabled Signed-off-by: Charulatha V <charu@ti.com> --- drivers/gpio/gpio_omap.c | 15 +++++---------- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio_omap.c b/drivers/gpio/gpio_omap.c index bc02ec5..fcc60be 100644 --- a/drivers/gpio/gpio_omap.c +++ b/drivers/gpio/gpio_omap.c @@ -72,6 +72,7 @@ struct gpio_bank { struct device *dev; bool dbck_flag; bool loses_context; + bool off_mode_wkup_wa_enabled; int stride; u32 width; u32 ctx_lost_cnt_before; @@ -1077,6 +1078,7 @@ static void __init omap_gpio_chip_init(struct gpio_bank *bank) static int gpio; bank->mod_usage = 0; + bank->off_mode_wkup_wa_enabled = false; /* * REVISIT eventually switch from OMAP-specific gpio structs * over to the generic ones @@ -1316,11 +1318,8 @@ static struct sys_device omap_gpio_device = { static void omap_gpio_save_context(struct gpio_bank *bank); static void omap_gpio_restore_context(struct gpio_bank *bank); -static int workaround_enabled; - void omap2_gpio_prepare_for_idle(int off_mode) { - int c = 0; struct gpio_bank *bank; list_for_each_entry(bank, &omap_gpio_list, node) { @@ -1378,7 +1377,7 @@ void omap2_gpio_prepare_for_idle(int off_mode) __raw_writel(l2, bank->base + OMAP4_GPIO_RISINGDETECT); } - c++; + bank->off_mode_wkup_wa_enabled = true; save_gpio_ctx: pdev = to_platform_device(bank->dev); @@ -1386,11 +1385,6 @@ save_gpio_ctx: omap_device_get_context_loss_count(pdev); omap_gpio_save_context(bank); } - if (!c) { - workaround_enabled = 0; - return; - } - workaround_enabled = 1; } void omap2_gpio_resume_after_idle(void) @@ -1415,7 +1409,7 @@ void omap2_gpio_resume_after_idle(void) if (ctx_lost_cnt_after == bank->ctx_lost_cnt_before) continue; - if (!workaround_enabled) + if (!bank->off_mode_wkup_wa_enabled) goto restore_gpio_ctx; if (!(bank->enabled_non_wakeup_gpios)) @@ -1495,6 +1489,7 @@ void omap2_gpio_resume_after_idle(void) } restore_gpio_ctx: + bank->off_mode_wkup_wa_enabled = false; omap_gpio_restore_context(bank); } -- 1.6.0.4
next prev parent reply other threads:[~2011-05-24 14:25 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-05-24 14:24 [PATCH 00/15] OMAP: GPIO: Cleanup OMAP GPIO driver Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-24 14:24 ` [PATCH 01/15] OMAP: GPIO: Avoid cpu_is checks during module ena/disable Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 21:19 ` Kevin Hilman 2011-05-25 21:19 ` Kevin Hilman 2011-05-26 9:38 ` Varadarajan, Charulatha 2011-05-26 9:38 ` Varadarajan, Charulatha 2011-05-24 14:24 ` [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 21:34 ` Kevin Hilman 2011-05-25 21:34 ` Kevin Hilman 2011-05-26 9:38 ` Varadarajan, Charulatha 2011-05-26 9:38 ` Varadarajan, Charulatha 2011-05-26 17:15 ` Kevin Hilman 2011-05-26 17:15 ` Kevin Hilman 2011-05-26 17:39 ` Varadarajan, Charulatha 2011-05-26 17:39 ` Varadarajan, Charulatha 2011-05-26 18:32 ` Kevin Hilman 2011-05-26 18:32 ` Kevin Hilman 2011-05-26 9:23 ` Premi, Sanjeev 2011-05-26 9:23 ` Premi, Sanjeev 2011-05-26 9:43 ` Varadarajan, Charulatha 2011-05-26 9:43 ` Varadarajan, Charulatha 2011-05-26 10:11 ` Cousson, Benoit 2011-05-26 10:11 ` Cousson, Benoit 2011-05-26 11:47 ` Premi, Sanjeev 2011-05-26 11:47 ` Premi, Sanjeev 2011-05-26 12:11 ` Cousson, Benoit 2011-05-26 12:11 ` Cousson, Benoit 2011-05-26 12:38 ` Premi, Sanjeev 2011-05-26 12:38 ` Premi, Sanjeev 2011-05-26 12:46 ` Cousson, Benoit 2011-05-26 12:46 ` Cousson, Benoit 2011-05-26 13:19 ` Premi, Sanjeev 2011-05-26 13:19 ` Premi, Sanjeev 2011-05-26 13:38 ` B.J. Buchalter 2011-05-26 13:38 ` B.J. Buchalter 2011-05-26 14:12 ` Cousson, Benoit 2011-05-26 14:12 ` Cousson, Benoit 2011-05-24 14:24 ` [PATCH 03/15] OMAP: GPIO: Remove dependency on gpio_bank_count Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-24 14:24 ` [PATCH 04/15] OMAP2PLUS: GPIO: Use flag to identify wkup dmn GPIO Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 21:40 ` Kevin Hilman 2011-05-25 21:40 ` Kevin Hilman 2011-05-24 14:24 ` [PATCH 05/15] OMAP: GPIO: Make gpio_context part of gpio_bank structure Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 21:41 ` Kevin Hilman 2011-05-25 21:41 ` Kevin Hilman 2011-05-26 9:58 ` Premi, Sanjeev 2011-05-26 9:58 ` Premi, Sanjeev 2011-05-26 10:07 ` Varadarajan, Charulatha 2011-05-26 10:07 ` Varadarajan, Charulatha 2011-05-26 9:59 ` Premi, Sanjeev 2011-05-26 9:59 ` Premi, Sanjeev 2011-05-24 14:24 ` [PATCH 06/15] OMAP4: GPIO: Save/restore context Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 21:43 ` Kevin Hilman 2011-05-25 21:43 ` Kevin Hilman 2011-05-26 9:37 ` Varadarajan, Charulatha 2011-05-26 9:37 ` Varadarajan, Charulatha 2011-05-24 14:24 ` [PATCH 07/15] OMAP: GPIO: handle save/restore ctx in GPIO driver Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 22:33 ` Kevin Hilman 2011-05-25 22:33 ` Kevin Hilman 2011-05-25 22:36 ` Kevin Hilman 2011-05-25 22:36 ` Kevin Hilman 2011-05-24 14:24 ` Tarun Kanti DebBarma [this message] 2011-05-24 14:24 ` [PATCH 08/15] OMAP2+: GPIO: make workaround_enabled bank specific Tarun Kanti DebBarma 2011-05-25 22:39 ` Kevin Hilman 2011-05-25 22:39 ` Kevin Hilman 2011-05-26 9:37 ` Varadarajan, Charulatha 2011-05-26 9:37 ` Varadarajan, Charulatha 2011-05-24 14:24 ` [PATCH 09/15] OMAP: GPIO: cleanup suspend and resume functions Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 22:57 ` Kevin Hilman 2011-05-25 22:57 ` Kevin Hilman 2011-05-26 10:02 ` Varadarajan, Charulatha 2011-05-26 10:02 ` Varadarajan, Charulatha 2011-05-24 14:24 ` [PATCH 10/15] OMAP: GPIO: cleanup prepare/resume idle functions Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 23:00 ` Kevin Hilman 2011-05-25 23:00 ` Kevin Hilman 2011-05-24 14:24 ` [PATCH 11/15] OMAP: GPIO: Remove hardcoded offsets in ctxt save/restore Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 23:01 ` Kevin Hilman 2011-05-25 23:01 ` Kevin Hilman 2011-05-26 9:36 ` Varadarajan, Charulatha 2011-05-26 9:36 ` Varadarajan, Charulatha 2011-05-26 9:42 ` Premi, Sanjeev 2011-05-26 9:42 ` Premi, Sanjeev 2011-05-26 9:48 ` Varadarajan, Charulatha 2011-05-26 9:48 ` Varadarajan, Charulatha 2011-05-24 14:24 ` [PATCH 12/15] OMAP: GPIO: Fix: use wake set/clear regs Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 23:14 ` Kevin Hilman 2011-05-25 23:14 ` Kevin Hilman 2011-05-26 9:36 ` Varadarajan, Charulatha 2011-05-26 9:36 ` Varadarajan, Charulatha 2011-05-24 14:24 ` [PATCH 13/15] OMAP: GPIO: clean set_gpio_triggering function Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 23:27 ` Kevin Hilman 2011-05-25 23:27 ` Kevin Hilman 2011-05-26 9:55 ` Varadarajan, Charulatha 2011-05-26 9:55 ` Varadarajan, Charulatha 2011-05-24 14:24 ` [PATCH 14/15] OMAP: GPIO: Use memset for omap_gpio_reg_offs Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 23:30 ` Kevin Hilman 2011-05-25 23:30 ` Kevin Hilman 2011-05-24 14:24 ` [PATCH 15/15] OMAP: GPIO: clean omap_gpio_mod_init function Tarun Kanti DebBarma 2011-05-24 14:24 ` Tarun Kanti DebBarma 2011-05-25 23:48 ` Kevin Hilman 2011-05-25 23:48 ` Kevin Hilman 2011-06-03 11:20 ` Varadarajan, Charulatha 2011-06-03 11:20 ` Varadarajan, Charulatha 2011-06-03 14:31 ` Kevin Hilman 2011-06-03 14:31 ` Kevin Hilman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1306247094-25372-9-git-send-email-tarun.kanti@ti.com \ --to=tarun.kanti@ti.com \ --cc=charu@ti.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=santosh.shilimkar@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.