All of lore.kernel.org
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 03/14] ARM: smp_twd: add support for remapped PPI interrupts
Date: Fri,  3 Jun 2011 15:15:47 +0100	[thread overview]
Message-ID: <1307110558-29710-4-git-send-email-marc.zyngier@arm.com> (raw)
In-Reply-To: <1307110558-29710-1-git-send-email-marc.zyngier@arm.com>

When CONFIG_ARM_GIC_VPPI is enabled, let smp_twd request interrupts
the normal way (ie using request_irq()).

This involves letting PPIs go via the same code path as SPIs and
having normal interrupt handler for the local timer code.

The previous ad-hoc code is still supported when CONFIG_ARM_GIC_VPPI
is not defined.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Reviewed-by: Will Deacon <will.deacon@arm.com>
---
 arch/arm/kernel/smp_twd.c |   28 +++++++++++++++++++++++++++-
 1 files changed, 27 insertions(+), 1 deletions(-)

diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
index 60636f4..773336e 100644
--- a/arch/arm/kernel/smp_twd.c
+++ b/arch/arm/kernel/smp_twd.c
@@ -15,16 +15,18 @@
 #include <linux/smp.h>
 #include <linux/jiffies.h>
 #include <linux/clockchips.h>
-#include <linux/irq.h>
+#include <linux/interrupt.h>
 #include <linux/io.h>
 
 #include <asm/smp_twd.h>
+#include <asm/localtimer.h>
 #include <asm/hardware/gic.h>
 
 /* set up by the platform code */
 void __iomem *twd_base;
 
 static unsigned long twd_timer_rate;
+static DEFINE_PER_CPU(bool, irq_reqd);
 
 static void twd_set_mode(enum clock_event_mode mode,
 			struct clock_event_device *clk)
@@ -43,6 +45,10 @@ static void twd_set_mode(enum clock_event_mode mode,
 		ctrl = TWD_TIMER_CONTROL_IT_ENABLE | TWD_TIMER_CONTROL_ONESHOT;
 		break;
 	case CLOCK_EVT_MODE_UNUSED:
+#ifdef CONFIG_ARM_GIC_VPPI
+		disable_irq(clk->irq);
+		/* fall through */
+#endif
 	case CLOCK_EVT_MODE_SHUTDOWN:
 	default:
 		ctrl = 0;
@@ -124,6 +130,9 @@ static void __cpuinit twd_calibrate_rate(void)
  */
 void __cpuinit twd_timer_setup(struct clock_event_device *clk)
 {
+	int err;
+	bool *reqd;
+
 	twd_calibrate_rate();
 
 	clk->name = "local_timer";
@@ -137,8 +146,25 @@ void __cpuinit twd_timer_setup(struct clock_event_device *clk)
 	clk->max_delta_ns = clockevent_delta2ns(0xffffffff, clk);
 	clk->min_delta_ns = clockevent_delta2ns(0xf, clk);
 
+#ifdef CONFIG_ARM_GIC_VPPI
+	reqd = &__get_cpu_var(irq_reqd);
+	if (!*reqd) {
+		err = request_irq(clk->irq, percpu_timer_handler,
+				  IRQF_PERCPU | IRQF_NOBALANCING | IRQF_TIMER,
+				  clk->name, clk);
+		if (err) {
+			pr_err("%s: can't register interrupt %d on cpu %d (%d)\n",
+			       clk->name, clk->irq, smp_processor_id(), err);
+			return;
+		}
+
+		*reqd = true;
+	} else
+		enable_irq(clk->irq);
+#else
 	/* Make sure our local interrupt controller has this enabled */
 	gic_enable_ppi(clk->irq);
+#endif
 
 	clockevents_register_device(clk);
 }
-- 
1.7.0.4

  parent reply	other threads:[~2011-06-03 14:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-03 14:15 [PATCH v6 00/14] Consolidating GIC per-cpu interrupts Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 01/14] ARM: gic: add per-cpu interrupt multiplexer Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 02/14] ARM: smp: add interrupt handler for local timers Marc Zyngier
2011-06-03 14:15 ` Marc Zyngier [this message]
2011-06-03 14:15 ` [PATCH v6 04/14] ARM: omap4: use remapped PPI interrupts for local timer Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 05/14] ARM: versatile: " Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 06/14] ARM: shmobile: " Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 07/14] ARM: ux500: " Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 08/14] ARM: tegra: " Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 09/14] ARM: msm: " Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 10/14] ARM: exynos4: " Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 11/14] ARM: gic: remove previous local timer interrupt handling Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 12/14] ARM: gic: add compute_irqnr macro for exynos4 Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 13/14] ARM: SMP: automatically select ARM_GIC_VPPI Marc Zyngier
2011-06-03 14:15 ` [PATCH v6 14/14] ARM: exynos4: switch MCT to the full local timer infrastructure Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307110558-29710-4-git-send-email-marc.zyngier@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.