From: Kevin Hilman <khilman@ti.com> To: Ben Dooks <ben-linux@fluff.org> Cc: linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] I2C: OMAP: remove racy suspend/resume callbacks Date: Tue, 7 Jun 2011 11:22:31 -0700 [thread overview] Message-ID: <1307470951-22801-4-git-send-email-khilman@ti.com> (raw) In-Reply-To: <1307470951-22801-1-git-send-email-khilman@ti.com> Current system PM methods for this driver race with the runtime PM methods when an i2c xfer is in progress when the system suspend path is excuted. These callbacks are only needed when runtime PM is disabled from userspace, so for now we accept that this device will not hit retention, even in suspend, if runtime PM disabled. The correct fix (forthcoming) for v3.0+ is to use device power domain callbacks at the system PM level to handle this, but for now, this avoids the race. Signed-off-by: Kevin Hilman <khilman@ti.com> --- drivers/i2c/busses/i2c-omap.c | 20 -------------------- 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 4e3256f..77ed95f 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1150,27 +1150,7 @@ static int omap_i2c_runtime_resume(struct device *dev) return 0; } -static int omap_i2c_suspend(struct device *dev) -{ - if (!pm_runtime_suspended(dev)) - if (dev->bus && dev->bus->pm && dev->bus->pm->runtime_suspend) - dev->bus->pm->runtime_suspend(dev); - - return 0; -} - -static int omap_i2c_resume(struct device *dev) -{ - if (!pm_runtime_suspended(dev)) - if (dev->bus && dev->bus->pm && dev->bus->pm->runtime_resume) - dev->bus->pm->runtime_resume(dev); - - return 0; -} - static struct dev_pm_ops omap_i2c_pm_ops = { - .suspend = omap_i2c_suspend, - .resume = omap_i2c_resume, .runtime_suspend = omap_i2c_runtime_suspend, .runtime_resume = omap_i2c_runtime_resume, }; -- 1.7.4
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] I2C: OMAP: remove racy suspend/resume callbacks Date: Tue, 7 Jun 2011 11:22:31 -0700 [thread overview] Message-ID: <1307470951-22801-4-git-send-email-khilman@ti.com> (raw) In-Reply-To: <1307470951-22801-1-git-send-email-khilman@ti.com> Current system PM methods for this driver race with the runtime PM methods when an i2c xfer is in progress when the system suspend path is excuted. These callbacks are only needed when runtime PM is disabled from userspace, so for now we accept that this device will not hit retention, even in suspend, if runtime PM disabled. The correct fix (forthcoming) for v3.0+ is to use device power domain callbacks at the system PM level to handle this, but for now, this avoids the race. Signed-off-by: Kevin Hilman <khilman@ti.com> --- drivers/i2c/busses/i2c-omap.c | 20 -------------------- 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 4e3256f..77ed95f 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1150,27 +1150,7 @@ static int omap_i2c_runtime_resume(struct device *dev) return 0; } -static int omap_i2c_suspend(struct device *dev) -{ - if (!pm_runtime_suspended(dev)) - if (dev->bus && dev->bus->pm && dev->bus->pm->runtime_suspend) - dev->bus->pm->runtime_suspend(dev); - - return 0; -} - -static int omap_i2c_resume(struct device *dev) -{ - if (!pm_runtime_suspended(dev)) - if (dev->bus && dev->bus->pm && dev->bus->pm->runtime_resume) - dev->bus->pm->runtime_resume(dev); - - return 0; -} - static struct dev_pm_ops omap_i2c_pm_ops = { - .suspend = omap_i2c_suspend, - .resume = omap_i2c_resume, .runtime_suspend = omap_i2c_runtime_suspend, .runtime_resume = omap_i2c_runtime_resume, }; -- 1.7.4
next prev parent reply other threads:[~2011-06-07 18:22 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-07 18:22 [PATCH 0/3] I2C: OMAP: PM related cleanup Kevin Hilman 2011-06-07 18:22 ` Kevin Hilman [not found] ` <1307470951-22801-1-git-send-email-khilman-l0cyMroinI0@public.gmane.org> 2011-06-07 18:22 ` [PATCH 1/3] I2C: OMAP: remove unneccesary use of pdev Kevin Hilman 2011-06-07 18:22 ` Kevin Hilman 2011-06-07 18:22 ` [PATCH 2/3] I2C: OMAP: remove dev->idle, use usage counting provided by runtime PM Kevin Hilman 2011-06-07 18:22 ` Kevin Hilman 2011-06-07 18:22 ` Kevin Hilman [this message] 2011-06-07 18:22 ` [PATCH 3/3] I2C: OMAP: remove racy suspend/resume callbacks Kevin Hilman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1307470951-22801-4-git-send-email-khilman@ti.com \ --to=khilman@ti.com \ --cc=ben-linux@fluff.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=rnayak@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.