All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@googlemail.com>
To: linux-input@vger.kernel.org
Cc: jkosina@suse.cz, padovan@profusion.mobi, dh.herrmann@googlemail.com
Subject: [RFC 04/12] HID: wiimote: Register input device in wiimote hid driver
Date: Wed, 15 Jun 2011 01:45:49 +0200	[thread overview]
Message-ID: <1308095157-4699-5-git-send-email-dh.herrmann@googlemail.com> (raw)
In-Reply-To: <1308095157-4699-1-git-send-email-dh.herrmann@googlemail.com>

Register input device so the wiimote can report input events on
it. We do not use HIDINPUT because the wiimote does not provide any
descriptor table which might be used by HIDINPUT. So we avoid
having HIDINPUT parse the wiimote descriptor and create unrelated
or unknown event flags. Instead we register our own input device
that we have full control of.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 drivers/hid/hid-wiimote.c |   34 ++++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-wiimote.c b/drivers/hid/hid-wiimote.c
index 27a4261..9fa4fe1 100644
--- a/drivers/hid/hid-wiimote.c
+++ b/drivers/hid/hid-wiimote.c
@@ -10,7 +10,9 @@
  * any later version.
  */
 
+#include <linux/device.h>
 #include <linux/hid.h>
+#include <linux/input.h>
 #include <linux/module.h>
 #include "hid-ids.h"
 
@@ -19,8 +21,15 @@
 
 struct wiimote_data {
 	struct hid_device *hdev;
+	struct input_dev *input;
 };
 
+static int wiimote_input_event(struct input_dev *dev, unsigned int type,
+						unsigned int code, int value)
+{
+	return 0;
+}
+
 static int wiimote_hid_event(struct hid_device *hdev, struct hid_report *report,
 							u8 *raw_data, int size)
 {
@@ -38,9 +47,24 @@ static struct wiimote_data *wiimote_create(struct hid_device *hdev)
 	if (!wdata)
 		return NULL;
 
+	wdata->input = input_allocate_device();
+	if (!wdata->input) {
+		kfree(wdata);
+		return NULL;
+	}
+
 	wdata->hdev = hdev;
 	hid_set_drvdata(hdev, wdata);
 
+	input_set_drvdata(wdata->input, wdata);
+	wdata->input->event = wiimote_input_event;
+	wdata->input->dev.parent = &wdata->hdev->dev;
+	wdata->input->id.bustype = wdata->hdev->bus;
+	wdata->input->id.vendor = wdata->hdev->vendor;
+	wdata->input->id.product = wdata->hdev->product;
+	wdata->input->id.version = wdata->hdev->version;
+	wdata->input->name = WIIMOTE_NAME;
+
 	return wdata;
 }
 
@@ -68,10 +92,19 @@ static int wiimote_hid_probe(struct hid_device *hdev,
 		goto err;
 	}
 
+	ret = input_register_device(wdata->input);
+	if (ret) {
+		hid_err(hdev, "Cannot register input device\n");
+		goto err_stop;
+	}
+
 	hid_info(hdev, "New device registered\n");
 	return 0;
 
+err_stop:
+	hid_hw_stop(hdev);
 err:
+	input_free_device(wdata->input);
 	kfree(wdata);
 	return ret;
 }
@@ -82,6 +115,7 @@ static void wiimote_hid_remove(struct hid_device *hdev)
 
 	hid_info(hdev, "Device removed\n");
 	hid_hw_stop(hdev);
+	input_unregister_device(wdata->input);
 	kfree(wdata);
 }
 
-- 
1.7.5.2


  parent reply	other threads:[~2011-06-14 23:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 23:45 [RFC 00/12] Nintendo Wii Remote Device Driver David Herrmann
2011-06-14 23:45 ` [RFC 01/12] HID: wiimote: Add Nintendo Wii Remote driver stub David Herrmann
2011-06-14 23:45 ` [RFC 02/12] HID: wiimote: Register wiimote hid " David Herrmann
2011-06-14 23:45 ` [RFC 03/12] HID: wiimote: Add wiimote device structure David Herrmann
2011-06-15  6:20   ` Oliver Neukum
2011-06-14 23:45 ` David Herrmann [this message]
2011-06-14 23:45 ` [RFC 05/12] HID: wiimote: Synchronize wiimote input and hid event handling David Herrmann
2011-06-15  6:34   ` Oliver Neukum
2011-06-16  9:20     ` Jiri Kosina
2011-06-16 10:18       ` Oliver Neukum
2011-06-16 10:29         ` David Herrmann
2011-06-16 10:42           ` Oliver Neukum
2011-06-14 23:45 ` [RFC 06/12] HID: wiimote: Add wiimote send function David Herrmann
2011-06-14 23:45 ` [RFC 07/12] HID: wiimote: Add output queue for wiimote driver David Herrmann
2011-06-15  6:37   ` Oliver Neukum
2011-06-14 23:45 ` [RFC 08/12] HID: wiimote: Add wiimote event handler David Herrmann
2011-06-14 23:45 ` [RFC 09/12] HID: wiimote: Add wiimote input button parser David Herrmann
2011-06-14 23:45 ` [RFC 10/12] HID: wiimote: Add wiimote led request David Herrmann
2011-06-14 23:45 ` [RFC 11/12] HID: wiimote: Cache wiimote led state David Herrmann
2011-06-15  6:40   ` Oliver Neukum
2011-06-14 23:45 ` [RFC 12/12] HID: wiimote: Add sysfs support to wiimote driver David Herrmann
2011-06-16 18:35   ` Jiri Kosina
2011-06-17 14:58     ` David Herrmann
2011-06-16 18:36 ` [RFC 00/12] Nintendo Wii Remote Device Driver Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308095157-4699-5-git-send-email-dh.herrmann@googlemail.com \
    --to=dh.herrmann@googlemail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.