All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Felipe Balbi <balbi@ti.com>
Subject: [PATCH 05/11] cbus: tahvo: drop the tasklet
Date: Sat,  9 Jul 2011 01:52:33 +0300	[thread overview]
Message-ID: <1310165559-31037-6-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1310165559-31037-1-git-send-email-balbi@ti.com>

by moving to threaded IRQ.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/cbus/tahvo.c |   16 ++++------------
 1 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c
index 0e28208..4b062de 100644
--- a/drivers/cbus/tahvo.c
+++ b/drivers/cbus/tahvo.c
@@ -43,7 +43,6 @@
 static int tahvo_initialized;
 static int tahvo_is_betty;
 
-static struct tasklet_struct tahvo_tasklet;
 static struct mutex tahvo_lock;
 
 static struct device *the_dev;
@@ -174,12 +173,6 @@ EXPORT_SYMBOL(tahvo_set_backlight_level);
 
 static irqreturn_t tahvo_irq_handler(int irq, void *dev_id)
 {
-	tasklet_schedule(&tahvo_tasklet);
-	return IRQ_HANDLED;
-}
-
-static void tahvo_tasklet_handler(unsigned long data)
-{
 	struct tahvo_irq_handler_desc *hnd;
 	u16 id;
 	u16 im;
@@ -212,6 +205,8 @@ static void tahvo_tasklet_handler(unsigned long data)
 			 */
 		}
 	}
+
+	return IRQ_HANDLED;
 }
 
 /*
@@ -276,9 +271,6 @@ static int __devinit tahvo_probe(struct platform_device *pdev)
 	mutex_init(&tahvo_lock);
 	the_dev = &pdev->dev;
 
-	/* Prepare tasklet */
-	tasklet_init(&tahvo_tasklet, tahvo_tasklet_handler, 0);
-
 	tahvo_initialized = 1;
 
 	rev = tahvo_read_reg(TAHVO_REG_ASICR);
@@ -308,7 +300,8 @@ static int __devinit tahvo_probe(struct platform_device *pdev)
 	/* Mask all TAHVO interrupts */
 	tahvo_write_reg(TAHVO_REG_IMR, 0xffff);
 
-	ret = request_irq(irq, tahvo_irq_handler, IRQF_TRIGGER_RISING,
+	ret = request_threaded_irq(irq, NULL, tahvo_irq_handler,
+			IRQF_TRIGGER_RISING | IRQF_ONESHOT,
 			"tahvo", 0);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "Unable to register IRQ handler\n");
@@ -326,7 +319,6 @@ static int __devexit tahvo_remove(struct platform_device *pdev)
 	/* Mask all TAHVO interrupts */
 	tahvo_write_reg(TAHVO_REG_IMR, 0xffff);
 	free_irq(irq, 0);
-	tasklet_kill(&tahvo_tasklet);
 	the_dev = NULL;
 
 	return 0;
-- 
1.7.6


  parent reply	other threads:[~2011-07-08 22:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08 22:52 [PATCH 00/11] Tahvo cleanups and Retu optimization Felipe Balbi
2011-07-08 22:52 ` [PATCH 01/11] cbus: tahvo: convert spinlock into mutex Felipe Balbi
2011-07-08 22:52 ` [PATCH 02/11] cbus: tahvo: move to __devinit/__devexit sections Felipe Balbi
2011-07-08 22:52 ` [PATCH 03/11] cbus: tahvo: a switch looks better Felipe Balbi
2011-07-08 22:52 ` [PATCH 04/11] cbus: tahvo: don't go over 80 columns Felipe Balbi
2011-07-08 22:52 ` Felipe Balbi [this message]
2011-07-08 22:52 ` [PATCH 06/11] cbus: retu: set IRQF_ONESHOT flag Felipe Balbi
2011-07-08 22:52 ` [PATCH 07/11] cbus: tahvo: git it a context structure Felipe Balbi
2011-07-08 22:52 ` [PATCH 08/11] cbus: tahvo: pass tahvo to IRQ handler Felipe Balbi
2011-07-08 22:52 ` [PATCH 09/11] cbus: tahvo: introduce __tahvo_(read/write)_reg Felipe Balbi
2011-07-08 22:52 ` [PATCH 10/11] cbus: tahvo: drop some unneded defines Felipe Balbi
2011-07-08 22:52 ` [PATCH 11/11] cbus: retu: IRQ demux optimization Felipe Balbi
2011-07-11 11:13 ` [PATCH 00/11] Tahvo cleanups and Retu optimization Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310165559-31037-6-git-send-email-balbi@ti.com \
    --to=balbi@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.