From: Donggeun Kim <dg77.kim@samsung.com> To: linux-fbdev@vger.kernel.org Cc: rpurdie@rpsys.net, lethal@linux-sh.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, dh09.lee@samsung.com, dg77.kim@samsung.com Subject: [PATCH v2] backlight/platform_lcd: change set power function parameter in plat_lcd_data Date: Wed, 27 Jul 2011 18:12:57 +0900 [thread overview] Message-ID: <1311757977-12694-1-git-send-email-dg77.kim@samsung.com> (raw) The set_power function in platdata for platform_lcd driver has originally two parameters. The first parameter type is struct plat_lcd_data * and the second parameter type is unsigned int . In some cases, it is needed to get pointer typed 'struct device' in order to call regulator_* functions. This patch allows users to define a set_power function which control regulators related to platform_lcd device. Currently, variables in struct plat_lcd_data are not used in several set_power functions which are defined at arch/arm/ directory. Changes since v1 : * Remove compile warning message by including another heeder file Signed-off-by: Donggeun Kim <dg77.kim@samsung.com> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- drivers/video/backlight/platform_lcd.c | 2 +- include/video/platform_lcd.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c index 302330a..cf23a3f 100644 --- a/drivers/video/backlight/platform_lcd.c +++ b/drivers/video/backlight/platform_lcd.c @@ -49,7 +49,7 @@ static int platform_lcd_set_power(struct lcd_device *lcd, int power) if (power == FB_BLANK_POWERDOWN || plcd->suspended) lcd_power = 0; - plcd->pdata->set_power(plcd->pdata, lcd_power); + plcd->pdata->set_power(lcd, lcd_power); plcd->power = power; return 0; diff --git a/include/video/platform_lcd.h b/include/video/platform_lcd.h index ad3bdfe..5d7e943 100644 --- a/include/video/platform_lcd.h +++ b/include/video/platform_lcd.h @@ -10,12 +10,13 @@ * published by the Free Software Foundation. * */ +#include <linux/lcd.h> struct plat_lcd_data; struct fb_info; struct plat_lcd_data { - void (*set_power)(struct plat_lcd_data *, unsigned int power); + void (*set_power)(struct lcd_device *, unsigned int power); int (*match_fb)(struct plat_lcd_data *, struct fb_info *); }; -- 1.7.4.1
WARNING: multiple messages have this Message-ID (diff)
From: Donggeun Kim <dg77.kim@samsung.com> To: linux-fbdev@vger.kernel.org Cc: rpurdie@rpsys.net, lethal@linux-sh.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, dh09.lee@samsung.com, dg77.kim@samsung.com Subject: [PATCH v2] backlight/platform_lcd: change set power function parameter Date: Wed, 27 Jul 2011 09:12:57 +0000 [thread overview] Message-ID: <1311757977-12694-1-git-send-email-dg77.kim@samsung.com> (raw) The set_power function in platdata for platform_lcd driver has originally two parameters. The first parameter type is struct plat_lcd_data * and the second parameter type is unsigned int . In some cases, it is needed to get pointer typed 'struct device' in order to call regulator_* functions. This patch allows users to define a set_power function which control regulators related to platform_lcd device. Currently, variables in struct plat_lcd_data are not used in several set_power functions which are defined at arch/arm/ directory. Changes since v1 : * Remove compile warning message by including another heeder file Signed-off-by: Donggeun Kim <dg77.kim@samsung.com> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- drivers/video/backlight/platform_lcd.c | 2 +- include/video/platform_lcd.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c index 302330a..cf23a3f 100644 --- a/drivers/video/backlight/platform_lcd.c +++ b/drivers/video/backlight/platform_lcd.c @@ -49,7 +49,7 @@ static int platform_lcd_set_power(struct lcd_device *lcd, int power) if (power = FB_BLANK_POWERDOWN || plcd->suspended) lcd_power = 0; - plcd->pdata->set_power(plcd->pdata, lcd_power); + plcd->pdata->set_power(lcd, lcd_power); plcd->power = power; return 0; diff --git a/include/video/platform_lcd.h b/include/video/platform_lcd.h index ad3bdfe..5d7e943 100644 --- a/include/video/platform_lcd.h +++ b/include/video/platform_lcd.h @@ -10,12 +10,13 @@ * published by the Free Software Foundation. * */ +#include <linux/lcd.h> struct plat_lcd_data; struct fb_info; struct plat_lcd_data { - void (*set_power)(struct plat_lcd_data *, unsigned int power); + void (*set_power)(struct lcd_device *, unsigned int power); int (*match_fb)(struct plat_lcd_data *, struct fb_info *); }; -- 1.7.4.1
next reply other threads:[~2011-07-27 9:13 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-07-27 9:12 Donggeun Kim [this message] 2011-07-27 9:12 ` [PATCH v2] backlight/platform_lcd: change set power function parameter Donggeun Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1311757977-12694-1-git-send-email-dg77.kim@samsung.com \ --to=dg77.kim@samsung.com \ --cc=dh09.lee@samsung.com \ --cc=kyungmin.park@samsung.com \ --cc=lethal@linux-sh.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rpurdie@rpsys.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.