From: Bojan Prtvar <prtvar.b@gmail.com> To: jkosina@suse.cz Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bojan Prtvar <prtvar.b@gmail.com> Subject: [PATCH 2/2] HID: kfree() NULL pointer cleanup Date: Thu, 4 Aug 2011 22:43:46 +0200 [thread overview] Message-ID: <1312490626-14838-1-git-send-email-prtvar.b@gmail.com> (raw) Checking for NULL pointers before kfree() is redundant. Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com> --- drivers/hid/hid-zydacron.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-zydacron.c b/drivers/hid/hid-zydacron.c index e903715..1ad85f2 100644 --- a/drivers/hid/hid-zydacron.c +++ b/drivers/hid/hid-zydacron.c @@ -201,9 +201,7 @@ static void zc_remove(struct hid_device *hdev) struct zc_device *zc = hid_get_drvdata(hdev); hid_hw_stop(hdev); - - if (NULL != zc) - kfree(zc); + kfree(zc); } static const struct hid_device_id zc_devices[] = { -- 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Bojan Prtvar <prtvar.b@gmail.com> To: jkosina@suse.cz Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bojan Prtvar <prtvar.b@gmail.com> Subject: [PATCH 2/2] HID: kfree() NULL pointer cleanup Date: Thu, 04 Aug 2011 20:43:46 +0000 [thread overview] Message-ID: <1312490626-14838-1-git-send-email-prtvar.b@gmail.com> (raw) Checking for NULL pointers before kfree() is redundant. Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com> --- drivers/hid/hid-zydacron.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-zydacron.c b/drivers/hid/hid-zydacron.c index e903715..1ad85f2 100644 --- a/drivers/hid/hid-zydacron.c +++ b/drivers/hid/hid-zydacron.c @@ -201,9 +201,7 @@ static void zc_remove(struct hid_device *hdev) struct zc_device *zc = hid_get_drvdata(hdev); hid_hw_stop(hdev); - - if (NULL != zc) - kfree(zc); + kfree(zc); } static const struct hid_device_id zc_devices[] = { -- 1.7.1
next reply other threads:[~2011-08-04 20:44 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-04 20:43 Bojan Prtvar [this message] 2011-08-04 20:43 ` [PATCH 2/2] HID: kfree() NULL pointer cleanup Bojan Prtvar 2011-08-04 21:46 ` Jiri Kosina 2011-08-04 21:46 ` Jiri Kosina
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1312490626-14838-1-git-send-email-prtvar.b@gmail.com \ --to=prtvar.b@gmail.com \ --cc=jkosina@suse.cz \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.