From: Jason Liu <jason.hui@linaro.org>
To: <linux-arm-kernel@lists.infradead.org>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<David.Woodhouse@intel.com>, <dedekind1@gmail.com>,
<patches@linaro.org>
Subject: [PATCH] mtd: check parts pointer before using it
Date: Wed, 24 Aug 2011 18:53:01 +0800 [thread overview]
Message-ID: <1314183181-4197-1-git-send-email-jason.hui@linaro.org> (raw)
The code has the check for parts but it called after kmemdup,
kmemdup(parts, sizeof(*parts) * nr_parts,...)
if (!parts)
return -ENOMEM
In fact, we need check parts before safely using it.
Signed-off-by: Jason Liu <jason.hui@linaro.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
---
This patch is based on git://git.infradead.org/users/dedekind/l2-mtd-2.6.git
---
drivers/mtd/mtdcore.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 09bdbac..ce59ff5 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -465,12 +465,10 @@ int mtd_device_parse_register(struct mtd_info *mtd, const char **types,
struct mtd_partition *real_parts;
err = parse_mtd_partitions(mtd, types, &real_parts, parser_data);
- if (err <= 0 && nr_parts) {
+ if (err <= 0 && nr_parts && !parts) {
real_parts = kmemdup(parts, sizeof(*parts) * nr_parts,
GFP_KERNEL);
err = nr_parts;
- if (!parts)
- err = -ENOMEM;
}
if (err > 0) {
--
1.7.4.1
WARNING: multiple messages have this Message-ID (diff)
From: Jason Liu <jason.hui@linaro.org>
To: <linux-arm-kernel@lists.infradead.org>
Cc: dedekind1@gmail.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, patches@linaro.org,
David.Woodhouse@intel.com
Subject: [PATCH] mtd: check parts pointer before using it
Date: Wed, 24 Aug 2011 18:53:01 +0800 [thread overview]
Message-ID: <1314183181-4197-1-git-send-email-jason.hui@linaro.org> (raw)
The code has the check for parts but it called after kmemdup,
kmemdup(parts, sizeof(*parts) * nr_parts,...)
if (!parts)
return -ENOMEM
In fact, we need check parts before safely using it.
Signed-off-by: Jason Liu <jason.hui@linaro.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
---
This patch is based on git://git.infradead.org/users/dedekind/l2-mtd-2.6.git
---
drivers/mtd/mtdcore.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 09bdbac..ce59ff5 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -465,12 +465,10 @@ int mtd_device_parse_register(struct mtd_info *mtd, const char **types,
struct mtd_partition *real_parts;
err = parse_mtd_partitions(mtd, types, &real_parts, parser_data);
- if (err <= 0 && nr_parts) {
+ if (err <= 0 && nr_parts && !parts) {
real_parts = kmemdup(parts, sizeof(*parts) * nr_parts,
GFP_KERNEL);
err = nr_parts;
- if (!parts)
- err = -ENOMEM;
}
if (err > 0) {
--
1.7.4.1
WARNING: multiple messages have this Message-ID (diff)
From: jason.hui@linaro.org (Jason Liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: check parts pointer before using it
Date: Wed, 24 Aug 2011 18:53:01 +0800 [thread overview]
Message-ID: <1314183181-4197-1-git-send-email-jason.hui@linaro.org> (raw)
The code has the check for parts but it called after kmemdup,
kmemdup(parts, sizeof(*parts) * nr_parts,...)
if (!parts)
return -ENOMEM
In fact, we need check parts before safely using it.
Signed-off-by: Jason Liu <jason.hui@linaro.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
---
This patch is based on git://git.infradead.org/users/dedekind/l2-mtd-2.6.git
---
drivers/mtd/mtdcore.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 09bdbac..ce59ff5 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -465,12 +465,10 @@ int mtd_device_parse_register(struct mtd_info *mtd, const char **types,
struct mtd_partition *real_parts;
err = parse_mtd_partitions(mtd, types, &real_parts, parser_data);
- if (err <= 0 && nr_parts) {
+ if (err <= 0 && nr_parts && !parts) {
real_parts = kmemdup(parts, sizeof(*parts) * nr_parts,
GFP_KERNEL);
err = nr_parts;
- if (!parts)
- err = -ENOMEM;
}
if (err > 0) {
--
1.7.4.1
next reply other threads:[~2011-08-24 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 10:53 Jason Liu [this message]
2011-08-24 10:53 ` [PATCH] mtd: check parts pointer before using it Jason Liu
2011-08-24 10:53 ` Jason Liu
2011-08-24 11:08 ` Jamie Iles
2011-08-24 11:08 ` Jamie Iles
2011-08-24 11:08 ` Jamie Iles
2011-08-24 11:12 ` Jason Liu
2011-08-24 11:12 ` Jason Liu
2011-08-24 11:12 ` Jason Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314183181-4197-1-git-send-email-jason.hui@linaro.org \
--to=jason.hui@linaro.org \
--cc=David.Woodhouse@intel.com \
--cc=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.