From: Tarun Kanti DebBarma <tarun.kanti@ti.com> To: linux-omap@vger.kernel.org Cc: khilman@ti.com, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Nishanth Menon <nm@ti.com>, Tarun Kanti DebBarma <tarun.kanti@ti.com> Subject: [PATCH v6 24/25] gpio/omap: restore OE only after setting the output level Date: Wed, 31 Aug 2011 19:12:40 +0530 [thread overview] Message-ID: <1314798161-19523-25-git-send-email-tarun.kanti@ti.com> (raw) In-Reply-To: <1314798161-19523-1-git-send-email-tarun.kanti@ti.com> From: Nishanth Menon <nm@ti.com> Setup the dataout register before setting the GPIO to output mode in restore path. Signed-off-by: Nishanth Menon <nm@ti.com> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com> Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- drivers/gpio/gpio-omap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index db22df8..a629498 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1326,7 +1326,6 @@ static void omap_gpio_restore_context(struct gpio_bank *bank) __raw_writel(bank->context.wake_en, bank->base + bank->regs->wkup_en); __raw_writel(bank->context.ctrl, bank->base + bank->regs->ctrl); - __raw_writel(bank->context.oe, bank->base + bank->regs->direction); __raw_writel(bank->context.leveldetect0, bank->base + bank->regs->leveldetect0); __raw_writel(bank->context.leveldetect1, @@ -1336,6 +1335,7 @@ static void omap_gpio_restore_context(struct gpio_bank *bank) __raw_writel(bank->context.fallingdetect, bank->base + bank->regs->fallingdetect); __raw_writel(bank->context.dataout, bank->base + bank->regs->dataout); + __raw_writel(bank->context.oe, bank->base + bank->regs->direction); if (bank->dbck_enable_mask) { __raw_writel(bank->context.debounce, bank->base + -- 1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: tarun.kanti@ti.com (Tarun Kanti DebBarma) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 24/25] gpio/omap: restore OE only after setting the output level Date: Wed, 31 Aug 2011 19:12:40 +0530 [thread overview] Message-ID: <1314798161-19523-25-git-send-email-tarun.kanti@ti.com> (raw) In-Reply-To: <1314798161-19523-1-git-send-email-tarun.kanti@ti.com> From: Nishanth Menon <nm@ti.com> Setup the dataout register before setting the GPIO to output mode in restore path. Signed-off-by: Nishanth Menon <nm@ti.com> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com> Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- drivers/gpio/gpio-omap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index db22df8..a629498 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1326,7 +1326,6 @@ static void omap_gpio_restore_context(struct gpio_bank *bank) __raw_writel(bank->context.wake_en, bank->base + bank->regs->wkup_en); __raw_writel(bank->context.ctrl, bank->base + bank->regs->ctrl); - __raw_writel(bank->context.oe, bank->base + bank->regs->direction); __raw_writel(bank->context.leveldetect0, bank->base + bank->regs->leveldetect0); __raw_writel(bank->context.leveldetect1, @@ -1336,6 +1335,7 @@ static void omap_gpio_restore_context(struct gpio_bank *bank) __raw_writel(bank->context.fallingdetect, bank->base + bank->regs->fallingdetect); __raw_writel(bank->context.dataout, bank->base + bank->regs->dataout); + __raw_writel(bank->context.oe, bank->base + bank->regs->direction); if (bank->dbck_enable_mask) { __raw_writel(bank->context.debounce, bank->base + -- 1.7.0.4
next prev parent reply other threads:[~2011-08-31 13:43 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-31 13:42 [PATCH v6 00/25] gpio/omap: driver cleanup and fixes Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 01/25] gpio/omap: remove dependency on gpio_bank_count Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 02/25] gpio/omap: use flag to identify wakeup domain Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 03/25] gpio/omap: make gpio_context part of gpio_bank structure Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 04/25] gpio/omap: fix pwrdm_post_transition call sequence Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 05/25] gpio/omap: handle save/restore context in GPIO driver Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 06/25] gpio/omap: make non-wakeup GPIO part of pdata Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 07/25] gpio/omap: avoid cpu checks during module ena/disable Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 08/25] gpio/omap: further cleanup using wkup_en register Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 09/25] gpio/omap: use level/edge detect reg offsets Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 10/25] gpio/omap: remove hardcoded offsets in context save/restore Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 11/25] gpio/omap: cleanup set_gpio_triggering function Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 12/25] gpio/omap: cleanup omap_gpio_mod_init function Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 13/25] gpio/omap: use pinctrl offset instead of macro Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 14/25] gpio/omap: remove unnecessary bit-masking for read access Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 15/25] gpio/omap: remove bank->method & METHOD_* macros Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 16/25] gpio/omap: fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 17/25] gpio/omap: use pm-runtime framework Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-09-06 23:49 ` Kevin Hilman 2011-09-06 23:49 ` Kevin Hilman 2011-09-07 5:04 ` DebBarma, Tarun Kanti 2011-09-07 5:04 ` DebBarma, Tarun Kanti 2011-09-07 12:32 ` Kevin Hilman 2011-09-07 12:32 ` Kevin Hilman 2011-09-07 12:53 ` DebBarma, Tarun Kanti 2011-09-07 12:53 ` DebBarma, Tarun Kanti 2011-09-09 12:32 ` DebBarma, Tarun Kanti 2011-09-09 12:32 ` DebBarma, Tarun Kanti 2011-09-09 12:54 ` DebBarma, Tarun Kanti 2011-09-09 12:54 ` DebBarma, Tarun Kanti 2011-09-09 18:04 ` Kevin Hilman 2011-09-09 18:04 ` Kevin Hilman 2011-09-09 18:55 ` DebBarma, Tarun Kanti 2011-09-09 18:55 ` DebBarma, Tarun Kanti 2011-09-09 21:00 ` Kevin Hilman 2011-09-09 21:00 ` Kevin Hilman 2011-08-31 13:42 ` [PATCH v6 18/25] gpio/omap: optimize suspend and resume functions Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-08-31 13:42 ` [PATCH v6 19/25] gpio/omap: cleanup prepare_for_idle and resume_after_idle Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-09-06 23:53 ` Kevin Hilman 2011-09-06 23:53 ` Kevin Hilman 2011-09-07 5:17 ` DebBarma, Tarun Kanti 2011-09-07 5:17 ` DebBarma, Tarun Kanti 2011-08-31 13:42 ` [PATCH v6 20/25] gpio/omap: skip operations in runtime callbacks Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-09-06 23:54 ` Kevin Hilman 2011-09-06 23:54 ` Kevin Hilman 2011-09-07 5:33 ` DebBarma, Tarun Kanti 2011-09-07 5:33 ` DebBarma, Tarun Kanti 2011-08-31 13:42 ` [PATCH v6 21/25] gpio/omap: remove omap_gpio_save_context overhead Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-09-06 23:57 ` Kevin Hilman 2011-09-06 23:57 ` Kevin Hilman 2011-08-31 13:42 ` [PATCH v6 22/25] gpio/omap: save and restore debounce registers Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-09-07 0:03 ` Kevin Hilman 2011-09-07 0:03 ` Kevin Hilman 2011-09-07 6:16 ` DebBarma, Tarun Kanti 2011-09-07 6:16 ` DebBarma, Tarun Kanti 2011-08-31 13:42 ` [PATCH v6 23/25] gpio/omap: enable irq at the end of all configuration in restore Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-09-07 0:08 ` Kevin Hilman 2011-09-07 0:08 ` Kevin Hilman 2011-08-31 13:42 ` Tarun Kanti DebBarma [this message] 2011-08-31 13:42 ` [PATCH v6 24/25] gpio/omap: restore OE only after setting the output level Tarun Kanti DebBarma 2011-09-07 0:06 ` Kevin Hilman 2011-09-07 0:06 ` Kevin Hilman 2011-09-07 6:18 ` DebBarma, Tarun Kanti 2011-09-07 6:18 ` DebBarma, Tarun Kanti 2011-08-31 13:42 ` [PATCH v6 25/25] gpio/omap: handle set_dataout reg capable IP on restore Tarun Kanti DebBarma 2011-08-31 13:42 ` Tarun Kanti DebBarma 2011-09-07 0:07 ` Kevin Hilman 2011-09-07 0:07 ` Kevin Hilman 2011-09-07 7:35 ` DebBarma, Tarun Kanti 2011-09-07 7:35 ` DebBarma, Tarun Kanti 2011-09-06 22:59 ` [PATCH v6 00/25] gpio/omap: driver cleanup and fixes Kevin Hilman 2011-09-06 22:59 ` Kevin Hilman 2011-09-07 5:24 ` DebBarma, Tarun Kanti 2011-09-07 5:24 ` DebBarma, Tarun Kanti 2011-09-10 0:54 ` DebBarma, Tarun Kanti 2011-09-10 0:54 ` DebBarma, Tarun Kanti 2011-09-11 8:37 ` Russell King - ARM Linux 2011-09-11 8:37 ` Russell King - ARM Linux 2011-09-12 16:39 ` Kevin Hilman 2011-09-12 16:39 ` Kevin Hilman 2011-09-06 23:25 ` Kevin Hilman 2011-09-06 23:25 ` Kevin Hilman 2011-09-07 5:31 ` DebBarma, Tarun Kanti 2011-09-07 5:31 ` DebBarma, Tarun Kanti 2011-09-12 11:44 ` DebBarma, Tarun Kanti 2011-09-12 11:44 ` DebBarma, Tarun Kanti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1314798161-19523-25-git-send-email-tarun.kanti@ti.com \ --to=tarun.kanti@ti.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=nm@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.